Leahnaya/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-08-24 19:36:01 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve usage of std::move and const references parameters

Browse Source 
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
Martino Fontana
2026-04-06 11:37:26 +02:00
parent 33f62b0f9f
commit 95dec13203
140 changed files with 318 additions and 277 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/DolphinQt/Settings.cpp
View File

@@ -534,7 +534,7 @@ QString Settings::GetDefaultGame() const
return QString::fromStdString(Config::Get(Config::MAIN_DEFAULT_ISO));
}
void Settings::SetDefaultGame(QString path)
void Settings::SetDefaultGame(const QString& path)
{
if (GetDefaultGame() != path)
{
@@ -833,7 +833,7 @@ void Settings::RefreshWidgetVisibility()
emit GameCountVisibilityChanged(IsGameCountVisible());
}
void Settings::SetDebugFont(QFont font)
void Settings::SetDebugFont(const QFont& font)
{
if (GetDebugFont() != font)
{