Improve usage of std::move and const references parameters

Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
Martino Fontana
2026-04-06 11:37:26 +02:00
parent 33f62b0f9f
commit 95dec13203
140 changed files with 318 additions and 277 deletions

View File

@@ -23,6 +23,7 @@
#include <QTextBrowser>
#include <algorithm>
#include <utility>
#ifdef HAS_LIBMGBA
#include <fmt/ranges.h>
@@ -500,7 +501,7 @@ void NetPlayDialog::reject()
void NetPlayDialog::show(std::string nickname, bool use_traversal)
{
m_nickname = nickname;
m_nickname = std::move(nickname);
m_use_traversal = use_traversal;
m_buffer_size = 0;
m_old_player_count = 0;