Leahnaya/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-08-17 07:47:23 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve usage of std::move and const references parameters

Browse Source 
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
Martino Fontana
2026-04-06 11:37:26 +02:00
parent 33f62b0f9f
commit 95dec13203
140 changed files with 318 additions and 277 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Source/Core/DolphinQt/MainWindow.cpp
View File

@@ -22,6 +22,7 @@
#include <future>
#include <optional>
#include <utility>
#include <variant>
#if defined(__unix__) || defined(__unix) || defined(__APPLE__)
@@ -201,7 +202,7 @@ static WindowSystemInfo GetWindowSystemInfo(QWindow* window)
return wsi;
}
static std::vector<std::string> StringListToStdVector(QStringList list)
static std::vector<std::string> StringListToStdVector(const QStringList& list)
{
std::vector<std::string> result;
result.reserve(list.size());
@@ -474,7 +475,7 @@ void MainWindow::CreateComponents()
m_code_widget = new CodeWidget(this);
m_assembler_widget = new AssemblerWidget(this);
const auto request_watch = [this](QString name, u32 addr) {
const auto request_watch = [this](const QString& name, u32 addr) {
m_watch_widget->AddWatch(name, addr);
};
const auto request_breakpoint = [this](u32 addr) { m_breakpoint_widget->AddBP(addr); };