Leahnaya/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-10-01 14:47:02 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve usage of std::move and const references parameters

Browse Source 
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
Martino Fontana
2026-04-06 11:37:26 +02:00
parent 33f62b0f9f
commit 95dec13203
140 changed files with 318 additions and 277 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/Common/FileSearch.cpp
View File

@@ -71,13 +71,13 @@ std::vector<std::string> DoFileSearch(std::span<const std::string_view> director
std::error_code error;
if (recursive)
{
for (auto it = fs::recursive_directory_iterator(std::move(directory_path), error);
for (auto it = fs::recursive_directory_iterator(directory_path, error);
it != fs::recursive_directory_iterator(); it.increment(error))
add_filtered(*it);
}
else
{
for (auto it = fs::directory_iterator(std::move(directory_path), error);
for (auto it = fs::directory_iterator(directory_path, error);
it != fs::directory_iterator(); it.increment(error))
add_filtered(*it);
}