Leahnaya/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-08-17 15:58:16 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Core: Address -Wrange-loop-construct warning.

Browse Source 
The warning can be seen since 1f72403ec7 when GCC 13.3.0 is used:

```counterexample
[1540/1898] Building CXX object Source/Core/VideoCommon/CMakeFiles/videocommon.dir/TextureCacheBase.cpp.o
/w/dolphin/Source/Core/VideoCommon/TextureCacheBase.cpp: In member function 'void TextureCacheBase::ApplyMaterialToCacheEntry(const VideoCommon::MaterialResource&, TCacheEntry*)':
/w/dolphin/Source/Core/VideoCommon/TextureCacheBase.cpp:3136:19: warning: loop variable 'texture' creates a copy from type 'const VideoCommon::MaterialResource::TextureLikeReference' [-Wrange-loop-construct]
 3136 |   for (const auto texture : material_data->GetTextures())
      |                   ^~~~~~~
/w/dolphin/Source/Core/VideoCommon/TextureCacheBase.cpp:3136:19: note: use reference type to prevent copying
 3136 |   for (const auto texture : material_data->GetTextures())
      |                   ^~~~~~~
      |                   &
```
This commit is contained in:
cristian64
2026-04-18 10:23:55 +01:00
parent 42175d4e75
commit 6059045c59
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/VideoCommon/TextureCacheBase.cpp
View File

@@ -3133,7 +3133,7 @@ void TextureCacheBase::ApplyMaterialToCacheEntry(const VideoCommon::MaterialReso
g_gfx->SetTexture(0, entry->texture.get());
g_gfx->SetSamplerState(0, RenderState::GetPointSamplerState());
for (const auto texture : material_data->GetTextures())
for (const auto& texture : material_data->GetTextures())
{
g_gfx->SetTexture(texture.sampler_index, texture.texture);
g_gfx->SetSamplerState(texture.sampler_index, texture.sampler);