From 5eaaba5a4328d63ab7fe1147c9478ebda26746ff Mon Sep 17 00:00:00 2001 From: debug687 <313431556+debug687@users.noreply.github.com> Date: Mon, 19 Oct 2026 21:29:55 +0000 Subject: [PATCH] DolphinQt: Fix crash from stale timer event in ToolTipWidget LLM generated explaination for the LLM generated commit: A queued QTimerEvent can be dispatched after the timer was already killed (Qt recycles timer ids), e.g. when a slider is dragged and enter/leave events fire in rapid succession. In that case m_timer_id is empty and dereferencing it in timerEvent() asserts on 'this->_M_is_engaged()' in debug builds, while in release builds it passes a garbage timer id to killTimer(). Only process the event if it matches the timer we are tracking, which also prevents showing a balloon for a stale event. --- .../Config/ToolTipControls/ToolTipWidget.h | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/Source/Core/DolphinQt/Config/ToolTipControls/ToolTipWidget.h b/Source/Core/DolphinQt/Config/ToolTipControls/ToolTipWidget.h index 94cd88b87e..cbcbccefd7 100644 --- a/Source/Core/DolphinQt/Config/ToolTipControls/ToolTipWidget.h +++ b/Source/Core/DolphinQt/Config/ToolTipControls/ToolTipWidget.h @@ -6,6 +6,7 @@ #include #include +#include #include "DolphinQt/Config/ToolTipControls/BalloonTip.h" @@ -57,12 +58,14 @@ private: void timerEvent(QTimerEvent* const event) override { - this->killTimer(*m_timer_id); - m_timer_id.reset(); - - BalloonTip::ShowBalloon(m_title, m_description, - this->parentWidget()->mapToGlobal(GetToolTipPosition()), this); + if (m_timer_id == event->timerId()) + { + this->killTimer(*m_timer_id); + m_timer_id.reset(); + BalloonTip::ShowBalloon(m_title, m_description, + this->parentWidget()->mapToGlobal(GetToolTipPosition()), this); + } Derived::timerEvent(event); }