Leahnaya/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-08-20 01:15:08 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Replace some [[maybe_unused]] annotations with commented names

Browse Source 
Remove the [[maybe_unused]] annotation from various parameters that are
unconditionally unused and comment out their names instead. This makes
it unambiguous that the variables are unused, while making the remaining
[[maybe_unused]] annotations more reliable indicators that those
variables are in fact used in some contexts.

These parameters are mostly in overridden functions where the override
doesn't need that particular variable.
This commit is contained in:
Dentomologist
2026-05-03 17:09:59 -07:00
parent eb44b64c9e
commit 34646cb9a9
8 changed files with 25 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Source/Core/VideoBackends/Software/SWGfx.cpp
View File

@@ -35,7 +35,7 @@ bool SWGfx::SupportsUtilityDrawing() const
}
std::unique_ptr<AbstractTexture> SWGfx::CreateTexture(const TextureConfig& config,
[[maybe_unused]] std::string_view name)
std::string_view /* name */)
{
return std::make_unique<SWTexture>(config);
}
@@ -77,16 +77,17 @@ public:
};
std::unique_ptr<AbstractShader>
SWGfx::CreateShaderFromSource(ShaderStage stage, [[maybe_unused]] std::string_view source,
[[maybe_unused]] VideoCommon::ShaderIncluder* shader_includer,
[[maybe_unused]] std::string_view name)
SWGfx::CreateShaderFromSource(ShaderStage stage, std::string_view /* source */,
VideoCommon::ShaderIncluder* /* shader_includer */,
std::string_view /* name */)
{
return std::make_unique<SWShader>(stage);
}
std::unique_ptr<AbstractShader>
SWGfx::CreateShaderFromBinary(ShaderStage stage, const void* data, size_t length,
[[maybe_unused]] std::string_view name)
std::unique_ptr<AbstractShader> SWGfx::CreateShaderFromBinary(ShaderStage stage,
const void* /* data */,
size_t /* length */,
std::string_view /* name */)
{
return std::make_unique<SWShader>(stage);
}