From 769a484fc177012a8867caa1ded3d451ebaa699f Mon Sep 17 00:00:00 2001
From: sk1982 <sk1982@noreply.gitea.tendokyu.moe>
Date: Sun, 31 Mar 2024 22:59:54 -0400
Subject: [PATCH] fix: sync chuni team names

---
 src/actions/team.ts | 82 ++++++++++++++++++++++++---------------------
 1 file changed, 44 insertions(+), 38 deletions(-)

diff --git a/src/actions/team.ts b/src/actions/team.ts
index 557a757..e075224 100644
--- a/src/actions/team.ts
+++ b/src/actions/team.ts
@@ -13,27 +13,54 @@ import { makeValidator } from '@/types/validator-map';
 import { DB } from '@/types/db';
 import { randomString } from '@/helpers/random';
 
+const validator = makeValidator<TeamUpdate, DB['actaeon_teams'] | null>()
+	.nonNullableKeys('name', 'joinPrivacy', 'visibility')
+	.withValidator('name', async (val, team) => {
+		val = val.trim();
+
+		if (!val)
+			throw new Error('Team name cannot be empty');
+
+		const existingTeam = await db.selectFrom('actaeon_teams')
+			.where(({ fn, eb, and }) => and([
+				eb(fn('lower', ['name']), '=', val.toLowerCase()),
+				...(team ? [eb('uuid', '!=', team.uuid)] : [])
+			]))
+			.select('uuid')
+			.executeTakeFirst();
+
+		if (existingTeam)
+			throw new Error('A team with that name already exists');
+
+		return val;
+	})
+	.withValidator('joinPrivacy', val => {
+		if (!PRIVACY_VALUES.has(val))
+			throw new Error('Invalid privacy value');
+	})
+	.withValidator('visibility', val => {
+		if (!VISIBILITY_VALUES.has(val))
+			throw new Error('Invalid visibility value');
+	});
+
+
 export const createTeam = async (name: string): Promise<ActionResult> => {
 	const user = await requireUser();
 
 	if (user.team)
 		return { error: true, message: 'You are already part of a team' };
 
-	name = name.trim();
-	const existingTeam = await db.selectFrom('actaeon_teams')
-		.where(({ fn, eb }) => eb(fn('lower', ['name']), '=', name.toLowerCase()))
-		.select('name')
-		.executeTakeFirst();
-	
-	if (existingTeam)
-		return { error: true, message: 'A team with that name already exists' };
+	const data = await validator.validate({ name }, null);
+
+	if (data.error)
+		return data;
 
 	const uuid = crypto.randomUUID();
 	
 	await db.transaction().execute(async trx => {
 		const chuniTeam = Number((await db.insertInto('chuni_profile_team')
 			.values({
-				teamName: name,
+				teamName: data.value.name,
 				teamPoint: 0
 			})
 			.executeTakeFirst()).insertId);
@@ -41,7 +68,7 @@ export const createTeam = async (name: string): Promise<ActionResult> => {
 		await db.insertInto('actaeon_teams')
 			.values({
 				uuid,
-				name,
+				name: data.value.name,
 				visibility: Visibility.PRIVATE,
 				joinPrivacy: JoinPrivacy.INVITE_ONLY,
 				owner: user.id!,
@@ -91,33 +118,6 @@ export type TeamUpdate = Partial<{
 	visibility: Visibility
 }>;
 
-const validator = makeValidator<TeamUpdate, DB['actaeon_teams'] | null>()
-	.nonNullableKeys('name', 'joinPrivacy', 'visibility')
-	.withValidator('name', async (val, team) => {
-		val = val.trim();
-
-		const existingTeam = await db.selectFrom('actaeon_teams')
-			.where(({ fn, eb, and }) => and([
-				eb(fn('lower', ['name']), '=', val.toLowerCase()),
-				...(team ? [eb('uuid', '!=', team.uuid)] : [])
-			]))
-			.select('uuid')
-			.executeTakeFirst();
-		
-		if (existingTeam)
-			throw new Error('A team with that name already exists');
-
-		return val;
-	})
-	.withValidator('joinPrivacy', val => {
-		if (!PRIVACY_VALUES.has(val))
-			throw new Error('Invalid privacy value');
-	})
-	.withValidator('visibility', val => {
-		if (!VISIBILITY_VALUES.has(val))
-			throw new Error('Invalid visibility value');
-	});
-
 export const modifyTeam = async (team: string, update: TeamUpdate): Promise<ActionResult<{}>> => {
 	const teamData = await requireOwner({ team });
 	const res = await validator.validate(update, teamData);
@@ -125,8 +125,14 @@ export const modifyTeam = async (team: string, update: TeamUpdate): Promise<Acti
 
 	await db.updateTable('actaeon_teams')
 		.where('uuid', '=', team)
-		.set(update)
+		.set(res.value)
 		.executeTakeFirst();
+	
+	if (res.value.name)
+		await db.updateTable('chuni_profile_team')
+			.where('id', '=', teamData.chuniTeam)
+			.set({ teamName: res.value.name })
+			.executeTakeFirst()
 
 	return {};
 };