From c9feca9ada3b5d1611c6fba5ead8fb040391e4e6 Mon Sep 17 00:00:00 2001
From: Jonathan Barrow <jonbarrow1998@gmail.com>
Date: Mon, 26 Sep 2022 22:57:39 -0400
Subject: [PATCH] NASC middleware now uses Mongo transaction

---
 src/middleware/nasc.js | 70 ++++++++++++++++++++++++++----------------
 1 file changed, 44 insertions(+), 26 deletions(-)

diff --git a/src/middleware/nasc.js b/src/middleware/nasc.js
index e24756f..32f0782 100644
--- a/src/middleware/nasc.js
+++ b/src/middleware/nasc.js
@@ -2,6 +2,7 @@ const crypto = require('crypto');
 const { Device } = require('../models/device');
 const { NEXAccount } = require('../models/nex-account');
 const util = require('../util');
+const database = require('../database');
 const NintendoCertificate = require('../nintendo-certificate');
 
 async function NASCMiddleware(request, response, next) {
@@ -109,36 +110,53 @@ async function NASCMiddleware(request, response, next) {
 		if (password && !pid && !pidHmac) {
 			// Register new user
 
-			// Create new NEX account
-			const newNEXAccount = new NEXAccount({
-				pid: 0,
-				password: '',
-				owning_pid: 0,
-			});
-			await newNEXAccount.save();
+			const session = await database.connection.startSession();
+			await session.startTransaction();
 
-			pid = newNEXAccount.get('pid');
+			try {
+				// Create new NEX account
+				const nexAccountResult = await NEXAccount.create([{
+					pid: 0,
+					password: '',
+					owning_pid: 0,
+				}], { session });
 
-			// Set password
-			await NEXAccount.updateOne({ pid }, { password });
+				const nexAccount = nexAccountResult[0];
 
-			if (!device) {
-				const deviceDocument = {
-					is_emulator: false,
-					model,
-					serial: serialNumber,
-					environment,
-					mac_hash: macAddressHash,
-					fcdcert_hash: fcdcertHash,
-					linked_pids: [pid]
-				};
-				
-				device = new Device(deviceDocument);
-			} else {
-				device.linked_pids.push(pid);
+				pid = nexAccount.get('pid');
+
+				// Set password
+				await NEXAccount.updateOne({ pid }, { password }, { session });
+
+				if (!device) {
+					device = new Device({
+						is_emulator: false,
+						model,
+						serial: serialNumber,
+						environment,
+						mac_hash: macAddressHash,
+						fcdcert_hash: fcdcertHash,
+						linked_pids: [pid]
+					});
+				} else {
+					device.linked_pids.push(pid);
+				}
+
+				await device.save({ session });
+
+				await session.commitTransaction();
+			} catch (error) {
+				logger.error('[NASC] REGISTER ACCOUNT: ' + error);
+
+				await session.abortTransaction();
+
+				// 3DS expects 200 even on error
+				return response.status(200).send(util.nascError('102'));
+			} finally {
+				// * This runs regardless of failure
+				// * Returning on catch will not prevent this from running
+				await session.endSession();
 			}
-
-			await device.save();
 		}
 	}