From b9481892e0bc1098271a45f0d5692ff0f7e75ef6 Mon Sep 17 00:00:00 2001
From: Jonathan Barrow <jonbarrow1998@gmail.com>
Date: Sat, 29 Apr 2023 15:39:20 -0400
Subject: [PATCH] Removed unsafe .get() calls from Mongoose documents

---
 src/middleware/nasc.ts | 4 ++--
 src/models/pnid.ts     | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/middleware/nasc.ts b/src/middleware/nasc.ts
index 5c0e083..3786908 100644
--- a/src/middleware/nasc.ts
+++ b/src/middleware/nasc.ts
@@ -100,13 +100,13 @@ async function NASCMiddleware(request: express.Request, response: express.Respon
 	});
 
 	if (device) {
-		if (device.get('access_level') < 0) {
+		if (device.access_level < 0) {
 			response.status(200).send(nascError('102').toString());
 			return;
 		}
 
 		if (pid) {
-			const linkedPIDs = device.get('linked_pids');
+			const linkedPIDs: number[] = device.linked_pids;
 
 			if (!linkedPIDs.includes(pid)) {
 				response.status(200).send(nascError('102').toString());
diff --git a/src/models/pnid.ts b/src/models/pnid.ts
index 10964e4..72504ba 100644
--- a/src/models/pnid.ts
+++ b/src/models/pnid.ts
@@ -192,7 +192,7 @@ PNIDSchema.method('updateMii', async function updateMii({ name, primary, data }:
 });
 
 PNIDSchema.method('generateMiiImages', async function generateMiiImages(): Promise<void> {
-	const miiData: string = this.get('mii.data');
+	const miiData: string = this.mii.data;
 	const mii: Mii = new Mii(Buffer.from(miiData, 'base64'));
 	const miiStudioUrl: string = mii.studioUrl({
 		type: 'face',
@@ -203,7 +203,7 @@ PNIDSchema.method('generateMiiImages', async function generateMiiImages(): Promi
 	const pngData: ImageData = await imagePixels(miiStudioNormalFaceImageData);
 	const tga: Buffer = TGA.createTgaBuffer(pngData.width, pngData.height, Uint8Array.from(pngData.data), false);
 
-	const userMiiKey: string = `mii/${this.get('pid')}`;
+	const userMiiKey: string = `mii/${this.pid}`;
 
 	await uploadCDNAsset('pn-cdn', `${userMiiKey}/standard.tga`, tga, 'public-read');
 	await uploadCDNAsset('pn-cdn', `${userMiiKey}/normal_face.png`, miiStudioNormalFaceImageData, 'public-read');