- use const auto& where possible

- avoid using const std::unique_ptr& and const std::shared_ptr&
- avoid wrapping results in std::optional
- prefer std::string_view over const std::string&
- update FSUtils::LoadFileToMem to write into std::vector<uint8_t>
- use std::span when possible
- Avoid unnessecary copies in PluginDataFactory
- allocate plugins as HeapMemoryFixedSize which bascially is a std::unique_ptr with fixed size

source/utils/utils.h

@@ -1,11 +1,13 @@
 #pragma once
 
+#include <algorithm>
 #include <coreinit/dynload.h>
 #include <cstdint>
 #include <forward_list>
 #include <malloc.h>
 #include <memory>
 #include <mutex>
+#include <set>
 
 #ifdef __cplusplus
 extern "C" {
@@ -60,17 +62,16 @@ std::shared_ptr<T> make_shared_nothrow(Args &&...args) noexcept(noexcept(T(std::
     return std::shared_ptr<T>(new (std::nothrow) T(std::forward<Args>(args)...));
 }
 
-template<typename T, class Allocator, class Predicate>
-bool remove_locked_first_if(std::mutex &mutex, std::forward_list<T, Allocator> &list, Predicate pred) {
+template<typename Container, typename Predicate>
+bool remove_locked_first_if(std::mutex &mutex, Container &container, Predicate pred) {
     std::lock_guard<std::mutex> lock(mutex);
-    auto oit = list.before_begin(), it = std::next(oit);
-    while (it != list.end()) {
-        if (pred(*it)) {
-            list.erase_after(oit);
-            return true;
-        }
-        oit = it++;
+
+    auto it = std::find_if(container.begin(), container.end(), pred);
+    if (it != container.end()) {
+        container.erase(it);
+        return true;
     }
+
     return false;
 }