- use const auto& where possible

- avoid using const std::unique_ptr& and const std::shared_ptr&
- avoid wrapping results in std::optional
- prefer std::string_view over const std::string&
- update FSUtils::LoadFileToMem to write into std::vector<uint8_t>
- use std::span when possible
- Avoid unnessecary copies in PluginDataFactory
- allocate plugins as HeapMemoryFixedSize which bascially is a std::unique_ptr with fixed size

source/utils/StringTools.h

@@ -34,8 +34,8 @@
 #include <wut_types.h>
 
 template<typename... Args>
-std::string string_format(const std::string &format, Args... args) {
-    int size_s = std::snprintf(nullptr, 0, format.c_str(), args...) + 1; // Extra space for '\0'
+std::string string_format(std::string_view format, Args... args) {
+    int size_s = std::snprintf(nullptr, 0, format.data(), args...) + 1; // Extra space for '\0'
     auto size  = static_cast<size_t>(size_s);
     auto buf   = make_unique_nothrow<char[]>(size);
     if (!buf) {
@@ -43,11 +43,10 @@ std::string string_format(const std::string &format, Args... args) {
         OSFatal("string_format failed, not enough memory");
         return std::string("");
     }
-    std::snprintf(buf.get(), size, format.c_str(), args...);
+    std::snprintf(buf.get(), size, format.data(), args...);
     return std::string(buf.get(), buf.get() + size - 1); // We don't want the '\0' inside
 }
 
-
 class StringTools {
 public:
     static std::string truncate(const std::string &str, size_t width, bool show_ellipsis = true);