From 3d8db458cdaf2cb9e48a4bb2e36817c2a6d253a1 Mon Sep 17 00:00:00 2001 From: matsutaka Date: Wed, 12 Mar 2025 15:49:05 +0900 Subject: [PATCH 1/2] =?UTF-8?q?chore:=20ArraySegment.ToArray()=E3=81=AE?= =?UTF-8?q?=E5=91=BC=E3=81=B3=E5=87=BA=E3=81=97=E3=81=AB=E3=82=88=E3=82=8B?= =?UTF-8?q?GC=20Alloc=E3=82=92=E8=BB=BD=E6=B8=9B?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ArraySegment.AsSpan() によって Span を取得し、 NativeArray.AsSpan() で得たコピー先 Span に向けて Span.CopyTo() によるコピーを行う。 data.Array[] による ArraySegment.ToArray() の呼び出しが無くなった結果、 GC Alloc が減少する。 --- Assets/UniGLTF/Runtime/UniGLTF/IO/NativeArrayManager.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/NativeArrayManager.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/NativeArrayManager.cs index b02250bbb..3fdce7985 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/NativeArrayManager.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/NativeArrayManager.cs @@ -69,8 +69,9 @@ namespace UniGLTF public NativeArray CreateNativeArray(ArraySegment data) where T : struct { var array = CreateNativeArray(data.Count); - for (int i = 0; i < data.Count; i++) - array[i] = data.Array[data.Offset + i]; + var toSpan = array.AsSpan(); + var fromSpan = data.AsSpan(); + fromSpan.CopyTo(toSpan); return array; } From 559a363fe60948ebb327d1858192e0b79f0d64a3 Mon Sep 17 00:00:00 2001 From: ousttrue Date: Thu, 13 Mar 2025 17:09:20 +0900 Subject: [PATCH 2/2] CurrentTails in center local coordinates. --- .../SpringBoneJobs/FastSpringBoneConbinedBuffer.cs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Assets/UniGLTF/Runtime/SpringBoneJobs/FastSpringBoneConbinedBuffer.cs b/Assets/UniGLTF/Runtime/SpringBoneJobs/FastSpringBoneConbinedBuffer.cs index f06f3f70a..bae4fd0e9 100644 --- a/Assets/UniGLTF/Runtime/SpringBoneJobs/FastSpringBoneConbinedBuffer.cs +++ b/Assets/UniGLTF/Runtime/SpringBoneJobs/FastSpringBoneConbinedBuffer.cs @@ -300,6 +300,7 @@ namespace UniGLTF.SpringBoneJobs public void Execute(int springIndex) { var spring = Springs[springIndex]; + var center = spring.centerTransformIndex >= 0 ? Transforms[spring.centerTransformIndex] : (BlittableTransform?)null; for (int jointIndex = spring.logicSpan.startIndex; jointIndex < spring.logicSpan.EndIndex; ++jointIndex) { if (float.IsNaN(CurrentTails[jointIndex].x)) @@ -317,9 +318,10 @@ namespace UniGLTF.SpringBoneJobs } var tail = Transforms[tailIndex]; - CurrentTails[jointIndex] = tail.position; - PrevTails[jointIndex] = tail.position; - NextTails[jointIndex] = tail.position; + var tailPos = center.HasValue ? center.Value.worldToLocalMatrix.MultiplyPoint3x4(tail.position) : tail.position; + CurrentTails[jointIndex] = tailPos; + PrevTails[jointIndex] = tailPos; + NextTails[jointIndex] = tailPos; } } }