From 9f16a268a6934db5570fdc4b3a22a801dac63010 Mon Sep 17 00:00:00 2001 From: Masataka SUMI Date: Thu, 10 Nov 2022 21:26:02 +0900 Subject: [PATCH 1/4] rename --- .../UniGLTF/ScriptedImporter/GlbScriptedImporterEditor.cs | 2 +- .../UniGLTF/ScriptedImporter/GltfScriptedImporterBase.cs | 6 +++--- .../ScriptedImporter/GltfScriptedImporterEditor.cs | 2 +- .../ZipArchivedGltfScriptedImporterEditor.cs | 2 +- Assets/UniGLTF/Runtime/UniGLTF/IO/ImporterContext.cs | 2 +- ...rator.cs => BuiltInGltfMaterialDescriptorGenerator.cs} | 8 ++++---- ...eta => BuiltInGltfMaterialDescriptorGenerator.cs.meta} | 0 ...erialImporter.cs => BuiltInGltfPbrMaterialImporter.cs} | 4 ++-- ...ter.cs.meta => BuiltInGltfPbrMaterialImporter.cs.meta} | 0 ...ialImporter.cs => BuiltInGltfUnlitMaterialImporter.cs} | 4 ++-- ...r.cs.meta => BuiltInGltfUnlitMaterialImporter.cs.meta} | 0 ...PMaterialImporter.cs => UrpGltfPbrMaterialImporter.cs} | 4 ++-- ...mporter.cs.meta => UrpGltfPbrMaterialImporter.cs.meta} | 0 ...Generator.cs => UrpGltfMaterialDescriptorGenerator.cs} | 8 ++++---- ...cs.meta => UrpGltfMaterialDescriptorGenerator.cs.meta} | 0 Assets/UniGLTF/Tests/UniGLTF/GltfLoadTests.cs | 2 +- .../BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs | 8 ++++---- .../URP/Import/VRMURPMaterialDescriptorGenerator.cs | 8 ++++---- .../VRM10/Editor/ScriptedImporter/VrmScriptedImporter.cs | 2 +- .../BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs | 6 +++--- .../URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs | 8 ++++---- Assets/VRM10_Samples/VRM10Viewer/VRM10ViewerUI.cs | 4 ++-- Assets/VRM_Samples/SimpleViewer/ViewerUI.cs | 4 ++-- 23 files changed, 42 insertions(+), 42 deletions(-) rename Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/{GltfMaterialDescriptorGenerator.cs => BuiltInGltfMaterialDescriptorGenerator.cs} (75%) rename Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/{GltfMaterialDescriptorGenerator.cs.meta => BuiltInGltfMaterialDescriptorGenerator.cs.meta} (100%) rename Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/{GltfPbrMaterialImporter.cs => BuiltInGltfPbrMaterialImporter.cs} (98%) rename Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/{GltfPbrMaterialImporter.cs.meta => BuiltInGltfPbrMaterialImporter.cs.meta} (100%) rename Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/{GltfUnlitMaterialImporter.cs => BuiltInGltfUnlitMaterialImporter.cs} (96%) rename Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/{GltfUnlitMaterialImporter.cs.meta => BuiltInGltfUnlitMaterialImporter.cs.meta} (100%) rename Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/{GltfPbrURPMaterialImporter.cs => UrpGltfPbrMaterialImporter.cs} (98%) rename Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/{GltfPbrURPMaterialImporter.cs.meta => UrpGltfPbrMaterialImporter.cs.meta} (100%) rename Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/{GltfURPMaterialDescriptorGenerator.cs => UrpGltfMaterialDescriptorGenerator.cs} (79%) rename Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/{GltfURPMaterialDescriptorGenerator.cs.meta => UrpGltfMaterialDescriptorGenerator.cs.meta} (100%) diff --git a/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/GlbScriptedImporterEditor.cs b/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/GlbScriptedImporterEditor.cs index d10352f22..7e249821c 100644 --- a/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/GlbScriptedImporterEditor.cs +++ b/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/GlbScriptedImporterEditor.cs @@ -32,7 +32,7 @@ namespace UniGLTF } m_data = new GlbFileParser(m_importer.assetPath).Parse(); - var materialGenerator = new GltfMaterialDescriptorGenerator(); + var materialGenerator = new BuiltInGltfMaterialDescriptorGenerator(); var materialKeys = m_data.GLTF.materials.Select((_, i) => materialGenerator.Get(m_data, i).SubAssetKey); var textureKeys = new GltfTextureDescriptorGenerator(m_data).Get().GetEnumerable().Select(x => x.SubAssetKey); m_materialEditor = new RemapEditorMaterial(materialKeys.Concat(textureKeys), GetEditorMap, SetEditorMap); diff --git a/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/GltfScriptedImporterBase.cs b/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/GltfScriptedImporterBase.cs index 9bed4d9c4..2da25c315 100644 --- a/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/GltfScriptedImporterBase.cs +++ b/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/GltfScriptedImporterBase.cs @@ -26,7 +26,7 @@ namespace UniGLTF { if (m_renderPipeline == UniGLTF.RenderPipelineTypes.UniversalRenderPipeline) { - if (Shader.Find(UniGLTF.GltfPbrUrpMaterialImporter.ShaderName) == null) + if (Shader.Find(UniGLTF.UrpGltfPbrMaterialImporter.ShaderName) == null) { Debug.LogWarning("URP is not installed. Force to BuiltinRenderPipeline"); m_renderPipeline = UniGLTF.RenderPipelineTypes.BuiltinRenderPipeline; @@ -39,10 +39,10 @@ namespace UniGLTF switch (renderPipeline) { case RenderPipelineTypes.BuiltinRenderPipeline: - return new GltfMaterialDescriptorGenerator(); + return new BuiltInGltfMaterialDescriptorGenerator(); case RenderPipelineTypes.UniversalRenderPipeline: - return new GltfUrpMaterialDescriptorGenerator(); + return new UrpGltfMaterialDescriptorGenerator(); default: throw new System.NotImplementedException(); diff --git a/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/GltfScriptedImporterEditor.cs b/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/GltfScriptedImporterEditor.cs index 77efc711d..dd15468a5 100644 --- a/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/GltfScriptedImporterEditor.cs +++ b/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/GltfScriptedImporterEditor.cs @@ -30,7 +30,7 @@ namespace UniGLTF } m_data = new AutoGltfFileParser(m_importer.assetPath).Parse(); - var materialGenerator = new GltfMaterialDescriptorGenerator(); + var materialGenerator = new BuiltInGltfMaterialDescriptorGenerator(); var materialKeys = m_data.GLTF.materials.Select((_, i) => materialGenerator.Get(m_data, i).SubAssetKey); var textureKeys = new GltfTextureDescriptorGenerator(m_data).Get().GetEnumerable().Select(x => x.SubAssetKey); m_materialEditor = new RemapEditorMaterial(materialKeys.Concat(textureKeys), GetEditorMap, SetEditorMap); diff --git a/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/ZipArchivedGltfScriptedImporterEditor.cs b/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/ZipArchivedGltfScriptedImporterEditor.cs index e80c62a16..f37085ce5 100644 --- a/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/ZipArchivedGltfScriptedImporterEditor.cs +++ b/Assets/UniGLTF/Editor/UniGLTF/ScriptedImporter/ZipArchivedGltfScriptedImporterEditor.cs @@ -26,7 +26,7 @@ namespace UniGLTF m_importer = target as ZipArchivedGltfScriptedImporter; m_data = new AutoGltfFileParser(m_importer.assetPath).Parse(); - var materialGenerator = new GltfMaterialDescriptorGenerator(); + var materialGenerator = new BuiltInGltfMaterialDescriptorGenerator(); var materialKeys = m_data.GLTF.materials.Select((_, i) => materialGenerator.Get(m_data, i).SubAssetKey); var textureKeys = new GltfTextureDescriptorGenerator(m_data).Get().GetEnumerable().Select(x => x.SubAssetKey); m_materialEditor = new RemapEditorMaterial(materialKeys.Concat(textureKeys), GetEditorMap, SetEditorMap); diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/ImporterContext.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/ImporterContext.cs index 462fba5cd..23aba44ba 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/ImporterContext.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/ImporterContext.cs @@ -38,7 +38,7 @@ namespace UniGLTF { Data = data; TextureDescriptorGenerator = new GltfTextureDescriptorGenerator(Data); - MaterialDescriptorGenerator = materialGenerator ?? new GltfMaterialDescriptorGenerator(); + MaterialDescriptorGenerator = materialGenerator ?? new BuiltInGltfMaterialDescriptorGenerator(); ExternalObjectMap = externalObjectMap ?? new Dictionary(); textureDeserializer = textureDeserializer ?? new UnityTextureDeserializer(); diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/GltfMaterialDescriptorGenerator.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/BuiltInGltfMaterialDescriptorGenerator.cs similarity index 75% rename from Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/GltfMaterialDescriptorGenerator.cs rename to Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/BuiltInGltfMaterialDescriptorGenerator.cs index 2926b68ee..83a46454c 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/GltfMaterialDescriptorGenerator.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/BuiltInGltfMaterialDescriptorGenerator.cs @@ -9,12 +9,12 @@ namespace UniGLTF /// /// GLTF の MaterialImporter /// - public sealed class GltfMaterialDescriptorGenerator : IMaterialDescriptorGenerator + public sealed class BuiltInGltfMaterialDescriptorGenerator : IMaterialDescriptorGenerator { public MaterialDescriptor Get(GltfData data, int i) { - if (GltfUnlitMaterialImporter.TryCreateParam(data, i, out var param)) return param; - if (GltfPbrMaterialImporter.TryCreateParam(data, i, out param)) return param; + if (BuiltInGltfUnlitMaterialImporter.TryCreateParam(data, i, out var param)) return param; + if (BuiltInGltfPbrMaterialImporter.TryCreateParam(data, i, out param)) return param; // fallback if (Symbols.VRM_DEVELOP) { @@ -23,7 +23,7 @@ namespace UniGLTF return new MaterialDescriptor( GetMaterialName(i, null), - GltfPbrMaterialImporter.ShaderName, + BuiltInGltfPbrMaterialImporter.ShaderName, null, new Dictionary(), new Dictionary(), diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/GltfMaterialDescriptorGenerator.cs.meta b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/BuiltInGltfMaterialDescriptorGenerator.cs.meta similarity index 100% rename from Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/GltfMaterialDescriptorGenerator.cs.meta rename to Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/BuiltInGltfMaterialDescriptorGenerator.cs.meta diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/GltfPbrMaterialImporter.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfPbrMaterialImporter.cs similarity index 98% rename from Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/GltfPbrMaterialImporter.cs rename to Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfPbrMaterialImporter.cs index e25979413..96251ebdb 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/GltfPbrMaterialImporter.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfPbrMaterialImporter.cs @@ -39,7 +39,7 @@ namespace UniGLTF /// _ZWrite /// /// - public static class GltfPbrMaterialImporter + public static class BuiltInGltfPbrMaterialImporter { private static readonly int SrcBlend = Shader.PropertyToID("_SrcBlend"); private static readonly int DstBlend = Shader.PropertyToID("_DstBlend"); @@ -206,7 +206,7 @@ namespace UniGLTF }); matDesc = new MaterialDescriptor( - GltfMaterialDescriptorGenerator.GetMaterialName(i, src), + BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, src), ShaderName, null, textureSlots, diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/GltfPbrMaterialImporter.cs.meta b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfPbrMaterialImporter.cs.meta similarity index 100% rename from Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/GltfPbrMaterialImporter.cs.meta rename to Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfPbrMaterialImporter.cs.meta diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/GltfUnlitMaterialImporter.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfUnlitMaterialImporter.cs similarity index 96% rename from Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/GltfUnlitMaterialImporter.cs rename to Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfUnlitMaterialImporter.cs index 0f2549189..5c477c5cc 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/GltfUnlitMaterialImporter.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfUnlitMaterialImporter.cs @@ -7,7 +7,7 @@ using ColorSpace = VRMShaders.ColorSpace; namespace UniGLTF { - public static class GltfUnlitMaterialImporter + public static class BuiltInGltfUnlitMaterialImporter { private static readonly int Cutoff = Shader.PropertyToID("_Cutoff"); @@ -50,7 +50,7 @@ namespace UniGLTF } matDesc = new MaterialDescriptor( - GltfMaterialDescriptorGenerator.GetMaterialName(i, src), + BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, src), UniUnlitUtil.ShaderName, null, textureSlots, diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/GltfUnlitMaterialImporter.cs.meta b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfUnlitMaterialImporter.cs.meta similarity index 100% rename from Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/GltfUnlitMaterialImporter.cs.meta rename to Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfUnlitMaterialImporter.cs.meta diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/GltfPbrURPMaterialImporter.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/UrpGltfPbrMaterialImporter.cs similarity index 98% rename from Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/GltfPbrURPMaterialImporter.cs rename to Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/UrpGltfPbrMaterialImporter.cs index 60cf8abd5..f045857da 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/GltfPbrURPMaterialImporter.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/UrpGltfPbrMaterialImporter.cs @@ -11,7 +11,7 @@ namespace UniGLTF /// /// see: https://github.com/Unity-Technologies/Graphics/blob/v7.5.3/com.unity.render-pipelines.universal/Editor/UniversalRenderPipelineMaterialUpgrader.cs#L354-L379 /// - public static class GltfPbrUrpMaterialImporter + public static class UrpGltfPbrMaterialImporter { private static readonly int SrcBlend = Shader.PropertyToID("_SrcBlend"); private static readonly int DstBlend = Shader.PropertyToID("_DstBlend"); @@ -181,7 +181,7 @@ namespace UniGLTF }); matDesc = new MaterialDescriptor( - GltfMaterialDescriptorGenerator.GetMaterialName(i, src), + BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, src), ShaderName, null, textureSlots, diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/GltfPbrURPMaterialImporter.cs.meta b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/UrpGltfPbrMaterialImporter.cs.meta similarity index 100% rename from Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/GltfPbrURPMaterialImporter.cs.meta rename to Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/UrpGltfPbrMaterialImporter.cs.meta diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/GltfURPMaterialDescriptorGenerator.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/UrpGltfMaterialDescriptorGenerator.cs similarity index 79% rename from Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/GltfURPMaterialDescriptorGenerator.cs rename to Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/UrpGltfMaterialDescriptorGenerator.cs index c13fb5a1e..66b93fbcc 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/GltfURPMaterialDescriptorGenerator.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/UrpGltfMaterialDescriptorGenerator.cs @@ -10,12 +10,12 @@ namespace UniGLTF /// /// GLTF の MaterialImporter /// - public sealed class GltfUrpMaterialDescriptorGenerator : IMaterialDescriptorGenerator + public sealed class UrpGltfMaterialDescriptorGenerator : IMaterialDescriptorGenerator { public MaterialDescriptor Get(GltfData data, int i) { - if (GltfUnlitMaterialImporter.TryCreateParam(data, i, out var param)) return param; - if (GltfPbrUrpMaterialImporter.TryCreateParam(data, i, out param)) return param; + if (BuiltInGltfUnlitMaterialImporter.TryCreateParam(data, i, out var param)) return param; + if (UrpGltfPbrMaterialImporter.TryCreateParam(data, i, out param)) return param; // fallback if (Symbols.VRM_DEVELOP) { @@ -24,7 +24,7 @@ namespace UniGLTF return new MaterialDescriptor( GetMaterialName(i, null), - GltfPbrMaterialImporter.ShaderName, + BuiltInGltfPbrMaterialImporter.ShaderName, null, new Dictionary(), new Dictionary(), diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/GltfURPMaterialDescriptorGenerator.cs.meta b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/UrpGltfMaterialDescriptorGenerator.cs.meta similarity index 100% rename from Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/GltfURPMaterialDescriptorGenerator.cs.meta rename to Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/UrpGltfMaterialDescriptorGenerator.cs.meta diff --git a/Assets/UniGLTF/Tests/UniGLTF/GltfLoadTests.cs b/Assets/UniGLTF/Tests/UniGLTF/GltfLoadTests.cs index 2ab25dfba..118f3316b 100644 --- a/Assets/UniGLTF/Tests/UniGLTF/GltfLoadTests.cs +++ b/Assets/UniGLTF/Tests/UniGLTF/GltfLoadTests.cs @@ -226,7 +226,7 @@ namespace UniGLTF var path = Path.Combine(root.FullName, "DamagedHelmet/glTF-Binary/DamagedHelmet.glb"); using (var data = new AutoGltfFileParser(path).Parse()) { - var matDesc = new GltfMaterialDescriptorGenerator().Get(data, 0); + var matDesc = new BuiltInGltfMaterialDescriptorGenerator().Get(data, 0); Assert.AreEqual("Standard", matDesc.ShaderName); Assert.AreEqual(5, matDesc.TextureSlots.Count); var (key, value) = matDesc.EnumerateSubAssetKeyValue().First(); diff --git a/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs b/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs index 80de66b31..f4143632d 100644 --- a/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs +++ b/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs @@ -29,13 +29,13 @@ namespace VRM } // unlit - if (GltfUnlitMaterialImporter.TryCreateParam(data, i, out matDesc)) + if (BuiltInGltfUnlitMaterialImporter.TryCreateParam(data, i, out matDesc)) { return matDesc; } // pbr - if (GltfPbrMaterialImporter.TryCreateParam(data, i, out matDesc)) + if (BuiltInGltfPbrMaterialImporter.TryCreateParam(data, i, out matDesc)) { return matDesc; } @@ -43,8 +43,8 @@ namespace VRM // fallback Debug.LogWarning($"fallback"); return new MaterialDescriptor( - GltfMaterialDescriptorGenerator.GetMaterialName(i, null), - GltfPbrMaterialImporter.ShaderName, + BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, null), + BuiltInGltfPbrMaterialImporter.ShaderName, null, new Dictionary(), new Dictionary(), diff --git a/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/VRMURPMaterialDescriptorGenerator.cs b/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/VRMURPMaterialDescriptorGenerator.cs index aebbf4e0c..1f7d4a722 100644 --- a/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/VRMURPMaterialDescriptorGenerator.cs +++ b/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/VRMURPMaterialDescriptorGenerator.cs @@ -18,17 +18,17 @@ namespace VRM { // mtoon URP "MToon" shader is not ready. import fallback to unlit // unlit "UniUnlit" work in URP - if (GltfUnlitMaterialImporter.TryCreateParam(data, i, out var matDesc)) return matDesc; + if (BuiltInGltfUnlitMaterialImporter.TryCreateParam(data, i, out var matDesc)) return matDesc; // pbr "Standard" to "Universal Render Pipeline/Lit" - if (GltfPbrUrpMaterialImporter.TryCreateParam(data, i, out matDesc)) return matDesc; + if (UrpGltfPbrMaterialImporter.TryCreateParam(data, i, out matDesc)) return matDesc; // fallback if (Symbols.VRM_DEVELOP) { Debug.LogWarning($"material: {i} out of range. fallback"); } return new MaterialDescriptor( - GltfMaterialDescriptorGenerator.GetMaterialName(i, null), - GltfPbrMaterialImporter.ShaderName, + BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, null), + BuiltInGltfPbrMaterialImporter.ShaderName, null, new Dictionary(), new Dictionary(), diff --git a/Assets/VRM10/Editor/ScriptedImporter/VrmScriptedImporter.cs b/Assets/VRM10/Editor/ScriptedImporter/VrmScriptedImporter.cs index 9870da7d3..be82aec15 100644 --- a/Assets/VRM10/Editor/ScriptedImporter/VrmScriptedImporter.cs +++ b/Assets/VRM10/Editor/ScriptedImporter/VrmScriptedImporter.cs @@ -26,7 +26,7 @@ namespace UniVRM10 { if (RenderPipeline == UniGLTF.RenderPipelineTypes.UniversalRenderPipeline) { - if (Shader.Find(UniGLTF.GltfPbrUrpMaterialImporter.ShaderName) == null) + if (Shader.Find(UniGLTF.UrpGltfPbrMaterialImporter.ShaderName) == null) { Debug.LogWarning("URP is not installed. Force to BuiltinRenderPipeline"); RenderPipeline = UniGLTF.RenderPipelineTypes.BuiltinRenderPipeline; diff --git a/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs b/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs index c483adfb2..821be9b15 100644 --- a/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs +++ b/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs @@ -13,16 +13,16 @@ namespace UniVRM10 // mtoon if (Vrm10MToonMaterialImporter.TryCreateParam(data, i, out MaterialDescriptor matDesc)) return matDesc; // unlit - if (GltfUnlitMaterialImporter.TryCreateParam(data, i, out matDesc)) return matDesc; + if (BuiltInGltfUnlitMaterialImporter.TryCreateParam(data, i, out matDesc)) return matDesc; // pbr - if (GltfPbrMaterialImporter.TryCreateParam(data, i, out matDesc)) return matDesc; + if (BuiltInGltfPbrMaterialImporter.TryCreateParam(data, i, out matDesc)) return matDesc; // fallback if (Symbols.VRM_DEVELOP) { Debug.LogWarning($"material: {i} out of range. fallback"); } return new MaterialDescriptor( - GltfMaterialDescriptorGenerator.GetMaterialName(i, null), GltfPbrMaterialImporter.ShaderName, + BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, null), BuiltInGltfPbrMaterialImporter.ShaderName, null, new Dictionary(), new Dictionary(), diff --git a/Assets/VRM10/Runtime/IO/Material/URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs b/Assets/VRM10/Runtime/IO/Material/URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs index ca719650d..74448307c 100644 --- a/Assets/VRM10/Runtime/IO/Material/URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs +++ b/Assets/VRM10/Runtime/IO/Material/URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs @@ -11,14 +11,14 @@ namespace UniVRM10 public MaterialDescriptor Get(GltfData data, int i) { // unlit - if (GltfUnlitMaterialImporter.TryCreateParam(data, i, out MaterialDescriptor matDesc)) return matDesc; + if (BuiltInGltfUnlitMaterialImporter.TryCreateParam(data, i, out MaterialDescriptor matDesc)) return matDesc; // pbr - if (GltfPbrUrpMaterialImporter.TryCreateParam(data, i, out matDesc)) return matDesc; + if (UrpGltfPbrMaterialImporter.TryCreateParam(data, i, out matDesc)) return matDesc; // fallback Debug.LogWarning($"material: {i} out of range. fallback"); return new MaterialDescriptor( - GltfMaterialDescriptorGenerator.GetMaterialName(i, null), - GltfPbrMaterialImporter.ShaderName, + BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, null), + BuiltInGltfPbrMaterialImporter.ShaderName, null, new Dictionary(), new Dictionary(), diff --git a/Assets/VRM10_Samples/VRM10Viewer/VRM10ViewerUI.cs b/Assets/VRM10_Samples/VRM10Viewer/VRM10ViewerUI.cs index 806270b77..6f601fe03 100644 --- a/Assets/VRM10_Samples/VRM10Viewer/VRM10ViewerUI.cs +++ b/Assets/VRM10_Samples/VRM10Viewer/VRM10ViewerUI.cs @@ -309,11 +309,11 @@ namespace UniVRM10.VRM10Viewer { if (useUrp) { - return new GltfUrpMaterialDescriptorGenerator(); + return new UrpGltfMaterialDescriptorGenerator(); } else { - return new GltfMaterialDescriptorGenerator(); + return new BuiltInGltfMaterialDescriptorGenerator(); } } diff --git a/Assets/VRM_Samples/SimpleViewer/ViewerUI.cs b/Assets/VRM_Samples/SimpleViewer/ViewerUI.cs index 2b6bea54c..090ea2aa1 100644 --- a/Assets/VRM_Samples/SimpleViewer/ViewerUI.cs +++ b/Assets/VRM_Samples/SimpleViewer/ViewerUI.cs @@ -332,11 +332,11 @@ namespace VRM.SimpleViewer { if (useUrp) { - return new GltfUrpMaterialDescriptorGenerator(); + return new UrpGltfMaterialDescriptorGenerator(); } else { - return new GltfMaterialDescriptorGenerator(); + return new BuiltInGltfMaterialDescriptorGenerator(); } } From bd63c7e14f2b9c883ee453397c90157d68532498 Mon Sep 17 00:00:00 2001 From: Masataka SUMI Date: Thu, 10 Nov 2022 21:30:13 +0900 Subject: [PATCH 2/4] mv function of importing material name --- .../BuiltInGltfMaterialDescriptorGenerator.cs | 12 +----------- .../Materials/BuiltInGltfPbrMaterialImporter.cs | 2 +- .../Materials/BuiltInGltfUnlitMaterialImporter.cs | 2 +- .../IO/MaterialIO/GltfMaterialImportUtils.cs | 9 +++++++++ .../Import/Materials/UrpGltfPbrMaterialImporter.cs | 2 +- .../Import/UrpGltfMaterialDescriptorGenerator.cs | 13 +------------ .../Import/VRMMaterialDescriptorGenerator.cs | 2 +- .../URP/Import/VRMURPMaterialDescriptorGenerator.cs | 2 +- .../Import/Vrm10MaterialDescriptorGenerator.cs | 2 +- .../Import/Vrm10UrpMaterialDescriptorGenerator.cs | 2 +- 10 files changed, 18 insertions(+), 30 deletions(-) diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/BuiltInGltfMaterialDescriptorGenerator.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/BuiltInGltfMaterialDescriptorGenerator.cs index 83a46454c..ed75ce33b 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/BuiltInGltfMaterialDescriptorGenerator.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/BuiltInGltfMaterialDescriptorGenerator.cs @@ -22,7 +22,7 @@ namespace UniGLTF } return new MaterialDescriptor( - GetMaterialName(i, null), + GltfMaterialImportUtils.ImportMaterialName(i, null), BuiltInGltfPbrMaterialImporter.ShaderName, null, new Dictionary(), @@ -30,16 +30,6 @@ namespace UniGLTF new Dictionary(), new Dictionary(), new Action[]{}); - - } - - public static string GetMaterialName(int index, glTFMaterial src) - { - if (src != null && !string.IsNullOrEmpty(src.name)) - { - return src.name; - } - return $"material_{index:00}"; } } } diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfPbrMaterialImporter.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfPbrMaterialImporter.cs index 96251ebdb..2c04b419f 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfPbrMaterialImporter.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfPbrMaterialImporter.cs @@ -206,7 +206,7 @@ namespace UniGLTF }); matDesc = new MaterialDescriptor( - BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, src), + GltfMaterialImportUtils.ImportMaterialName(i, src), ShaderName, null, textureSlots, diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfUnlitMaterialImporter.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfUnlitMaterialImporter.cs index 5c477c5cc..84c1df03d 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfUnlitMaterialImporter.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInGltfUnlitMaterialImporter.cs @@ -50,7 +50,7 @@ namespace UniGLTF } matDesc = new MaterialDescriptor( - BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, src), + GltfMaterialImportUtils.ImportMaterialName(i, src), UniUnlitUtil.ShaderName, null, textureSlots, diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/GltfMaterialImportUtils.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/GltfMaterialImportUtils.cs index a90ea9a1b..e12e42a24 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/GltfMaterialImportUtils.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/GltfMaterialImportUtils.cs @@ -5,6 +5,15 @@ namespace UniGLTF { public static class GltfMaterialImportUtils { + public static string ImportMaterialName(int index, glTFMaterial src) + { + if (src != null && !string.IsNullOrEmpty(src.name)) + { + return src.name; + } + return $"material_{index:00}"; + } + public static Color? ImportLinearEmissiveFactorFromMaterial(GltfData data, glTFMaterial src) { if (src.emissiveFactor == null || src.emissiveFactor.Length != 3) return null; diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/UrpGltfPbrMaterialImporter.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/UrpGltfPbrMaterialImporter.cs index f045857da..eab137d2e 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/UrpGltfPbrMaterialImporter.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/Materials/UrpGltfPbrMaterialImporter.cs @@ -181,7 +181,7 @@ namespace UniGLTF }); matDesc = new MaterialDescriptor( - BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, src), + GltfMaterialImportUtils.ImportMaterialName(i, src), ShaderName, null, textureSlots, diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/UrpGltfMaterialDescriptorGenerator.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/UrpGltfMaterialDescriptorGenerator.cs index 66b93fbcc..d67dd3a81 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/UrpGltfMaterialDescriptorGenerator.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/MaterialIO/URP/Import/UrpGltfMaterialDescriptorGenerator.cs @@ -23,7 +23,7 @@ namespace UniGLTF } return new MaterialDescriptor( - GetMaterialName(i, null), + GltfMaterialImportUtils.ImportMaterialName(i, null), BuiltInGltfPbrMaterialImporter.ShaderName, null, new Dictionary(), @@ -31,17 +31,6 @@ namespace UniGLTF new Dictionary(), new Dictionary(), new Collection>()); - - } - - public static string GetMaterialName(int index, glTFMaterial src) - { - if (src != null && !string.IsNullOrEmpty(src.name)) - { - return src.name; - } - - return $"material_{index:00}"; } } } \ No newline at end of file diff --git a/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs b/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs index f4143632d..e679e7f8a 100644 --- a/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs +++ b/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs @@ -43,7 +43,7 @@ namespace VRM // fallback Debug.LogWarning($"fallback"); return new MaterialDescriptor( - BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, null), + GltfMaterialImportUtils.ImportMaterialName(i, null), BuiltInGltfPbrMaterialImporter.ShaderName, null, new Dictionary(), diff --git a/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/VRMURPMaterialDescriptorGenerator.cs b/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/VRMURPMaterialDescriptorGenerator.cs index 1f7d4a722..bbbc0fdb8 100644 --- a/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/VRMURPMaterialDescriptorGenerator.cs +++ b/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/VRMURPMaterialDescriptorGenerator.cs @@ -27,7 +27,7 @@ namespace VRM Debug.LogWarning($"material: {i} out of range. fallback"); } return new MaterialDescriptor( - BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, null), + GltfMaterialImportUtils.ImportMaterialName(i, null), BuiltInGltfPbrMaterialImporter.ShaderName, null, new Dictionary(), diff --git a/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs b/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs index 821be9b15..1b09beafd 100644 --- a/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs +++ b/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs @@ -22,7 +22,7 @@ namespace UniVRM10 Debug.LogWarning($"material: {i} out of range. fallback"); } return new MaterialDescriptor( - BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, null), BuiltInGltfPbrMaterialImporter.ShaderName, + GltfMaterialImportUtils.ImportMaterialName(i, null), BuiltInGltfPbrMaterialImporter.ShaderName, null, new Dictionary(), new Dictionary(), diff --git a/Assets/VRM10/Runtime/IO/Material/URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs b/Assets/VRM10/Runtime/IO/Material/URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs index 74448307c..5fc42b521 100644 --- a/Assets/VRM10/Runtime/IO/Material/URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs +++ b/Assets/VRM10/Runtime/IO/Material/URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs @@ -17,7 +17,7 @@ namespace UniVRM10 // fallback Debug.LogWarning($"material: {i} out of range. fallback"); return new MaterialDescriptor( - BuiltInGltfMaterialDescriptorGenerator.GetMaterialName(i, null), + GltfMaterialImportUtils.ImportMaterialName(i, null), BuiltInGltfPbrMaterialImporter.ShaderName, null, new Dictionary(), From 77e87eba387270c49d87ef66b9f5368b17809dd5 Mon Sep 17 00:00:00 2001 From: Masataka SUMI Date: Thu, 10 Nov 2022 21:38:36 +0900 Subject: [PATCH 3/4] rename vrm material importer class names --- .../VRM/Editor/Format/VRMEditorImporterContext.cs | 2 +- ....cs => BuiltInVrmMaterialDescriptorGenerator.cs} | 13 +++++++------ ...> BuiltInVrmMaterialDescriptorGenerator.cs.meta} | 0 ...porter.cs => BuiltInVrmMToonMaterialImporter.cs} | 5 +++-- ...meta => BuiltInVrmMToonMaterialImporter.cs.meta} | 0 ...tInVrmUnlitTransparentZWriteMaterialImporter.cs} | 2 +- ...mUnlitTransparentZWriteMaterialImporter.cs.meta} | 0 ...ator.cs => UrpVrmMaterialDescriptorGenerator.cs} | 9 +++++---- ...ta => UrpVrmMaterialDescriptorGenerator.cs.meta} | 0 Assets/VRM/Runtime/IO/VRMImporterContext.cs | 2 +- Assets/VRM/Tests/MToonTest.cs | 6 +++--- Assets/VRM/Tests/VRMTextureEnumerateTests.cs | 2 +- Assets/VRM_Samples/SimpleViewer/ViewerUI.cs | 4 ++-- 13 files changed, 24 insertions(+), 21 deletions(-) rename Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/{VRMMaterialDescriptorGenerator.cs => BuiltInVrmMaterialDescriptorGenerator.cs} (73%) rename Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/{VRMMaterialDescriptorGenerator.cs.meta => BuiltInVrmMaterialDescriptorGenerator.cs.meta} (100%) rename Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/{VRMMToonMaterialImporter.cs => BuiltInVrmMToonMaterialImporter.cs} (96%) rename Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/{VRMMToonMaterialImporter.cs.meta => BuiltInVrmMToonMaterialImporter.cs.meta} (100%) rename Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/{VRMUnlitTransparentZWriteMaterialImporter.cs => BuiltInVrmUnlitTransparentZWriteMaterialImporter.cs} (99%) rename Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/{VRMUnlitTransparentZWriteMaterialImporter.cs.meta => BuiltInVrmUnlitTransparentZWriteMaterialImporter.cs.meta} (100%) rename Assets/VRM/Runtime/IO/MaterialIO/URP/Import/{VRMURPMaterialDescriptorGenerator.cs => UrpVrmMaterialDescriptorGenerator.cs} (86%) rename Assets/VRM/Runtime/IO/MaterialIO/URP/Import/{VRMURPMaterialDescriptorGenerator.cs.meta => UrpVrmMaterialDescriptorGenerator.cs.meta} (100%) diff --git a/Assets/VRM/Editor/Format/VRMEditorImporterContext.cs b/Assets/VRM/Editor/Format/VRMEditorImporterContext.cs index d385bd3fe..f2bf44317 100644 --- a/Assets/VRM/Editor/Format/VRMEditorImporterContext.cs +++ b/Assets/VRM/Editor/Format/VRMEditorImporterContext.cs @@ -109,7 +109,7 @@ namespace VRM // extract converted textures // var subAssets = m_context.TextureFactory.ConvertedTextures; - var vrmTextures = new VRMMaterialDescriptorGenerator(m_context.VRM); + var vrmTextures = new BuiltInVrmMaterialDescriptorGenerator(m_context.VRM); var dirName = $"{m_prefabPath.FileNameWithoutExtension}.Textures"; TextureExtractor.ExtractTextures(m_context.Data, m_prefabPath.Parent.Child(dirName), m_context.TextureDescriptorGenerator, subAssets, (_x, _y) => { }, onTextureReloaded); } diff --git a/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs b/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/BuiltInVrmMaterialDescriptorGenerator.cs similarity index 73% rename from Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs rename to Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/BuiltInVrmMaterialDescriptorGenerator.cs index e679e7f8a..ed2a1db94 100644 --- a/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs +++ b/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/BuiltInVrmMaterialDescriptorGenerator.cs @@ -6,24 +6,25 @@ using VRMShaders; namespace VRM { - public sealed class VRMMaterialDescriptorGenerator : IMaterialDescriptorGenerator + public sealed class BuiltInVrmMaterialDescriptorGenerator : IMaterialDescriptorGenerator { - readonly glTF_VRM_extensions m_vrm; - public VRMMaterialDescriptorGenerator(glTF_VRM_extensions vrm) + private readonly glTF_VRM_extensions _vrm; + + public BuiltInVrmMaterialDescriptorGenerator(glTF_VRM_extensions vrm) { - m_vrm = vrm; + _vrm = vrm; } public MaterialDescriptor Get(GltfData data, int i) { // legacy "VRM/UnlitTransparentZWrite" - if (VRMUnlitTransparentZWriteMaterialImporter.TryCreateParam(data, m_vrm, i, out var matDesc)) + if (BuiltInVrmUnlitTransparentZWriteMaterialImporter.TryCreateParam(data, _vrm, i, out var matDesc)) { return matDesc; } // mtoon - if (VRMMToonMaterialImporter.TryCreateParam(data, m_vrm, i, out matDesc)) + if (BuiltInVrmMToonMaterialImporter.TryCreateParam(data, _vrm, i, out matDesc)) { return matDesc; } diff --git a/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs.meta b/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/BuiltInVrmMaterialDescriptorGenerator.cs.meta similarity index 100% rename from Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/VRMMaterialDescriptorGenerator.cs.meta rename to Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/BuiltInVrmMaterialDescriptorGenerator.cs.meta diff --git a/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/VRMMToonMaterialImporter.cs b/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInVrmMToonMaterialImporter.cs similarity index 96% rename from Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/VRMMToonMaterialImporter.cs rename to Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInVrmMToonMaterialImporter.cs index 13772d106..026de35e2 100644 --- a/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/VRMMToonMaterialImporter.cs +++ b/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInVrmMToonMaterialImporter.cs @@ -7,9 +7,10 @@ using VRMShaders; namespace VRM { - public static class VRMMToonMaterialImporter + public static class BuiltInVrmMToonMaterialImporter { - static string[] MToonTextureSlots = new string[]{ + private static readonly string[] MToonTextureSlots = new string[] + { "_MainTex", "_ShadeTexture", "_BumpMap", diff --git a/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/VRMMToonMaterialImporter.cs.meta b/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInVrmMToonMaterialImporter.cs.meta similarity index 100% rename from Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/VRMMToonMaterialImporter.cs.meta rename to Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInVrmMToonMaterialImporter.cs.meta diff --git a/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/VRMUnlitTransparentZWriteMaterialImporter.cs b/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInVrmUnlitTransparentZWriteMaterialImporter.cs similarity index 99% rename from Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/VRMUnlitTransparentZWriteMaterialImporter.cs rename to Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInVrmUnlitTransparentZWriteMaterialImporter.cs index dd0792efe..4ab36a434 100644 --- a/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/VRMUnlitTransparentZWriteMaterialImporter.cs +++ b/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInVrmUnlitTransparentZWriteMaterialImporter.cs @@ -9,7 +9,7 @@ using RenderMode = MToon.RenderMode; namespace VRM { - public static class VRMUnlitTransparentZWriteMaterialImporter + public static class BuiltInVrmUnlitTransparentZWriteMaterialImporter { public const string UnlitTransparentZWriteShaderName = "VRM/UnlitTransparentZWrite"; public const string UnlitTransparentZWriteMainTexturePropName = "_MainTex"; diff --git a/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/VRMUnlitTransparentZWriteMaterialImporter.cs.meta b/Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInVrmUnlitTransparentZWriteMaterialImporter.cs.meta similarity index 100% rename from Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/VRMUnlitTransparentZWriteMaterialImporter.cs.meta rename to Assets/VRM/Runtime/IO/MaterialIO/BuiltInRP/Import/Materials/BuiltInVrmUnlitTransparentZWriteMaterialImporter.cs.meta diff --git a/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/VRMURPMaterialDescriptorGenerator.cs b/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/UrpVrmMaterialDescriptorGenerator.cs similarity index 86% rename from Assets/VRM/Runtime/IO/MaterialIO/URP/Import/VRMURPMaterialDescriptorGenerator.cs rename to Assets/VRM/Runtime/IO/MaterialIO/URP/Import/UrpVrmMaterialDescriptorGenerator.cs index bbbc0fdb8..6c8f2d482 100644 --- a/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/VRMURPMaterialDescriptorGenerator.cs +++ b/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/UrpVrmMaterialDescriptorGenerator.cs @@ -6,12 +6,13 @@ using VRMShaders; namespace VRM { - public sealed class VRMUrpMaterialDescriptorGenerator : IMaterialDescriptorGenerator + public sealed class UrpVrmMaterialDescriptorGenerator : IMaterialDescriptorGenerator { - readonly glTF_VRM_extensions m_vrm; - public VRMUrpMaterialDescriptorGenerator(glTF_VRM_extensions vrm) + private readonly glTF_VRM_extensions _vrm; + + public UrpVrmMaterialDescriptorGenerator(glTF_VRM_extensions vrm) { - m_vrm = vrm; + _vrm = vrm; } public MaterialDescriptor Get(GltfData data, int i) diff --git a/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/VRMURPMaterialDescriptorGenerator.cs.meta b/Assets/VRM/Runtime/IO/MaterialIO/URP/Import/UrpVrmMaterialDescriptorGenerator.cs.meta similarity index 100% rename from Assets/VRM/Runtime/IO/MaterialIO/URP/Import/VRMURPMaterialDescriptorGenerator.cs.meta rename to Assets/VRM/Runtime/IO/MaterialIO/URP/Import/UrpVrmMaterialDescriptorGenerator.cs.meta diff --git a/Assets/VRM/Runtime/IO/VRMImporterContext.cs b/Assets/VRM/Runtime/IO/VRMImporterContext.cs index ffe6a9772..d2f7c5637 100644 --- a/Assets/VRM/Runtime/IO/VRMImporterContext.cs +++ b/Assets/VRM/Runtime/IO/VRMImporterContext.cs @@ -27,7 +27,7 @@ namespace VRM ITextureDeserializer textureDeserializer = null, IMaterialDescriptorGenerator materialGenerator = null, bool loadAnimation = false) - : base(data.Data, externalObjectMap, textureDeserializer, materialGenerator ?? new VRMMaterialDescriptorGenerator(data.VrmExtension)) + : base(data.Data, externalObjectMap, textureDeserializer, materialGenerator ?? new BuiltInVrmMaterialDescriptorGenerator(data.VrmExtension)) { _data = data; TextureDescriptorGenerator = new VrmTextureDescriptorGenerator(Data, VRM); diff --git a/Assets/VRM/Tests/MToonTest.cs b/Assets/VRM/Tests/MToonTest.cs index 0810b5356..ec5c7adbd 100644 --- a/Assets/VRM/Tests/MToonTest.cs +++ b/Assets/VRM/Tests/MToonTest.cs @@ -31,7 +31,7 @@ namespace VRM var vrmMaterial = BuiltInVrmExtensionMaterialPropertyExporter.ExportMaterial(srcMaterial, textureExporter); Assert.AreEqual(vrmMaterial.vectorProperties["_MainTex"], new float[] { 0.3f, 0.2f, 0.5f, 0.6f }); - var materialImporter = new VRMMaterialDescriptorGenerator(new glTF_VRM_extensions + var materialImporter = new BuiltInVrmMaterialDescriptorGenerator(new glTF_VRM_extensions { materialProperties = new System.Collections.Generic.List { vrmMaterial } }); @@ -51,7 +51,7 @@ namespace VRM var importer = new VRMImporterContext(vrm, null); Assert.AreEqual(73, vrm.Data.GLTF.materials.Count); - Assert.True(VRMMToonMaterialImporter.TryCreateParam(vrm.Data, importer.VRM, 0, out MaterialDescriptor matDesc)); + Assert.True(BuiltInVrmMToonMaterialImporter.TryCreateParam(vrm.Data, importer.VRM, 0, out MaterialDescriptor matDesc)); } } @@ -71,7 +71,7 @@ namespace VRM using (var data = new GlbFileParser(path).Parse()) { var vrmImporter = new VRMImporterContext(new VRMData(data), null); - var materialParam = new VRMMaterialDescriptorGenerator(vrmImporter.VRM).Get(data, 0); + var materialParam = new BuiltInVrmMaterialDescriptorGenerator(vrmImporter.VRM).Get(data, 0); Assert.AreEqual("VRM/MToon", materialParam.ShaderName); Assert.AreEqual("Alicia_body", materialParam.TextureSlots["_MainTex"].UnityObjectName); diff --git a/Assets/VRM/Tests/VRMTextureEnumerateTests.cs b/Assets/VRM/Tests/VRMTextureEnumerateTests.cs index 9ae342c83..5c4160dd6 100644 --- a/Assets/VRM/Tests/VRMTextureEnumerateTests.cs +++ b/Assets/VRM/Tests/VRMTextureEnumerateTests.cs @@ -141,7 +141,7 @@ namespace VRM }; // 2系統ある？ - Assert.IsTrue(VRMMToonMaterialImporter.TryCreateParam(data, vrm, 0, out VRMShaders.MaterialDescriptor matDesc)); + Assert.IsTrue(BuiltInVrmMToonMaterialImporter.TryCreateParam(data, vrm, 0, out VRMShaders.MaterialDescriptor matDesc)); Assert.AreEqual(1, matDesc.TextureSlots.Count); var items = new VrmTextureDescriptorGenerator(data, vrm).Get().GetEnumerable().ToArray(); diff --git a/Assets/VRM_Samples/SimpleViewer/ViewerUI.cs b/Assets/VRM_Samples/SimpleViewer/ViewerUI.cs index 090ea2aa1..893d31ead 100644 --- a/Assets/VRM_Samples/SimpleViewer/ViewerUI.cs +++ b/Assets/VRM_Samples/SimpleViewer/ViewerUI.cs @@ -344,11 +344,11 @@ namespace VRM.SimpleViewer { if (useUrp) { - return new VRM.VRMUrpMaterialDescriptorGenerator(vrm); + return new VRM.UrpVrmMaterialDescriptorGenerator(vrm); } else { - return new VRM.VRMMaterialDescriptorGenerator(vrm); + return new VRM.BuiltInVrmMaterialDescriptorGenerator(vrm); } } From 62085d255a3f45447a28c81b013c88e82e66fa32 Mon Sep 17 00:00:00 2001 From: Masataka SUMI Date: Thu, 10 Nov 2022 21:41:01 +0900 Subject: [PATCH 4/4] rename vrm10 material importer class names --- .../Editor/ScriptedImporter/VrmScriptedImporterEditorGUI.cs | 2 +- .../VRM10/Editor/ScriptedImporter/VrmScriptedImporterImpl.cs | 4 ++-- ...enerator.cs => BuiltInVrm10MaterialDescriptorGenerator.cs} | 4 ++-- ...s.meta => BuiltInVrm10MaterialDescriptorGenerator.cs.meta} | 0 ...terialImporter.cs => BuiltInVrm10MToonMaterialImporter.cs} | 2 +- ...rter.cs.meta => BuiltInVrm10MToonMaterialImporter.cs.meta} | 0 ...torGenerator.cs => UrpVrm10MaterialDescriptorGenerator.cs} | 2 +- ...or.cs.meta => UrpVrm10MaterialDescriptorGenerator.cs.meta} | 0 .../{BuiltInRP/Export => }/Vrm10MaterialExportUtils.cs | 0 .../{BuiltInRP/Export => }/Vrm10MaterialExportUtils.cs.meta | 0 Assets/VRM10/Runtime/IO/Vrm10Importer.cs | 2 +- Assets/VRM10/Tests/MaterialImportTests.cs | 2 +- Assets/VRM10_Samples/VRM10Viewer/VRM10ViewerUI.cs | 4 ++-- 13 files changed, 11 insertions(+), 11 deletions(-) rename Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/{Vrm10MaterialDescriptorGenerator.cs => BuiltInVrm10MaterialDescriptorGenerator.cs} (83%) rename Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/{Vrm10MaterialDescriptorGenerator.cs.meta => BuiltInVrm10MaterialDescriptorGenerator.cs.meta} (100%) rename Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Materials/{Vrm10MToonMaterialImporter.cs => BuiltInVrm10MToonMaterialImporter.cs} (99%) rename Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Materials/{Vrm10MToonMaterialImporter.cs.meta => BuiltInVrm10MToonMaterialImporter.cs.meta} (100%) rename Assets/VRM10/Runtime/IO/Material/URP/Import/{Vrm10UrpMaterialDescriptorGenerator.cs => UrpVrm10MaterialDescriptorGenerator.cs} (94%) rename Assets/VRM10/Runtime/IO/Material/URP/Import/{Vrm10UrpMaterialDescriptorGenerator.cs.meta => UrpVrm10MaterialDescriptorGenerator.cs.meta} (100%) rename Assets/VRM10/Runtime/IO/Material/{BuiltInRP/Export => }/Vrm10MaterialExportUtils.cs (100%) rename Assets/VRM10/Runtime/IO/Material/{BuiltInRP/Export => }/Vrm10MaterialExportUtils.cs.meta (100%) diff --git a/Assets/VRM10/Editor/ScriptedImporter/VrmScriptedImporterEditorGUI.cs b/Assets/VRM10/Editor/ScriptedImporter/VrmScriptedImporterEditorGUI.cs index 00b79edc0..cf7d530c5 100644 --- a/Assets/VRM10/Editor/ScriptedImporter/VrmScriptedImporterEditorGUI.cs +++ b/Assets/VRM10/Editor/ScriptedImporter/VrmScriptedImporterEditorGUI.cs @@ -72,7 +72,7 @@ namespace UniVRM10 var tmp = m_importer.GetExternalObjectMap(); - var generator = new Vrm10MaterialDescriptorGenerator(); + var generator = new BuiltInVrm10MaterialDescriptorGenerator(); var materialKeys = m_result.Data.GLTF.materials.Select((x, i) => generator.Get(m_result.Data, i).SubAssetKey); var textureKeys = new Vrm10TextureDescriptorGenerator(m_result.Data).Get().GetEnumerable().Select(x => x.SubAssetKey); m_materialEditor = new RemapEditorMaterial(materialKeys.Concat(textureKeys), GetEditorMap, SetEditorMap); diff --git a/Assets/VRM10/Editor/ScriptedImporter/VrmScriptedImporterImpl.cs b/Assets/VRM10/Editor/ScriptedImporter/VrmScriptedImporterImpl.cs index 0e8e11d6b..a6a2705f9 100644 --- a/Assets/VRM10/Editor/ScriptedImporter/VrmScriptedImporterImpl.cs +++ b/Assets/VRM10/Editor/ScriptedImporter/VrmScriptedImporterImpl.cs @@ -19,10 +19,10 @@ namespace UniVRM10 switch (renderPipeline) { case RenderPipelineTypes.BuiltinRenderPipeline: - return new Vrm10MaterialDescriptorGenerator(); + return new BuiltInVrm10MaterialDescriptorGenerator(); case RenderPipelineTypes.UniversalRenderPipeline: - return new Vrm10UrpMaterialDescriptorGenerator(); + return new UrpVrm10MaterialDescriptorGenerator(); default: throw new NotImplementedException(); diff --git a/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs b/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/BuiltInVrm10MaterialDescriptorGenerator.cs similarity index 83% rename from Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs rename to Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/BuiltInVrm10MaterialDescriptorGenerator.cs index 1b09beafd..79360e37a 100644 --- a/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs +++ b/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/BuiltInVrm10MaterialDescriptorGenerator.cs @@ -6,12 +6,12 @@ using VRMShaders; namespace UniVRM10 { - public sealed class Vrm10MaterialDescriptorGenerator : IMaterialDescriptorGenerator + public sealed class BuiltInVrm10MaterialDescriptorGenerator : IMaterialDescriptorGenerator { public MaterialDescriptor Get(GltfData data, int i) { // mtoon - if (Vrm10MToonMaterialImporter.TryCreateParam(data, i, out MaterialDescriptor matDesc)) return matDesc; + if (BuiltInVrm10MToonMaterialImporter.TryCreateParam(data, i, out MaterialDescriptor matDesc)) return matDesc; // unlit if (BuiltInGltfUnlitMaterialImporter.TryCreateParam(data, i, out matDesc)) return matDesc; // pbr diff --git a/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs.meta b/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/BuiltInVrm10MaterialDescriptorGenerator.cs.meta similarity index 100% rename from Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Vrm10MaterialDescriptorGenerator.cs.meta rename to Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/BuiltInVrm10MaterialDescriptorGenerator.cs.meta diff --git a/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Materials/Vrm10MToonMaterialImporter.cs b/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Materials/BuiltInVrm10MToonMaterialImporter.cs similarity index 99% rename from Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Materials/Vrm10MToonMaterialImporter.cs rename to Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Materials/BuiltInVrm10MToonMaterialImporter.cs index 83d4fa9f6..982461d7b 100644 --- a/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Materials/Vrm10MToonMaterialImporter.cs +++ b/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Materials/BuiltInVrm10MToonMaterialImporter.cs @@ -14,7 +14,7 @@ namespace UniVRM10 /// /// Convert MToon parameters from glTF specification to Unity implementation. /// - public static class Vrm10MToonMaterialImporter + public static class BuiltInVrm10MToonMaterialImporter { /// /// VMRC_materials_mtoon の場合にマテリアル生成情報を作成する diff --git a/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Materials/Vrm10MToonMaterialImporter.cs.meta b/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Materials/BuiltInVrm10MToonMaterialImporter.cs.meta similarity index 100% rename from Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Materials/Vrm10MToonMaterialImporter.cs.meta rename to Assets/VRM10/Runtime/IO/Material/BuiltInRP/Import/Materials/BuiltInVrm10MToonMaterialImporter.cs.meta diff --git a/Assets/VRM10/Runtime/IO/Material/URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs b/Assets/VRM10/Runtime/IO/Material/URP/Import/UrpVrm10MaterialDescriptorGenerator.cs similarity index 94% rename from Assets/VRM10/Runtime/IO/Material/URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs rename to Assets/VRM10/Runtime/IO/Material/URP/Import/UrpVrm10MaterialDescriptorGenerator.cs index 5fc42b521..2201e19ad 100644 --- a/Assets/VRM10/Runtime/IO/Material/URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs +++ b/Assets/VRM10/Runtime/IO/Material/URP/Import/UrpVrm10MaterialDescriptorGenerator.cs @@ -6,7 +6,7 @@ using VRMShaders; namespace UniVRM10 { - public sealed class Vrm10UrpMaterialDescriptorGenerator : IMaterialDescriptorGenerator + public sealed class UrpVrm10MaterialDescriptorGenerator : IMaterialDescriptorGenerator { public MaterialDescriptor Get(GltfData data, int i) { diff --git a/Assets/VRM10/Runtime/IO/Material/URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs.meta b/Assets/VRM10/Runtime/IO/Material/URP/Import/UrpVrm10MaterialDescriptorGenerator.cs.meta similarity index 100% rename from Assets/VRM10/Runtime/IO/Material/URP/Import/Vrm10UrpMaterialDescriptorGenerator.cs.meta rename to Assets/VRM10/Runtime/IO/Material/URP/Import/UrpVrm10MaterialDescriptorGenerator.cs.meta diff --git a/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Export/Vrm10MaterialExportUtils.cs b/Assets/VRM10/Runtime/IO/Material/Vrm10MaterialExportUtils.cs similarity index 100% rename from Assets/VRM10/Runtime/IO/Material/BuiltInRP/Export/Vrm10MaterialExportUtils.cs rename to Assets/VRM10/Runtime/IO/Material/Vrm10MaterialExportUtils.cs diff --git a/Assets/VRM10/Runtime/IO/Material/BuiltInRP/Export/Vrm10MaterialExportUtils.cs.meta b/Assets/VRM10/Runtime/IO/Material/Vrm10MaterialExportUtils.cs.meta similarity index 100% rename from Assets/VRM10/Runtime/IO/Material/BuiltInRP/Export/Vrm10MaterialExportUtils.cs.meta rename to Assets/VRM10/Runtime/IO/Material/Vrm10MaterialExportUtils.cs.meta diff --git a/Assets/VRM10/Runtime/IO/Vrm10Importer.cs b/Assets/VRM10/Runtime/IO/Vrm10Importer.cs index 1a430086c..fc5da977d 100644 --- a/Assets/VRM10/Runtime/IO/Vrm10Importer.cs +++ b/Assets/VRM10/Runtime/IO/Vrm10Importer.cs @@ -42,7 +42,7 @@ namespace UniVRM10 m_controlRigGenerationOption = controlRigGenerationOption; TextureDescriptorGenerator = new Vrm10TextureDescriptorGenerator(Data); - MaterialDescriptorGenerator = materialGenerator ?? new Vrm10MaterialDescriptorGenerator(); + MaterialDescriptorGenerator = materialGenerator ?? new BuiltInVrm10MaterialDescriptorGenerator(); m_externalMap = externalObjectMap; if (m_externalMap == null) diff --git a/Assets/VRM10/Tests/MaterialImportTests.cs b/Assets/VRM10/Tests/MaterialImportTests.cs index c4961c776..1af246409 100644 --- a/Assets/VRM10/Tests/MaterialImportTests.cs +++ b/Assets/VRM10/Tests/MaterialImportTests.cs @@ -25,7 +25,7 @@ namespace UniVRM10 using (var data = new GlbLowLevelParser(AliciaPath, migratedBytes).Parse()) { - var matDesc = new Vrm10MaterialDescriptorGenerator().Get(data, 0); + var matDesc = new BuiltInVrm10MaterialDescriptorGenerator().Get(data, 0); Assert.AreEqual("Alicia_body", matDesc.Name); Assert.AreEqual("VRM10/MToon10", matDesc.ShaderName); Assert.AreEqual("Alicia_body", matDesc.TextureSlots["_MainTex"].UnityObjectName); diff --git a/Assets/VRM10_Samples/VRM10Viewer/VRM10ViewerUI.cs b/Assets/VRM10_Samples/VRM10Viewer/VRM10ViewerUI.cs index 6f601fe03..4d8a5d34a 100644 --- a/Assets/VRM10_Samples/VRM10Viewer/VRM10ViewerUI.cs +++ b/Assets/VRM10_Samples/VRM10Viewer/VRM10ViewerUI.cs @@ -297,11 +297,11 @@ namespace UniVRM10.VRM10Viewer { if (useUrp) { - return new Vrm10UrpMaterialDescriptorGenerator(); + return new UrpVrm10MaterialDescriptorGenerator(); } else { - return new Vrm10MaterialDescriptorGenerator(); + return new BuiltInVrm10MaterialDescriptorGenerator(); } }