From 9c194d55e72a3a71a4fedb4cbb6a9c91130a259d Mon Sep 17 00:00:00 2001 From: 0b5vr <0b5vr@0b5vr.com> Date: Fri, 9 Dec 2022 16:03:45 +0900 Subject: [PATCH] refactor: SpringBoneEditor, change FindProperty specifier from string literal to nameof Addressing https://github.com/vrm-c/UniVRM/pull/1952#discussion_r1044133280 Addressing https://github.com/vrm-c/UniVRM/pull/1952#discussion_r1044133784 --- .../Editor/SpringBone/VRMSpringBoneEditor.cs | 20 +++++++++---------- .../SpringBone/VRM10SpringBoneJointEditor.cs | 10 +++++----- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/Assets/VRM/Editor/SpringBone/VRMSpringBoneEditor.cs b/Assets/VRM/Editor/SpringBone/VRMSpringBoneEditor.cs index 0eaa35e8f..68e2027fc 100644 --- a/Assets/VRM/Editor/SpringBone/VRMSpringBoneEditor.cs +++ b/Assets/VRM/Editor/SpringBone/VRMSpringBoneEditor.cs @@ -29,17 +29,17 @@ namespace VRM } m_target = (VRMSpringBone)target; - m_commentProp = serializedObject.FindProperty("m_comment"); + m_commentProp = serializedObject.FindProperty(nameof(VRMSpringBone.m_comment)); m_gizmoColorProp = serializedObject.FindProperty("m_gizmoColor"); - m_stiffnessForceProp = serializedObject.FindProperty("m_stiffnessForce"); - m_gravityPowerProp = serializedObject.FindProperty("m_gravityPower"); - m_gravityDirProp = serializedObject.FindProperty("m_gravityDir"); - m_dragForceProp = serializedObject.FindProperty("m_dragForce"); - m_centerProp = serializedObject.FindProperty("m_center"); - m_rootBonesProp = serializedObject.FindProperty("RootBones"); - m_hitRadiusProp = serializedObject.FindProperty("m_hitRadius"); - m_colliderGroupsProp = serializedObject.FindProperty("ColliderGroups"); - m_updateTypeProp = serializedObject.FindProperty("m_updateType"); + m_stiffnessForceProp = serializedObject.FindProperty(nameof(VRMSpringBone.m_stiffnessForce)); + m_gravityPowerProp = serializedObject.FindProperty(nameof(VRMSpringBone.m_gravityPower)); + m_gravityDirProp = serializedObject.FindProperty(nameof(VRMSpringBone.m_gravityDir)); + m_dragForceProp = serializedObject.FindProperty(nameof(VRMSpringBone.m_dragForce)); + m_centerProp = serializedObject.FindProperty(nameof(VRMSpringBone.m_center)); + m_rootBonesProp = serializedObject.FindProperty(nameof(VRMSpringBone.RootBones)); + m_hitRadiusProp = serializedObject.FindProperty(nameof(VRMSpringBone.m_hitRadius)); + m_colliderGroupsProp = serializedObject.FindProperty(nameof(VRMSpringBone.ColliderGroups)); + m_updateTypeProp = serializedObject.FindProperty(nameof(VRMSpringBone.m_updateType)); } public override void OnInspectorGUI() diff --git a/Assets/VRM10/Editor/Components/SpringBone/VRM10SpringBoneJointEditor.cs b/Assets/VRM10/Editor/Components/SpringBone/VRM10SpringBoneJointEditor.cs index d43d38d16..f28dd88e7 100644 --- a/Assets/VRM10/Editor/Components/SpringBone/VRM10SpringBoneJointEditor.cs +++ b/Assets/VRM10/Editor/Components/SpringBone/VRM10SpringBoneJointEditor.cs @@ -21,11 +21,11 @@ namespace UniVRM10 } m_target = (VRM10SpringBoneJoint)target; - m_stiffnessForceProp = serializedObject.FindProperty("m_stiffnessForce"); - m_gravityPowerProp = serializedObject.FindProperty("m_gravityPower"); - m_gravityDirProp = serializedObject.FindProperty("m_gravityDir"); - m_dragForceProp = serializedObject.FindProperty("m_dragForce"); - m_jointRadiusProp = serializedObject.FindProperty("m_jointRadius"); + m_stiffnessForceProp = serializedObject.FindProperty(nameof(VRM10SpringBoneJoint.m_stiffnessForce)); + m_gravityPowerProp = serializedObject.FindProperty(nameof(VRM10SpringBoneJoint.m_gravityPower)); + m_gravityDirProp = serializedObject.FindProperty(nameof(VRM10SpringBoneJoint.m_gravityDir)); + m_dragForceProp = serializedObject.FindProperty(nameof(VRM10SpringBoneJoint.m_dragForce)); + m_jointRadiusProp = serializedObject.FindProperty(nameof(VRM10SpringBoneJoint.m_jointRadius)); } public override void OnInspectorGUI()