From 14d420e6a4b07d1473bd7a7ffad474fbdb3f0f3a Mon Sep 17 00:00:00 2001 From: ousttrue Date: Wed, 27 Oct 2021 20:22:00 +0900 Subject: [PATCH] Append to ExtendBufferAndGetView --- Assets/UniGLTF/Runtime/UniGLTF/IO/ExportingGltfData.cs | 9 ++------- Assets/UniGLTF/Tests/UniGLTF/UniGLTFTests.cs | 2 +- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/Assets/UniGLTF/Runtime/UniGLTF/IO/ExportingGltfData.cs b/Assets/UniGLTF/Runtime/UniGLTF/IO/ExportingGltfData.cs index 8327e1e21..c08ee784b 100644 --- a/Assets/UniGLTF/Runtime/UniGLTF/IO/ExportingGltfData.cs +++ b/Assets/UniGLTF/Runtime/UniGLTF/IO/ExportingGltfData.cs @@ -28,18 +28,13 @@ namespace UniGLTF } #region Buffer management for export - public glTFBufferView Append(ArraySegment segment, glBufferTarget target) where T : struct + public glTFBufferView ExtendBufferAndGetView(ArraySegment segment, glBufferTarget target) where T : struct { var view = _buffer.Extend(segment, target); GLTF.buffers[0].byteLength = _buffer.Bytes.Count; return view; } - public glTFBufferView Append(T[] array, glBufferTarget target) where T : struct - { - return Append(new ArraySegment(array), target); - } - public int ExtendBufferAndGetViewIndex( ArraySegment array, glBufferTarget target = glBufferTarget.NONE) where T : struct @@ -48,7 +43,7 @@ namespace UniGLTF { return -1; } - var view = Append(array, target); + var view = ExtendBufferAndGetView(array, target); var viewIndex = GLTF.bufferViews.Count; GLTF.bufferViews.Add(view); return viewIndex; diff --git a/Assets/UniGLTF/Tests/UniGLTF/UniGLTFTests.cs b/Assets/UniGLTF/Tests/UniGLTF/UniGLTFTests.cs index 4e305cada..fea2221af 100644 --- a/Assets/UniGLTF/Tests/UniGLTF/UniGLTFTests.cs +++ b/Assets/UniGLTF/Tests/UniGLTF/UniGLTFTests.cs @@ -140,7 +140,7 @@ namespace UniGLTF values.AddRange(nums); var bytes = new ArraySegment(nums); offset += x; - data.Append(bytes, glBufferTarget.NONE); + data.ExtendBufferAndGetView(bytes, glBufferTarget.NONE); } Assert.AreEqual(values.Count, data.GLTF.buffers[0].byteLength);