Variable related refactors

lib/variables/variable.cpp

@@ -13,11 +13,6 @@ static std::deque<std::shared_ptr<Item>> variables;
 // when resolving strings containing variables, etc.
 static std::chrono::high_resolution_clock::time_point lastVariableChange{};
 
-std::chrono::high_resolution_clock::time_point GetLastVariableChangeTime()
-{
-	return lastVariableChange;
-}
-
 Variable::Variable() : Item()
 {
 	lastVariableChange = std::chrono::high_resolution_clock::now();
@@ -34,11 +29,13 @@ void Variable::Load(obs_data_t *obj)
 	_saveAction =
 		static_cast<SaveAction>(obs_data_get_int(obj, "saveAction"));
 	_defaultValue = obs_data_get_string(obj, "defaultValue");
+
 	if (_saveAction == SaveAction::SAVE) {
 		SetValue(obs_data_get_string(obj, "value"));
 	} else if (_saveAction == SaveAction::SET_DEFAULT) {
 		SetValue(_defaultValue);
 	}
+
 	lastVariableChange = std::chrono::high_resolution_clock::now();
 }
 
@@ -46,9 +43,11 @@ void Variable::Save(obs_data_t *obj) const
 {
 	Item::Save(obj);
 	obs_data_set_int(obj, "saveAction", static_cast<int>(_saveAction));
+
 	if (_saveAction == SaveAction::SAVE) {
 		obs_data_set_string(obj, "value", _value.c_str());
 	}
+
 	obs_data_set_string(obj, "defaultValue", _defaultValue.c_str());
 }
 
@@ -57,6 +56,7 @@ std::string Variable::Value(bool updateLastUsed) const
 	if (updateLastUsed) {
 		UpdateLastUsed();
 	}
+
 	return _value;
 }
 
@@ -70,11 +70,6 @@ std::optional<int> Variable::IntValue() const
 	return GetInt(Value());
 }
 
-std::string Variable::PreviousValue() const
-{
-	return _previousValue;
-}
-
 void Variable::SetValue(const std::string &value)
 {
 	_previousValue = _value;
@@ -90,11 +85,12 @@ void Variable::SetValue(double value)
 	SetValue(ToString(value));
 }
 
-std::optional<uint64_t> Variable::SecondsSinceLastUse() const
+std::optional<uint64_t> Variable::GetSecondsSinceLastUse() const
 {
 	if (_lastUsed.time_since_epoch().count() == 0) {
 		return {};
 	}
+
 	const auto now = std::chrono::high_resolution_clock::now();
 	return std::chrono::duration_cast<std::chrono::seconds>(now - _lastUsed)
 		.count();
@@ -124,121 +120,12 @@ void Variable::UpdateLastChanged() const
 	}
 }
 
-std::deque<std::shared_ptr<Item>> &GetVariables()
-{
-	return variables;
-}
-
-Variable *GetVariableByName(const std::string &name)
-{
-	for (const auto &v : variables) {
-		if (v->Name() == name) {
-			return dynamic_cast<Variable *>(v.get());
-		}
-	}
-	return nullptr;
-}
-
-Variable *GetVariableByQString(const QString &name)
-{
-	return GetVariableByName(name.toStdString());
-}
-
-std::weak_ptr<Variable> GetWeakVariableByName(const std::string &name)
-{
-	for (const auto &v : variables) {
-		if (v->Name() == name) {
-			std::weak_ptr<Variable> wp =
-				std::dynamic_pointer_cast<Variable>(v);
-			return wp;
-		}
-	}
-	return std::weak_ptr<Variable>();
-}
-
-std::weak_ptr<Variable> GetWeakVariableByQString(const QString &name)
-{
-	return GetWeakVariableByName(name.toStdString());
-}
-
-QStringList GetVariablesNameList()
-{
-	QStringList list;
-	for (const auto &var : variables) {
-		list << QString::fromStdString(var->Name());
-	}
-	list.sort();
-	return list;
-}
-
-std::string GetWeakVariableName(std::weak_ptr<Variable> var_)
-{
-	auto var = var_.lock();
-	if (!var) {
-		return obs_module_text("AdvSceneSwitcher.variable.invalid");
-	}
-	return var->Name();
-}
-
-void SaveVariables(obs_data_t *obj)
-{
-	obs_data_array_t *variablesArray = obs_data_array_create();
-	for (const auto &v : variables) {
-		obs_data_t *array_obj = obs_data_create();
-		v->Save(array_obj);
-		obs_data_array_push_back(variablesArray, array_obj);
-		obs_data_release(array_obj);
-	}
-	obs_data_set_array(obj, "variables", variablesArray);
-	obs_data_array_release(variablesArray);
-}
-
-void LoadVariables(obs_data_t *obj)
-{
-	variables.clear();
-
-	obs_data_array_t *variablesArray = obs_data_get_array(obj, "variables");
-	size_t count = obs_data_array_count(variablesArray);
-
-	for (size_t i = 0; i < count; i++) {
-		obs_data_t *array_obj = obs_data_array_item(variablesArray, i);
-		auto var = Variable::Create();
-		variables.emplace_back(var);
-		variables.back()->Load(array_obj);
-		obs_data_release(array_obj);
-	}
-	obs_data_array_release(variablesArray);
-}
-
-static bool variableWithNameExists(const std::string &name)
-{
-	return !!GetVariableByName(name);
-}
-
-void ImportVariables(obs_data_t *data)
-{
-	obs_data_array_t *array = obs_data_get_array(data, "variables");
-	size_t count = obs_data_array_count(array);
-	for (size_t i = 0; i < count; i++) {
-		obs_data_t *arrayElement = obs_data_array_item(array, i);
-		auto var = Variable::Create();
-		var->Load(arrayElement);
-		obs_data_release(arrayElement);
-		if (variableWithNameExists(var->Name())) {
-			continue;
-		}
-		GetVariables().emplace_back(var);
-	}
-	obs_data_array_release(array);
-}
-
 static void populateSaveActionSelection(QComboBox *list)
 {
-	list->addItem(
-		obs_module_text("AdvSceneSwitcher.variable.save.dontSave"));
-	list->addItem(obs_module_text("AdvSceneSwitcher.variable.save.save"));
-	list->addItem(
-		obs_module_text("AdvSceneSwitcher.variable.save.default"));
+	list->addItems(
+		{obs_module_text("AdvSceneSwitcher.variable.save.dontSave"),
+		 obs_module_text("AdvSceneSwitcher.variable.save.save"),
+		 obs_module_text("AdvSceneSwitcher.variable.save.default")});
 }
 
 VariableSettingsDialog::VariableSettingsDialog(QWidget *parent,
@@ -265,6 +152,7 @@ VariableSettingsDialog::VariableSettingsDialog(QWidget *parent,
 	layout->addWidget(
 		new QLabel(obs_module_text("AdvSceneSwitcher.variable.name")),
 		row, 0);
+
 	QHBoxLayout *nameLayout = new QHBoxLayout;
 	nameLayout->addWidget(_name);
 	nameLayout->addWidget(_nameHint);
@@ -278,13 +166,14 @@ VariableSettingsDialog::VariableSettingsDialog(QWidget *parent,
 	layout->addWidget(
 		new QLabel(obs_module_text("AdvSceneSwitcher.variable.save")),
 		row, 0);
+
 	auto saveLayout = new QVBoxLayout;
 	saveLayout->addWidget(_save);
 	saveLayout->addWidget(_defaultValue);
 	saveLayout->addStretch();
+
 	layout->addLayout(saveLayout, row, 1);
-	++row;
-	layout->addWidget(_buttonbox, row, 0, 1, -1);
+	layout->addWidget(_buttonbox, ++row, 0, 1, -1);
 	layout->setSizeConstraint(QLayout::SetFixedSize);
 	setLayout(layout);
 }
@@ -313,6 +202,7 @@ bool VariableSettingsDialog::AskForSettings(QWidget *parent, Variable &settings)
 	settings._saveAction =
 		static_cast<Variable::SaveAction>(dialog._save->currentIndex());
 	lastVariableChange = std::chrono::high_resolution_clock::now();
+
 	return true;
 }
 
@@ -322,6 +212,7 @@ static bool AskForSettingsWrapper(QWidget *parent, Item &settings)
 	if (VariableSettingsDialog::AskForSettings(parent, VariableSettings)) {
 		return true;
 	}
+
 	return false;
 }
 
@@ -385,4 +276,128 @@ VariableSignalManager *VariableSignalManager::Instance()
 	return &manager;
 }
 
+std::deque<std::shared_ptr<Item>> &GetVariables()
+{
+	return variables;
+}
+
+Variable *GetVariableByName(const std::string &name)
+{
+	for (const auto &v : variables) {
+		if (v->Name() == name) {
+			return dynamic_cast<Variable *>(v.get());
+		}
+	}
+
+	return nullptr;
+}
+
+Variable *GetVariableByQString(const QString &name)
+{
+	return GetVariableByName(name.toStdString());
+}
+
+std::weak_ptr<Variable> GetWeakVariableByName(const std::string &name)
+{
+	for (const auto &v : variables) {
+		if (v->Name() == name) {
+			std::weak_ptr<Variable> wp =
+				std::dynamic_pointer_cast<Variable>(v);
+			return wp;
+		}
+	}
+
+	return std::weak_ptr<Variable>();
+}
+
+std::weak_ptr<Variable> GetWeakVariableByQString(const QString &name)
+{
+	return GetWeakVariableByName(name.toStdString());
+}
+
+QStringList GetVariablesNameList()
+{
+	QStringList list;
+
+	for (const auto &var : variables) {
+		list << QString::fromStdString(var->Name());
+	}
+
+	list.sort();
+	return list;
+}
+
+std::string GetWeakVariableName(std::weak_ptr<Variable> var_)
+{
+	auto var = var_.lock();
+	if (!var) {
+		return obs_module_text("AdvSceneSwitcher.variable.invalid");
+	}
+
+	return var->Name();
+}
+
+static bool variableWithNameExists(const std::string &name)
+{
+	return !!GetVariableByName(name);
+}
+
+void SaveVariables(obs_data_t *obj)
+{
+	obs_data_array_t *variablesArray = obs_data_array_create();
+	for (const auto &v : variables) {
+		obs_data_t *array_obj = obs_data_create();
+		v->Save(array_obj);
+		obs_data_array_push_back(variablesArray, array_obj);
+		obs_data_release(array_obj);
+	}
+
+	obs_data_set_array(obj, "variables", variablesArray);
+	obs_data_array_release(variablesArray);
+}
+
+void LoadVariables(obs_data_t *obj)
+{
+	variables.clear();
+
+	obs_data_array_t *variablesArray = obs_data_get_array(obj, "variables");
+	size_t count = obs_data_array_count(variablesArray);
+
+	for (size_t i = 0; i < count; i++) {
+		obs_data_t *array_obj = obs_data_array_item(variablesArray, i);
+		auto var = Variable::Create();
+		variables.emplace_back(var);
+		variables.back()->Load(array_obj);
+		obs_data_release(array_obj);
+	}
+
+	obs_data_array_release(variablesArray);
+}
+
+void ImportVariables(obs_data_t *data)
+{
+	obs_data_array_t *array = obs_data_get_array(data, "variables");
+	size_t count = obs_data_array_count(array);
+
+	for (size_t i = 0; i < count; i++) {
+		obs_data_t *arrayElement = obs_data_array_item(array, i);
+		auto var = Variable::Create();
+		var->Load(arrayElement);
+		obs_data_release(arrayElement);
+
+		if (variableWithNameExists(var->Name())) {
+			continue;
+		}
+
+		GetVariables().emplace_back(var);
+	}
+
+	obs_data_array_release(array);
+}
+
+std::chrono::high_resolution_clock::time_point GetLastVariableChangeTime()
+{
+	return lastVariableChange;
+}
+
 } // namespace advss