From e4bd1fc180843ae9e43e8b7a75246441af4293c9 Mon Sep 17 00:00:00 2001 From: WarmUpTill Date: Fri, 21 Jan 2022 18:42:00 +0100 Subject: [PATCH] Reduce amount of signals emitted on repopulate --- src/transition-selection.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/transition-selection.cpp b/src/transition-selection.cpp index e85763fe..8c37b250 100644 --- a/src/transition-selection.cpp +++ b/src/transition-selection.cpp @@ -68,7 +68,6 @@ TransitionSelectionWidget::TransitionSelectionWidget(QWidget *parent, bool current, bool any) : QComboBox(parent) { - // For the rare occasion of a name conflict with current / previous setDuplicatesEnabled(true); populateTransitionSelection(this, current, any); @@ -81,7 +80,6 @@ void TransitionSelectionWidget::SetTransition(TransitionSelection &t) // Order of entries // 1. Any transition // 2. Current transition - // 3. Previous transition // 4. Transitions int idx; @@ -112,9 +110,12 @@ void TransitionSelectionWidget::SetTransition(TransitionSelection &t) void TransitionSelectionWidget::Repopulate(bool current, bool any) { - this->clear(); - populateTransitionSelection(this, current, any); - setCurrentIndex(0); + { + const QSignalBlocker blocker(this); + clear(); + populateTransitionSelection(this, current, any); + setCurrentIndex(0); + } TransitionSelection t; emit TransitionChanged(t); }