From cde111ddeb84446bde1eeeae8ee18d84dcc26427 Mon Sep 17 00:00:00 2001 From: WarmUpTill Date: Wed, 6 Dec 2023 10:54:31 +0100 Subject: [PATCH] Ignore settings which don't have a description or name This fixes a crash when attempting to populate the setttings selection of a Window Capture or Game Capture source --- src/utils/source-setting.cpp | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/utils/source-setting.cpp b/src/utils/source-setting.cpp index fdebc70a..5415f86f 100644 --- a/src/utils/source-setting.cpp +++ b/src/utils/source-setting.cpp @@ -50,11 +50,17 @@ std::vector GetSoruceSettings(obs_source_t *source) if (!it) { continue; } - SourceSetting setting( - obs_property_name(it), obs_property_description(it), - obs_property_long_description(it) - ? obs_property_long_description(it) - : ""); + auto name = obs_property_name(it); + if (!name) { + continue; + } + auto description = obs_property_description(it); + if (!description) { + continue; + } + auto longDescription = obs_property_long_description(it); + SourceSetting setting(name, description, + longDescription ? longDescription : ""); settings.emplace_back(setting); } while (obs_property_next(&it)); obs_properties_destroy(properties);