Fix item selection not updating correctly

* Remove could lead to the "add" dialog being opened
* Rename could result in some entries not being renamed (due to
  FilterComboBox using a QComboBox with setEditable() set to true)
This commit is contained in:
WarmUpTill
2024-02-17 23:22:18 +01:00
committed by WarmUpTill
parent e13b9b0aa7
commit c94863b0cb
6 changed files with 27 additions and 27 deletions

View File

@@ -285,22 +285,20 @@ VariableSelection::VariableSelection(QWidget *parent)
void VariableSelection::SetVariable(const std::string &variable)
{
const QSignalBlocker blocker(_selection);
if (!!GetVariableByName(variable)) {
_selection->setCurrentText(QString::fromStdString(variable));
SetItem(variable);
} else {
_selection->setCurrentIndex(-1);
SetItem("");
}
}
void VariableSelection::SetVariable(const std::weak_ptr<Variable> &variable_)
{
const QSignalBlocker blocker(_selection);
auto var = variable_.lock();
if (var) {
SetVariable(var->Name());
SetItem(var->Name());
} else {
_selection->setCurrentIndex(-1);
SetItem("");
}
}