diff --git a/src/headers/macro-action-audio.hpp b/src/headers/macro-action-audio.hpp index 7f4d60b1..a00d4a0a 100644 --- a/src/headers/macro-action-audio.hpp +++ b/src/headers/macro-action-audio.hpp @@ -37,6 +37,7 @@ public: MacroActionAudioEdit( QWidget *parent, std::shared_ptr entryData = nullptr); + void SetWidgetVisibility(); void UpdateEntryData(); static QWidget *Create(QWidget *parent, std::shared_ptr action) diff --git a/src/macro-action-audio.cpp b/src/macro-action-audio.cpp index a5473845..314c410f 100644 --- a/src/macro-action-audio.cpp +++ b/src/macro-action-audio.cpp @@ -130,17 +130,8 @@ bool hasSourceControl(AudioAction action) return action != AudioAction::MASTER_VOLUME; } -void MacroActionAudioEdit::UpdateEntryData() +void MacroActionAudioEdit::SetWidgetVisibility() { - if (!_entryData) { - return; - } - - _audioSources->setCurrentText( - GetWeakSourceName(_entryData->_audioSource).c_str()); - _actions->setCurrentIndex(static_cast(_entryData->_action)); - _volumePercent->setValue(_entryData->_volume); - if (hasVolumeControl(_entryData->_action)) { _volumePercent->show(); } else { @@ -154,6 +145,20 @@ void MacroActionAudioEdit::UpdateEntryData() } } +void MacroActionAudioEdit::UpdateEntryData() +{ + if (!_entryData) { + return; + } + + _audioSources->setCurrentText( + GetWeakSourceName(_entryData->_audioSource).c_str()); + _actions->setCurrentIndex(static_cast(_entryData->_action)); + _volumePercent->setValue(_entryData->_volume); + + SetWidgetVisibility(); +} + void MacroActionAudioEdit::SourceChanged(const QString &text) { if (_loading || !_entryData) { @@ -172,7 +177,7 @@ void MacroActionAudioEdit::ActionChanged(int value) std::lock_guard lock(switcher->m); _entryData->_action = static_cast(value); - UpdateEntryData(); + SetWidgetVisibility(); } void MacroActionAudioEdit::VolumeChanged(int value)