From 2986a5dd96e0dfd5a9208a72ea35706d00e2f269 Mon Sep 17 00:00:00 2001 From: WarmUpTill <19472752+WarmUpTill@users.noreply.github.com> Date: Sat, 1 Feb 2025 14:40:45 +0100 Subject: [PATCH] Fix crash when actions were copied into a action queue The steps added via AddPostLoadStep() from the copy were never executed. Thus they might be invalid when RunPostLoadSteps() is next called. This could result in a crash when a new action or condition is added after e.g. a "Filter" action's TempVariableRef was copied, which adds a PostLoadStep to resolve the macro segment reference. --- lib/queue/action-queue.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/queue/action-queue.cpp b/lib/queue/action-queue.cpp index 1a7faafc..a0cce29a 100644 --- a/lib/queue/action-queue.cpp +++ b/lib/queue/action-queue.cpp @@ -113,6 +113,7 @@ void ActionQueue::Add(const std::shared_ptr &action) action->Save(data); copy->Load(data); copy->PostLoad(); + RunPostLoadSteps(); copy->ResolveVariablesToFixedValues(); _actions.emplace_back(copy); } else {