diff --git a/src/advanced-scene-switcher.cpp b/src/advanced-scene-switcher.cpp index 2cd54b02..a4d50b86 100644 --- a/src/advanced-scene-switcher.cpp +++ b/src/advanced-scene-switcher.cpp @@ -1,13 +1,3 @@ -#include -#include -#include -#include -#include -#include - -#include -#include - #include "advanced-scene-switcher.hpp" #include "switcher-data.hpp" #include "status-control.hpp" @@ -17,6 +7,15 @@ #include "utility.hpp" #include "version.h" +#include +#include +#include +#include +#include +#include +#include +#include + namespace advss { AdvSceneSwitcher *AdvSceneSwitcher::window = nullptr; @@ -328,6 +327,8 @@ void SwitcherData::SetPreconditions() lastCursorPos = GetCursorPos(); } +void ClearWebsocketMessages(); + void SwitcherData::ResetForNextInterval() { // Core reset functions diff --git a/src/linux/advanced-scene-switcher-nix.cpp b/src/linux/advanced-scene-switcher-nix.cpp index 53169405..25c8be51 100644 --- a/src/linux/advanced-scene-switcher-nix.cpp +++ b/src/linux/advanced-scene-switcher-nix.cpp @@ -332,7 +332,7 @@ bool IsFullscreen(const std::string &title) return windowStatesAreSet(title, states); } -std::optional GetTextInWindow(const std::string &window) +std::optional GetTextInWindow(const std::string &) { // Not implemented return {}; diff --git a/src/macro-core/macro-action-hotkey.cpp b/src/macro-core/macro-action-hotkey.cpp index ff8d45f3..e04b74a9 100644 --- a/src/macro-core/macro-action-hotkey.cpp +++ b/src/macro-core/macro-action-hotkey.cpp @@ -2,6 +2,7 @@ #include "platform-funcs.hpp" #include "utility.hpp" +#include #include namespace advss { @@ -723,7 +724,7 @@ static QString getHotkeyDescriptionByName(const std::string &name) QString description = ""; } params; - auto func = [](void *param, obs_hotkey_id id, obs_hotkey_t *hotkey) { + auto func = [](void *param, obs_hotkey_id, obs_hotkey_t *hotkey) { auto params = static_cast(param); std::string name = obs_hotkey_get_name(hotkey); addNamePrefix(name, hotkey); diff --git a/src/macro-core/macro-condition-run.hpp b/src/macro-core/macro-condition-run.hpp index bc32b0b2..8e440d27 100644 --- a/src/macro-core/macro-condition-run.hpp +++ b/src/macro-core/macro-condition-run.hpp @@ -3,6 +3,7 @@ #include "process-config.hpp" #include "duration-control.hpp" +#include #include #include diff --git a/src/macro-core/macro-condition-slideshow.cpp b/src/macro-core/macro-condition-slideshow.cpp index 25201b49..ea9b13f6 100644 --- a/src/macro-core/macro-condition-slideshow.cpp +++ b/src/macro-core/macro-condition-slideshow.cpp @@ -200,9 +200,9 @@ MacroConditionSlideshowEdit::MacroConditionSlideshowEdit( QWidget *parent, std::shared_ptr entryData) : QWidget(parent), _conditions(new QComboBox(this)), - _sources(new SourceSelectionWidget(this, QStringList(), true)), _index(new VariableSpinBox(this)), - _path(new VariableLineEdit(this)) + _path(new VariableLineEdit(this)), + _sources(new SourceSelectionWidget(this, QStringList(), true)) { setToolTip(obs_module_text( "AdvSceneSwitcher.condition.slideshow.updateIntervalTooltip")); diff --git a/src/macro-core/macro-tab.cpp b/src/macro-core/macro-tab.cpp index 25eaaace..70dd6c93 100644 --- a/src/macro-core/macro-tab.cpp +++ b/src/macro-core/macro-tab.cpp @@ -731,9 +731,8 @@ void AdvSceneSwitcher::ShowMacroContextMenu(const QPoint &pos) obs_module_text("AdvSceneSwitcher.macroTab.export"), this, &AdvSceneSwitcher::ExportMacros); exportAction->setDisabled(ui->macros->SelectionEmpty()); - auto import = menu.addAction( - obs_module_text("AdvSceneSwitcher.macroTab.import"), this, - &AdvSceneSwitcher::ImportMacros); + menu.addAction(obs_module_text("AdvSceneSwitcher.macroTab.import"), + this, &AdvSceneSwitcher::ImportMacros); menu.exec(globalPos); } diff --git a/src/macro-core/macro-tree.cpp b/src/macro-core/macro-tree.cpp index ea94e027..c284ec57 100644 --- a/src/macro-core/macro-tree.cpp +++ b/src/macro-core/macro-tree.cpp @@ -609,7 +609,7 @@ bool MacroTreeModel::IsLastItem(std::shared_ptr item) const bool MacroTreeModel::IsInValidState() { // Check for reordering erros - for (int i = 0, j = 0; i < _macros.size(); i++) { + for (size_t i = 0, j = 0; i < _macros.size(); i++) { const auto &m = _macros[i]; if (QString::fromStdString(m->Name()) != data(index(j, 0), Qt::AccessibleTextRole)) { @@ -622,7 +622,7 @@ bool MacroTreeModel::IsInValidState() } // Check for group errors - for (int i = 0; i < _macros.size(); i++) { + for (size_t i = 0; i < _macros.size(); i++) { const auto &m = _macros[i]; if (!m->IsGroup()) { continue; diff --git a/src/macro-external/midi/CMakeLists.txt b/src/macro-external/midi/CMakeLists.txt index 07b86478..e2f8f7a8 100644 --- a/src/macro-external/midi/CMakeLists.txt +++ b/src/macro-external/midi/CMakeLists.txt @@ -5,7 +5,7 @@ project(advanced-scene-switcher-midi) get_target_property(ADVSS_SOURCE_DIR advanced-scene-switcher-lib SOURCE_DIR) set(LIBREMIDI_DIR "${ADVSS_SOURCE_DIR}/deps/libremidi") -if(NOT EXISTS "${LIBREMIDI_DIR}") +if(NOT EXISTS "${LIBREMIDI_DIR}/CMakeLists.txt") message(WARNING "libremidi directory \"${LIBREMIDI_DIR}\" not found!\n" "MIDI support will be disabled!") return() diff --git a/src/utils/item-selection-helpers.hpp b/src/utils/item-selection-helpers.hpp index 758776c6..6a55016e 100644 --- a/src/utils/item-selection-helpers.hpp +++ b/src/utils/item-selection-helpers.hpp @@ -4,16 +4,10 @@ #include #include #include -#include -#include #include #include -#include -#include -#include #include -#include -#include +#include namespace advss { diff --git a/src/utils/osc-helpers.cpp b/src/utils/osc-helpers.cpp index de313900..90248fd4 100644 --- a/src/utils/osc-helpers.cpp +++ b/src/utils/osc-helpers.cpp @@ -5,6 +5,12 @@ #include #include +#ifdef WIN32 +#include +#else +#include +#endif + namespace advss { std::unordered_map @@ -360,7 +366,7 @@ OSCMessageElementEdit::OSCMessageElementEdit(QWidget *parent) _text->hide(); _binaryText->hide(); - for (int i = 0; i < OSCMessageElement::_typeNames.size() - 1; i++) { + for (size_t i = 0; i < OSCMessageElement::_typeNames.size() - 1; i++) { _type->addItem(obs_module_text( OSCMessageElement::_typeNames.at(i).localizedName)); } diff --git a/src/utils/scene-item-selection.cpp b/src/utils/scene-item-selection.cpp index 8c676167..60cea9c4 100644 --- a/src/utils/scene-item-selection.cpp +++ b/src/utils/scene-item-selection.cpp @@ -367,7 +367,6 @@ std::vector SceneItemSelection::GetSceneItemsByName( } else { name = GetWeakSourceName(_source); } - int count = getCountOfSceneItemOccurance(sceneSelection, name, false); auto items = getSceneItemsWithName(scene, name); ReduceBadedOnIndexSelection(items); return items; @@ -754,6 +753,10 @@ void SceneItemSelectionWidget::SetNameConflictVisibility() sceneItemCount = getTotalSceneItemCountOnScene(_scene.GetScene(false)); break; + case SceneItemSelection::Type::INDEX: + case SceneItemSelection::Type::INDEX_RANGE: + case SceneItemSelection::Type::ALL: + break; } if (_currentSelection._type == diff --git a/src/utils/string-list.cpp b/src/utils/string-list.cpp index 94dda86a..71a9fdb8 100644 --- a/src/utils/string-list.cpp +++ b/src/utils/string-list.cpp @@ -3,6 +3,7 @@ #include "utility.hpp" #include +#include namespace advss { diff --git a/src/utils/utility.cpp b/src/utils/utility.cpp index 1e4b2f63..5dd11fd1 100644 --- a/src/utils/utility.cpp +++ b/src/utils/utility.cpp @@ -605,11 +605,11 @@ bool IsValidMacroSegmentIndex(Macro *m, const int idx, bool isCondition) return false; } if (isCondition) { - if (idx >= m->Conditions().size()) { + if (idx >= (int)m->Conditions().size()) { return false; } } else { - if (idx >= m->Actions().size()) { + if (idx >= (int)m->Actions().size()) { return false; } }