mirror of
https://github.com/yawut/SDL.git
synced 2026-07-06 19:54:20 -05:00
fb835f9e3b
manuel.montezelo Original bug report (note that it was against 2.0.0, it might have been fixed in between): http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733015 -------------------------------------------------------- Package: libsdl2-2.0-0 Version: 2.0.0+dfsg1-3 Severity: normal Tags: patch I have occasional crashes here caused by the X11 backend of SDL2. It seems to be caused by the X11_Pending function trying to add a high number (> 1024) file descriptor to a fd_set before doing a select on it to avoid busy waiting on X11 events. This causes a buffer overflow because the file descriptor is larger (or equal) than the limit FD_SETSIZE. Attached is a possible workaround patch. Please also keep in mind that fd_set are also used in following files which may have similar problems. src/audio/bsd/SDL_bsdaudio.c src/audio/paudio/SDL_paudio.c src/audio/qsa/SDL_qsa_audio.c src/audio/sun/SDL_sunaudio.c src/joystick/linux/SDL_sysjoystick.c -------------------------------------------------------- On Tuesday 24 December 2013 00:43:13 Sven Eckelmann wrote: > I have occasional crashes here caused by the X11 backend of SDL2. It seems > to be caused by the X11_Pending function trying to add a high number (> > 1024) file descriptor to a fd_set before doing a select on it to avoid busy > waiting on X11 events. This causes a buffer overflow because the file > descriptor is larger (or equal) than the limit FD_SETSIZE. I personally experienced this problem while hacking on the python bindings package for SDL2 [1] (while doing make runtest). But it easier to reproduce in a smaller, synthetic testcase. |
||
|---|---|---|
| .. | ||
| alsa | ||
| android | ||
| arts | ||
| coreaudio | ||
| directsound | ||
| disk | ||
| dsp | ||
| dummy | ||
| emscripten | ||
| esd | ||
| fusionsound | ||
| haiku | ||
| jack | ||
| nacl | ||
| nas | ||
| netbsd | ||
| paudio | ||
| psp | ||
| pulseaudio | ||
| qsa | ||
| sndio | ||
| sun | ||
| wasapi | ||
| winmm | ||
| xaudio2 | ||
| SDL_audio_c.h | ||
| SDL_audio.c | ||
| SDL_audiocvt.c | ||
| SDL_audiodev_c.h | ||
| SDL_audiodev.c | ||
| SDL_audiotypecvt.c | ||
| SDL_mixer.c | ||
| SDL_sysaudio.h | ||
| SDL_wave.c | ||
| SDL_wave.h | ||