SDL/src
Sam Lantinga 0669a224f5 Fixed bug 2860 - SetProp must be paired with RemoveProp especially for properties added to external windows
Coriiander

Upon creating a window, a window property is added to it through the Win32-function "SetProp". This is done in the SDL-function "SetupWindowData" in file "src\video\windows\SDL_windowswindow.c".

Whenever you call "SetProp" to add a property to a Win32-window, you should also call the Win32-function "RemoveProp" to remove it before destroying that Win32-window.

While you might think that it's ok and that Windows will clean up nicely itself, it is not ok. It is against all Win32-API guidelines and is mostlikely a leak. Especially on external windows (CreateWindowFrom) you want to have things done right, not messy and leaky, affecting some other module. Even if SDL gets shutdown entirely that external window will now forever still have the "SDL_WindowData" prop attached to it.
2015-05-28 08:41:07 -07:00
..
atomic Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
audio Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
core [IBus] Only register interest in messages sent to our input context. 2015-02-27 21:17:29 +00:00
cpuinfo Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
dynapi Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
events Added some unknown keys from Japanese 106/109 keyboards (thanks, "ver0hiro"!). 2015-05-26 20:55:03 -04:00
file Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
filesystem Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
haptic I think this will be the time... 2015-05-28 01:27:24 -04:00
joystick Another attempt to get this to compile. 2015-05-28 01:08:33 -04:00
libm Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
loadso Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
main Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
power Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
render Drop out of SDL_UpdateTexture() early if the rectangle is zero pixels. 2015-05-26 16:42:36 -04:00
stdlib Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
test Some setups need _GNU_SOURCE to make LLONG_MAX available (thanks, Ozkan!). 2015-05-26 16:31:11 -04:00
thread Uh, yeah, it helps to press "Save" before committing... 2015-05-26 21:30:41 -04:00
timer Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
video Fixed bug 2860 - SetProp must be paired with RemoveProp especially for properties added to external windows 2015-05-28 08:41:07 -07:00
SDL_assert_c.h Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
SDL_assert.c Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
SDL_error_c.h Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
SDL_error.c Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
SDL_hints.c Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
SDL_internal.h Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
SDL_log.c Updated the copyright year to 2015 2015-05-26 06:27:46 -07:00
SDL.c Stack hint should look for 0, not -1, and not care about environment variables. 2015-05-26 21:19:23 -04:00