mirror of
https://github.com/GearsProgress/Poke_Transporter_GB.git
synced 2026-04-24 23:47:45 -05:00
eef173b0d2
There was a crash happening with ptgb::vector when you'd press A on the CONFIRM button of the box screen. It only occurred on actual gba hardware and was a real heisenbug: as soon as you'd add code to display logs on screen, the problem would disappear. So it was very difficult to figure this one out. We're not even entirely sure why, but it looks like the malloc/realloc/free use in ptgb::vector would cause issues. Maybe it was alignment, but after messing with the code we also saw a warning appear in the terminal telling us that realloc wouldn't properly deal with non-POD types. It complained about this very thing while referring to the add_track() function, which stores ptgb::vectors inside another ptgb::vector. We also didn't have a custom copy constructor yet to actually copy the buffer instead of its pointer. All of these could potentially have led to the crash. But debugging during the link cable flow was difficult, so we were never able to confirm it in a debugger, log or dump. Because I suspected the high IWRAM consumption (especially now with ZX0 decompression) for a while, I also did an optimization in mystery_gift_builder to pass global_memory_buffer as its section_30_data buffer instead. This reduces IWRAM consumption by 4 KB. There was another problem I discovered during my crash hunt: the out_array (now payload_buffer) was allocated as a 672 byte array, but the payloads were actually 707 bytes. Therefore writing this to the buffer caused a buffer overflow, thereby corrupting the global variables appearing after it in IWRAM. It turned out eventually that none of these variables were really critical, but it could explain some minor bugs GearsProgress has seen. I also did a few performance optimizations: - At various stages in the code, for loops were used to copy data from one buffer into another byte-by-byte. This was far from optimal because the gba cpu can load/copy 4 bytes at a time if you ask it to. So I replaced those with memcpy(), which is a hand-optimized assembly function to copy data using this principle. - generate_payload was being called twice: once at start_link and once at continue_link, giving the exact same result, even though it was already being stored in a global buffer allocated in IWRAM. This was also a fairly heavy function. So I optimized the code to only initialize it once in the script chain and then just retrieve the buffer. - generate_payload was constructing the eventual payload twice even within the same call. That's because it first merged z80_rng_seed, z80_payload and z80_patchlist into a full_data ptgb::vector, after which it then copied the data again to out_array (now called payload_buffer). I eliminated the full_data vector now. |
||
|---|---|---|
| .. | ||
| gb_rom_values | ||
| gba_rom_values | ||
| libraries | ||
| background_engine.h | ||
| box_menu.h | ||
| button_handler.h | ||
| button_menu.h | ||
| debug_mode.h | ||
| dex_handler.h | ||
| flash_mem.h | ||
| gameboy_colour.h | ||
| gb_link.h | ||
| global_frame_controller.h | ||
| interrupt.h | ||
| japanese_small.h | ||
| latin_normal.h | ||
| latin_short.h | ||
| libstd_replacements.h | ||
| multiboot_upload.h | ||
| mystery_gift_builder.h | ||
| mystery_gift_injector.h | ||
| payload_builder.h | ||
| pkmn_font.h | ||
| pokedex.h | ||
| pokemon_data.h | ||
| pokemon_party.h | ||
| pokemon_trade.h | ||
| pokemon.h | ||
| random.h | ||
| rom_data.h | ||
| save_data_manager.h | ||
| script_array.h | ||
| script_obj.h | ||
| script_var.h | ||
| select_menu.h | ||
| sprite_data.h | ||
| text_data_table.h | ||
| text_engine.h | ||
| translated_text.h | ||
| z80_asm.h | ||
| zx0_decompressor.h | ||