Leahnaya/Poke_Transporter_GB
1
0
Fork 0
mirror of https://github.com/GearsProgress/Poke_Transporter_GB.git synced 2026-09-11 02:25:41 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix hardware-only bug

Browse Source 
We need to erase the sector before copying the data.

I also fixed an endianness problem in initialize_memory_locations(). This one was not caused by me.
This commit is contained in:
Philippe Symons
2026-04-02 11:52:26 +02:00
parent 9967fde1ad
commit b9f5fed1cd
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
source/flash_mem.cpp
View File

@@ -22,11 +22,19 @@ void initialize_memory_locations()
u8 save_B_index[4];
copy_save_to_ram(SAVE_A_OFFSET + SAVE_INDEX_OFFSET, &save_A_index[0], 0x04);
copy_save_to_ram(SAVE_B_OFFSET + SAVE_INDEX_OFFSET, &save_B_index[0], 0x04);
reverse_endian(&save_A_index[0], 0x04);
reverse_endian(&save_B_index[0], 0x04);
// Save indices are little-endian in-sector; decode directly without byte swapping.
const u32 saveAIndex = static_cast<u32>(save_A_index[0]) |
(static_cast<u32>(save_A_index[1]) << 8) |
(static_cast<u32>(save_A_index[2]) << 16) |
(static_cast<u32>(save_A_index[3]) << 24);
const u32 saveBIndex = static_cast<u32>(save_B_index[0]) |
(static_cast<u32>(save_B_index[1]) << 8) |
(static_cast<u32>(save_B_index[2]) << 16) |
(static_cast<u32>(save_B_index[3]) << 24);
// Determines if save A or B is more recent
if (*(vu32 *)save_B_index > *(vu32 *)save_A_index)
if (saveBIndex > saveAIndex)
{
newest_save_offset = SAVE_B_OFFSET;
}