Leahnaya/Poke_Transporter_GB
1
0
Fork 0
mirror of https://github.com/GearsProgress/Poke_Transporter_GB.git synced 2026-10-25 00:45:53 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Eliminate unused fields on rom_data

Browse Source 
We may also want to remove them from the ROM_DATA structs that actually get published into tables for PTGB (from within PCCS) later.
This commit is contained in:
Philippe Symons
2026-08-11 13:58:25 +02:00
parent b8b0dd25e4
commit 7cb96a7215
2 changed files with 1 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
source/rom_data.cpp
View File

@@ -91,37 +91,16 @@ bool rom_data::load_rom(bool debug)
void rom_data::fill_values(const ROM_DATA *rom_values)
{
loc_sendMonToPC = rom_values->loc_copyMonToPC;
loc_gSpecialVar_0x8000 = rom_values->loc_gSpecialVar_0x8000;
loc_gSaveBlock1 = rom_values->loc_gSaveBlock1;
loc_setPokedexFlag = rom_values->loc_getSetPokedexFlag;
loc_gSaveDataBuffer = rom_values->loc_gSaveDataBuffer;
loc_readFlashSector = rom_values->loc_readFlashSector;
loc_loadSaveSection30 = rom_values->loc_loadSaveSection30;
loc_m4aMPlayStop = rom_values->loc_m4aMPlayStop;
loc_gMPlayInfo_BGM = rom_values->loc_gMPlayInfo_BGM;
loc_gMPlayInfo_SE2 = rom_values->loc_gMPlayInfo_SE2;
loc_MPlayStart = rom_values->loc_MPlayStart;
loc_CreateFanfareTask = rom_values->loc_CreateFanfareTask;
loc_sFanfareCounter = rom_values->loc_sFanfareCounter;
loc_gPlttBufferFaded = rom_values->loc_gPlttBufferFaded;
loc_gSprites = rom_values->loc_gSprites;
loc_voicegroup = rom_values->loc_voicegroup;
loc_sPicTable_NPC = rom_values->loc_sPicTable_NPC;
loc_gMonIconPalettes = rom_values->loc_gMonIconPalettes;
loc_gMonFrontPicTable = rom_values->loc_gMonFrontPicTable;
loc_gMonPaletteTable = rom_values->loc_gMonPaletteTable;
loc_gMonShinyPaletteTable = rom_values->loc_gMonShinyPaletteTable;
loc_gMonIconTable = rom_values->loc_gMonIconTable;
loc_gMonIconPaletteIndices = rom_values->loc_gMonIconPaletteIndices;
loc_gMonIconPalettes = rom_values->loc_gMonIconPalettes;
offset_ramscript = rom_values->offset_ramscript;
offset_flags = rom_values->offset_flags;
offset_wondercard = rom_values->offset_wondercard;
offset_script = rom_values->offset_script;
text_region = rom_values->text_region;
special_DrawWholeMapView = rom_values->special_DrawWholeMapView;
e4_flag = rom_values->e4_flag; // The flag that is set when you become champion. Often listed as "GAME_CLEAR"
mg_flag = rom_values->mg_flag; // The flag that is set when you enable Mystery Gift. Known as "EXDATA_ENABLE" in RS
@@ -132,13 +111,10 @@ void rom_data::fill_values(const ROM_DATA *rom_values)
map_bank = rom_values->map_bank;
map_id = rom_values->map_id;
npc_id = rom_values->npc_id;
npc_palette = rom_values->npc_palette;
def_map_bank = rom_values->def_map_bank;
def_map_id = rom_values->def_map_id;
def_npc_id = rom_values->def_npc_id;
loc_gSaveBlock1PTR = rom_values->loc_gSaveBlock1PTR; // TODO: Only used for old script, can be removed later
}
bool rom_data::is_hoenn()