mirror of
https://github.com/kwsch/PKHeX.git
synced 2026-05-20 20:58:30 -05:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
30 lines
747 B
C#
30 lines
747 B
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
/// <summary>
|
|
/// Generation 6 Secret Base Decoration Good Inventory stock for a given good-index.
|
|
/// </summary>
|
|
public sealed class SecretBase6GoodStock
|
|
{
|
|
public const int SIZE = 4;
|
|
|
|
public ushort Count { get; set; }
|
|
public bool IsNew { get; set; }
|
|
|
|
public SecretBase6GoodStock(ReadOnlySpan<byte> data)
|
|
{
|
|
Count = ReadUInt16LittleEndian(data);
|
|
IsNew = data[2] != 0;
|
|
}
|
|
|
|
public void Write(Span<byte> data)
|
|
{
|
|
WriteUInt16LittleEndian(data, Count);
|
|
data[2] = (byte)(IsNew ? 1 : 0);
|
|
data[3] = 0;
|
|
}
|
|
}
|
|
}
|