mirror of
https://github.com/kwsch/PKHeX.git
synced 2026-05-20 20:58:30 -05:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
42 lines
1.2 KiB
C#
42 lines
1.2 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class SecretBase6GoodPlacement
|
|
{
|
|
public const int SIZE = 12;
|
|
|
|
public ushort Good { get; set; }
|
|
public ushort X { get; set; }
|
|
public ushort Y { get; set; }
|
|
public byte Rotation { get; set; }
|
|
// byte unused
|
|
|
|
public ushort Param1 { get; set; }
|
|
public ushort Param2 { get; set; }
|
|
|
|
public SecretBase6GoodPlacement(ReadOnlySpan<byte> data)
|
|
{
|
|
Good = ReadUInt16LittleEndian(data);
|
|
X = ReadUInt16LittleEndian(data[2..]);
|
|
Y = ReadUInt16LittleEndian(data[4..]);
|
|
Rotation = data[6];
|
|
|
|
Param1 = ReadUInt16LittleEndian(data[8..]);
|
|
Param2 = ReadUInt16LittleEndian(data[10..]);
|
|
}
|
|
|
|
public void Write(Span<byte> data)
|
|
{
|
|
WriteUInt16LittleEndian(data, Good);
|
|
WriteUInt16LittleEndian(data[2..], X);
|
|
WriteUInt16LittleEndian(data[4..], Y);
|
|
data[6] = Rotation;
|
|
|
|
WriteUInt16LittleEndian(data[8..], Param1);
|
|
WriteUInt16LittleEndian(data[10..], Param2);
|
|
}
|
|
}
|
|
}
|