mirror of
https://github.com/kwsch/PKHeX.git
synced 2026-05-23 11:06:22 -05:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
39 lines
1.4 KiB
C#
39 lines
1.4 KiB
C#
using System;
|
|
using System.Linq;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class ShadowInfoTableXD
|
|
{
|
|
private readonly ShadowInfoEntryXD[] Entries;
|
|
private readonly int MaxLength;
|
|
private readonly int SIZE_ENTRY;
|
|
private const int MaxCount = 128;
|
|
|
|
public ShadowInfoTableXD(ReadOnlySpan<byte> data, bool jp)
|
|
{
|
|
SIZE_ENTRY = GetEntrySize(jp);
|
|
MaxLength = data.Length;
|
|
int eCount = data.Length/SIZE_ENTRY;
|
|
Entries = new ShadowInfoEntryXD[eCount];
|
|
for (int i = 0; i < eCount; i++)
|
|
Entries[i] = GetEntry(data, i, jp);
|
|
}
|
|
|
|
private static int GetEntrySize(bool jp) => jp ? ShadowInfoEntry3J.SIZE_ENTRY : ShadowInfoEntry3U.SIZE_ENTRY;
|
|
|
|
public ShadowInfoTableXD(bool jp) : this(new byte[GetEntrySize(jp) * MaxCount], jp) { }
|
|
|
|
private ShadowInfoEntryXD GetEntry(ReadOnlySpan<byte> data, int index, bool jp)
|
|
{
|
|
var slice = data.Slice(index * SIZE_ENTRY, SIZE_ENTRY).ToArray();
|
|
return jp ? new ShadowInfoEntry3J(slice) : new ShadowInfoEntry3U(slice);
|
|
}
|
|
|
|
public byte[] Write() => Entries.SelectMany(entry => entry.Data).Take(MaxLength).ToArray();
|
|
|
|
public ShadowInfoEntryXD this[int index] { get => Entries[index]; set => Entries[index] = value; }
|
|
public int Count => Entries.Length;
|
|
}
|
|
}
|