PKHeX/PKHeX.Core/Legality/Verifiers
Kurt 02420d3e93
PKHeX.Core Nullable cleanup (#2401)
* Handle some nullable cases

Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data)
Make some classes have explicit constructors instead of { } initialization

* Handle bits more obviously without null

* Make SaveFile.BAK explicitly readonly again

* merge constructor methods to have readonly fields

* Inline some properties

* More nullable handling

* Rearrange box actions

define straightforward classes to not have any null properties

* Make extrabyte reference array immutable

* Move tooltip creation to designer

* Rearrange some logic to reduce nesting

* Cache generated fonts
* Split mystery gift album purpose
* Handle more tooltips
* Disallow null setters
* Don't capture RNG object, only type enum

* Unify learnset objects
Now have readonly properties which are never null
don't new() empty learnsets (>800 Learnset objects no longer created,
total of 2400 objects since we also new() a move & level array)
optimize g1/2 reader for early abort case

* Access rewrite
Initialize blocks in a separate object, and get via that object
removes a couple hundred "might be null" warnings since blocks are now readonly getters
some block references have been relocated, but interfaces should expose all that's needed
put HoF6 controls in a groupbox, and disable

* Readonly personal data
* IVs non nullable for mystery gift
* Explicitly initialize forced encounter moves
* Make shadow objects readonly & non-null
Put murkrow fix in binary data resource, instead of on startup
* Assign dex form fetch on constructor
Fixes legality parsing edge cases
also handle cxd parse for valid; exit before exception is thrown in FrameGenerator

* Remove unnecessary null checks
* Keep empty value until init
SetPouch sets the value to an actual one during load, but whatever

* Readonly team lock data
* Readonly locks
Put locked encounters at bottom (favor unlocked)

* Mail readonly data / offset
Rearrange some call flow and pass defaults
Add fake classes for SaveDataEditor mocking
Always party size, no need to check twice in stat editor
use a fake save file as initial data for savedata editor, and for
gamedata (wow i found a usage)
constrain eventwork editor to struct variable types (uint, int, etc),
thus preventing null assignment errors
2019-10-16 18:47:31 -07:00
..
Ribbons PKHeX.Core Nullable cleanup (#2401) 2019-10-16 18:47:31 -07:00
AbilityVerifier.cs Use some c#8 sugar 2019-10-07 18:40:09 -07:00
BallVerifier.cs Bump lang version to 8 2019-10-04 20:10:50 -07:00
ConsoleRegionVerifier.cs Update legality check message string style 2018-09-01 14:11:12 -07:00
CXDVerifier.cs PKHeX.Core Nullable cleanup (#2401) 2019-10-16 18:47:31 -07:00
EffortValueVerifier.cs Move GetIV to pkm, misc simplifications 2019-01-05 10:51:41 -08:00
EncounterTypeVerifier.cs Update legality check message string style 2018-09-01 14:11:12 -07:00
FormVerifier.cs PKHeX.Core Nullable cleanup (#2401) 2019-10-16 18:47:31 -07:00
GenderVerifier.cs use some explicit dex numbers as enum 2019-06-01 10:22:49 -07:00
HyperTrainingVerifier.cs Add gold bottle cap bypass for LGPE 2019-01-06 16:21:34 -08:00
IndividualValueVerifier.cs PKHeX.Core Nullable cleanup (#2401) 2019-10-16 18:47:31 -07:00
ItemVerifier.cs Misc parse settings reorg 2018-10-05 19:58:30 -07:00
LanguageVerifier.cs Misc parse settings reorg 2018-10-05 19:58:30 -07:00
LevelVerifier.cs Misc updates 2019-01-11 17:44:51 -08:00
MedalVerifier.cs Clean up super training medal checks 2019-09-20 20:55:36 -07:00
MemoryVerifier.cs PKHeX.Core Nullable cleanup (#2401) 2019-10-16 18:47:31 -07:00
MiscVerifier.cs PKHeX.Core Nullable cleanup (#2401) 2019-10-16 18:47:31 -07:00
NHarmoniaVerifier.cs Refactoring iencounterable->pkm 2019-02-09 11:37:20 -08:00
NicknameVerifier.cs PKHeX.Core Nullable cleanup (#2401) 2019-10-16 18:47:31 -07:00
ParseSettings.cs PKHeX.Core Nullable cleanup (#2401) 2019-10-16 18:47:31 -07:00
PIDVerifier.cs Misc clean 2019-09-10 00:21:51 -07:00
TrainerNameVerifier.cs Use some c#8 sugar 2019-10-07 18:40:09 -07:00
TransferVerifier.cs Use some c#8 sugar 2019-10-07 18:40:09 -07:00
Verifier.cs Rework secondary check flow 2018-06-23 22:00:01 -07:00