mirror of
https://github.com/kwsch/PKHeX.git
synced 2026-05-24 15:06:38 -05:00
9166d0eb64
Rewrites a good amount of legality APIs pertaining to: * Legal moves that can be learned * Evolution chains & cross-generation paths * Memory validation with forgotten moves In generation 8, there are 3 separate contexts an entity can exist in: SW/SH, BD/SP, and LA. Not every entity can cross between them, and not every entity from generation 7 can exist in generation 8 (Gogoat, etc). By creating class models representing the restrictions to cross each boundary, we are able to better track and validate data. The old implementation of validating moves was greedy: it would iterate for all generations and evolutions, and build a full list of every move that can be learned, storing it on the heap. Now, we check one game group at a time to see if the entity can learn a move that hasn't yet been validated. End result is an algorithm that requires 0 allocation, and a smaller/quicker search space. The old implementation of storing move parses was inefficient; for each move that was parsed, a new object is created and adjusted depending on the parse. Now, move parse results are `struct` and store the move parse contiguously in memory. End result is faster parsing and 0 memory allocation. * `PersonalTable` objects have been improved with new API methods to check if a species+form can exist in the game. * `IEncounterTemplate` objects have been improved to indicate the `EntityContext` they originate in (similar to `Generation`). * Some APIs have been extended to accept `Span<T>` instead of Array/IEnumerable
40 lines
1.3 KiB
C#
40 lines
1.3 KiB
C#
namespace PKHeX.Core;
|
|
|
|
/// <summary>
|
|
/// Logic for applying a <see cref="PK1.Catch_Rate"/> value.
|
|
/// </summary>
|
|
public static class CatchRateApplicator
|
|
{
|
|
public static int GetSuggestedCatchRate(PK1 pk1, SaveFile sav)
|
|
{
|
|
var la = new LegalityAnalysis(pk1);
|
|
return GetSuggestedCatchRate(pk1, sav, la);
|
|
}
|
|
|
|
public static byte GetSuggestedCatchRate(PK1 pk1, SaveFile sav, LegalityAnalysis la)
|
|
{
|
|
if (la.Valid)
|
|
return pk1.Catch_Rate;
|
|
|
|
if (la.Info.Generation == 2)
|
|
return 0;
|
|
|
|
var v = la.EncounterMatch;
|
|
switch (v)
|
|
{
|
|
case EncounterTrade1 c:
|
|
return c.GetInitialCatchRate();
|
|
case EncounterStatic1E { Version: GameVersion.Stadium, Species: (int)Species.Psyduck}:
|
|
return pk1.Japanese ? (byte)167 : (byte)168; // Amnesia Psyduck has different catch rates depending on language
|
|
default:
|
|
{
|
|
if (sav.Version.Contains(v.Version) || v.Version.Contains(sav.Version))
|
|
return (byte)sav.Personal[v.Species].CatchRate;
|
|
if (!GameVersion.RB.Contains(v.Version))
|
|
return (byte)PersonalTable.Y[v.Species].CatchRate;
|
|
return (byte)PersonalTable.RB[v.Species].CatchRate;
|
|
}
|
|
}
|
|
}
|
|
}
|