mirror of
https://github.com/kwsch/PKHeX.git
synced 2026-05-05 13:07:11 -05:00
fb52a5ef18
Closes #4679 ty @andrebastosdias ! Revise untrained EV check to flag Pokespot encounters (the only varied level range encounter in gen3/4) where min level might be less than the actual level it was obtained at. If/when pokespot correlation is better refined, can switch to evotree level min for a gen3->4 transfer, so that something at a not-minimum exact level can be flagged if it has non-Vitamin EVs.
102 lines
4.1 KiB
C#
102 lines
4.1 KiB
C#
using System;
|
|
using System.Diagnostics.CodeAnalysis;
|
|
using static PKHeX.Core.LegalityCheckResultCode;
|
|
|
|
namespace PKHeX.Core;
|
|
|
|
/// <summary>
|
|
/// Verifies the <see cref="EffortValues"/>.
|
|
/// </summary>
|
|
public sealed class EffortValueVerifier : Verifier
|
|
{
|
|
protected override CheckIdentifier Identifier => CheckIdentifier.EVs;
|
|
|
|
public override void Verify(LegalityAnalysis data)
|
|
{
|
|
var pk = data.Entity;
|
|
if (pk.IsEgg)
|
|
{
|
|
if (pk.EVTotal is not 0)
|
|
data.AddLine(GetInvalid(EffortEgg));
|
|
return;
|
|
}
|
|
|
|
// In Generation 1 & 2, when a Pokémon is taken out of the Day Care, its experience will lower to the minimum value for its current level.
|
|
// When transferred to Gen7+, EVs are reset to 0, so checks will be relevant then.
|
|
byte format = pk.Format;
|
|
if (format < 3) // Can abuse daycare for EV training without EXP gain
|
|
return;
|
|
|
|
int sum = pk.EVTotal;
|
|
if (sum > EffortValues.Max510) // format >= 3
|
|
data.AddLine(GetInvalid(EffortAbove510));
|
|
|
|
var enc = data.EncounterMatch;
|
|
Span<int> evs = stackalloc int[6];
|
|
pk.GetEVs(evs);
|
|
|
|
if (format >= 6 && IsAnyAboveHardLimit6(evs))
|
|
data.AddLine(GetInvalid(EffortAbove252));
|
|
else if (format < 5) // 3/4
|
|
VerifyGainedEVs34(data, enc, evs, pk);
|
|
|
|
// Only one of the following can be true: 0, 508, and x%6!=0
|
|
if (sum == 0 && !enc.IsWithinEncounterRange(pk))
|
|
data.AddLine(Get(Severity.Fishy, EffortEXPIncreased));
|
|
else if (sum == EffortValues.MaxEffective)
|
|
data.AddLine(Get(Severity.Fishy, Effort2Remaining));
|
|
else if (evs[0] != 0 && !evs.ContainsAnyExcept(evs[0]))
|
|
data.AddLine(Get(Severity.Fishy, EffortAllEqual));
|
|
}
|
|
|
|
private void VerifyGainedEVs34(LegalityAnalysis data, IEncounterTemplate enc, ReadOnlySpan<int> evs, PKM pk)
|
|
{
|
|
var isVitaminResult = IsWithinVitaminRange34(evs, EffortValues.MaxVitamins34);
|
|
if (isVitaminResult)
|
|
return;
|
|
|
|
if (enc.LevelMin == Experience.MaxLevel) // only true for Gen4 and Format=4
|
|
{
|
|
// Cannot EV train at level 100 -- Certain events are distributed at level 100.
|
|
// EVs can only be increased by vitamins to a max of 100.
|
|
data.AddLine(GetInvalid(EffortCap100));
|
|
}
|
|
else // Check for gained EVs without gaining EXP -- don't check Gen5+ which have wings to boost above 100.
|
|
{
|
|
// Be slightly forgiving for past gen transfers where Met Level is overwritten; we might not be able to infer the exact level met (RNG correlations?).
|
|
// Current code won't be able to flag PokéSpot not-min-level-met. If correlation and pruning (evo chain) improved, we can use that level min instead.
|
|
// (Wonder if this also impacts wild encounter slots with multiple levels? Hopefully the lowest level is yielded first).
|
|
var metLevel = enc.Generation == pk.Format ? pk.MetLevel : enc.LevelMin;
|
|
if (metLevel < enc.LevelMin)
|
|
metLevel = enc.LevelMin;
|
|
|
|
var growth = PersonalTable.HGSS[enc.Species].EXPGrowth;
|
|
var baseEXP = Experience.GetEXP(metLevel, growth);
|
|
if (baseEXP == pk.EXP)
|
|
data.AddLine(GetInvalid(EffortUntrainedCap_0, EffortValues.MaxVitamins34));
|
|
}
|
|
}
|
|
|
|
// Hard cap at 252 for Gen6+
|
|
private static bool IsAnyAboveHardLimit6(ReadOnlySpan<int> evs)
|
|
=> evs.ContainsAnyExceptInRange(0, EffortValues.Max252);
|
|
|
|
// Vitamins can only raise to 100 in Gen3/4, only in multiples of 10.
|
|
private static bool IsWithinVitaminRange34(ReadOnlySpan<int> evs, [ConstantExpected] ushort limit)
|
|
{
|
|
foreach (var ev in evs)
|
|
{
|
|
// The majority of cases will pass here; 0 is default & valid.
|
|
// Eager check to skip unnecessary less performant checks.
|
|
if (ev is 0)
|
|
continue;
|
|
|
|
if (ev > limit)
|
|
return false;
|
|
if (ev % 10 != 0)
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
}
|