Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-04-25 08:10:48 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

FR/LG VC: flag unavailable evolutions/eggs

Browse Source 
Need to check for traded eggs hatched in RSE as well; those must pass the first check based on their assigned version value.
This commit is contained in:
Kurt 2026-02-27 17:21:31 -06:00
parent c037829b29
commit fa0ac2a9ab
2 changed files with 43 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
PKHeX.Core/Legality/Encounters/Verifiers/EncounterVerifier.cs
View File

@ -152,6 +152,8 @@ private static CheckResult VerifyEncounterEgg3(PKM pk)
return GetValid(EggLocation);
// Version isn't updated when hatching on a different game. Check any game.
if (!ParseSettings.AllowGBACrossTransferRSE(pk)) // Must match the origin game (Nintendo Switch VC)
return GetInvalid(EggLocationInvalid);
if (EggHatchLocation3.IsValidMet3Any(met))
return GetValid(EggLocationTrade);
return GetInvalid(EggLocationInvalid);

42
PKHeX.Core/Legality/Verifiers/Misc/MiscVerifierG3.cs
View File

@ -1,3 +1,4 @@
using System;
using static PKHeX.Core.LegalityCheckResultCode;
using static PKHeX.Core.CheckIdentifier;
@ -20,6 +21,45 @@ internal void Verify(LegalityAnalysis data, G3PKM pk)
// Only FR/LG are released. Only can originate from FR/LG.
if (pk.Version is not (GameVersion.FR or GameVersion.LG))
data.AddLine(GetInvalid(EncUnreleased));
data.AddLine(GetInvalid(TradeNotAvailable));
else if (IsForeignFRLG(pk.Species))
data.AddLine(GetInvalid(TradeNotAvailable));
}
/// <summary>
/// For a species with a potentially valid FR/LG origin encounter, flag if not permitted.
/// </summary>
public static bool IsForeignFRLG(ushort species) => IsForeign(ForeignFRLG, species);
public static bool IsForeign(ReadOnlySpan<byte> bitSet, int species)
{
species -= ShiftFRLG;
var offset = species >> 3;
if (offset >= bitSet.Length)
return false;
var bit = species & 7;
if ((bitSet[offset] & (1 << bit)) != 0)
return true;
return false;
}
private const ushort ShiftFRLG = 152; // First unavailable Species (ignoring Mew)
/// <summary>
/// Bitset representing species that are considered unobtainable in FR/LG.
/// Includes foreign transfers and time-of-day evolutions.
/// First species is Chikorita (152), last is Deoxys (386). Mew (151) is not included since it is not obtainable with a FR/LG version ID (eager check).
/// </summary>
/// <remarks>
/// Source: https://www.serebii.net/fireredleafgreen/unobtainable.shtml
/// </remarks>
private static ReadOnlySpan<byte> ForeignFRLG =>
[
0xFF, 0x19, 0x0C, 0x30, 0x82, 0x31, 0xA8, 0x06,
0x42, 0x20, 0x00, 0x02, 0xF8, 0xFF, 0xFF, 0xFF,
0xFF, 0xFF, 0xFB, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF,
0xFF, 0xFF, 0xFE, 0xFF, 0xFF, 0x03,
];
}