Leahnaya/PKHeX
1
0
Fork 0
mirror of https://github.com/kwsch/PKHeX.git synced 2026-05-19 20:28:24 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add frlg unown PIDIV type

Browse Source 
The modified form-finding routine generates the PID gen halves in the
reverse order like events. Due to possible collisions with event PIDIVs,
only run it for unown (since that's all it applies to); the analyzing of
PIDIVs to find incorrect usages isn't really feasible (collision) for
this one.
#1103
This commit is contained in:
Kurt 2017-05-01 08:37:23 -07:00
parent f19d85002b
commit f1db88026b
3 changed files with 65 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
PKHeX/Legality/RNG/MethodFinder.cs
View File

@ -32,6 +32,8 @@ public static PIDIV Analyze(PKM pk)
PIDIV pidiv;
if (getLCRNGMatch(top, bot, IVs, out pidiv))
return pidiv;
if (pk.Species == 201 && getLCRNGUnownMatch(top, bot, IVs, out pidiv)) // frlg only
return pidiv;
if (getXDRNGMatch(top, bot, IVs, out pidiv))
return pidiv;
@ -90,6 +92,41 @@ private static bool getLCRNGMatch(uint top, uint bot, uint[] IVs, out PIDIV pidi
pidiv = null;
return false;
}
private static bool getLCRNGUnownMatch(uint top, uint bot, uint[] IVs, out PIDIV pidiv)
{
// this is an exact copy of LCRNG 1,2,4 matching, except the PID has its halves switched (BACD, BADE, BACE)
var reg = getSeedsFromPID(RNG.LCRNG, bot, top); // reversed!
foreach (var seed in reg)
{
// A and B are already used by PID
var B = RNG.LCRNG.Advance(seed, 2);
// Method 1/2/4 can use 3 different RNG frames
var C = RNG.LCRNG.Next(B);
var D = RNG.LCRNG.Next(C);
if (getIVs(C >> 16, D >> 16).SequenceEqual(IVs)) // BACD
{
pidiv = new PIDIV { OriginSeed = seed, RNG = RNG.LCRNG, Type = PIDType.Method_1_Unown };
return true;
}
var E = RNG.LCRNG.Next(D);
if (getIVs(D >> 16, E >> 16).SequenceEqual(IVs)) // BADE
{
pidiv = new PIDIV { OriginSeed = seed, RNG = RNG.LCRNG, Type = PIDType.Method_2_Unown };
return true;
}
if (getIVs(C >> 16, E >> 16).SequenceEqual(IVs)) // BACE
{
pidiv = new PIDIV { OriginSeed = seed, RNG = RNG.LCRNG, Type = PIDType.Method_4_Unown };
return true;
}
}
pidiv = null;
return false;
}
private static bool getXDRNGMatch(uint top, uint bot, uint[] IVs, out PIDIV pidiv)
{
var xdc = getSeedsFromPID(RNG.XDRNG, bot, top);

6
PKHeX/Legality/RNG/PIDType.cs
View File

@ -11,6 +11,12 @@ public enum PIDType
Method_2,
/// <summary> Method H4 </summary>
Method_4,
/// <summary> Method H1_Unown (FRLG) </summary>
Method_1_Unown,
/// <summary> Method H2_Unown (FRLG) </summary>
Method_2_Unown,
/// <summary> Method H4_Unown (FRLG) </summary>
Method_4_Unown,
/// <summary>
/// Event Reversed Order PID restricted to 16bit Origin Seed

22
Tests/PKHeX.Tests/PKM/PKMTests.cs
View File

@ -254,6 +254,28 @@ public void PIDIVMatchingTest()
Assert.AreEqual(true, MethodFinder.getPokeSpotSeeds(pkPS1, 1).Any(), "PokeSpot encounter info mismatch (Uncommon)");
var pkPS2 = new PK3 {PID = 0x9B667F3C}; // Surskit (Oasis)
Assert.AreEqual(true, MethodFinder.getPokeSpotSeeds(pkPS2, 2).Any(), "PokeSpot encounter info mismatch (Rare)");
var pk1U = new PK3
{
Species = 201, // Unown-C
PID = 0x815549A2,
IVs = new[] {02, 26, 30, 30, 11, 26}
};
Assert.AreEqual(PIDType.Method_1_Unown, MethodFinder.Analyze(pk1U)?.Type, "Unable to match PID to Method 1 Unown spread");
var pk2U = new PK3
{
Species = 201, // Unown-M
PID = 0x8A7B5190,
IVs = new[] {14, 02, 21, 30, 29, 15}
};
Assert.AreEqual(PIDType.Method_2_Unown, MethodFinder.Analyze(pk2U)?.Type, "Unable to match PID to Method 2 Unown spread");
var pk4U = new PK3
{
Species = 201, // Unown-C
PID = 0x5FA80D70,
IVs = new[] {02, 06, 03, 26, 04, 19}
};
Assert.AreEqual(PIDType.Method_4_Unown, MethodFinder.Analyze(pk4U)?.Type, "Unable to match PID to Method 4 Unown spread");
}
}
}