From e91cfeb7075d932813bdb27f8e3dfc2c0ad8b7fc Mon Sep 17 00:00:00 2001 From: Kurt Date: Sun, 17 Jun 2018 09:55:07 -0700 Subject: [PATCH] Handle pre-VC2 era tradeback status for suggestions #2015 Can't get a shiny female 1:7 f:m gender ratio transfer after the VC2 bank update; need to respect that when generating random moves for the pkm by removing any gen2 evo chain data. --- PKHeX.Core/Legality/Analysis.cs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/PKHeX.Core/Legality/Analysis.cs b/PKHeX.Core/Legality/Analysis.cs index e56478b95..3437d9983 100644 --- a/PKHeX.Core/Legality/Analysis.cs +++ b/PKHeX.Core/Legality/Analysis.cs @@ -369,7 +369,14 @@ public int[] GetSuggestedMoves(bool tm, bool tutor, bool reminder) var ver = EncounterOriginal is IVersion v ? v.Version : (GameVersion)pkm.Version; return MoveLevelUp.GetEncounterMoves(pkm, lvl, ver); } - return Legal.GetValidMoves(pkm, Info.EvoChainsAllGens, Tutor: tutor, Machine: tm, MoveReminder: reminder).Skip(1).ToArray(); // skip move 0 + var evos = Info.EvoChainsAllGens; + if (Info.Generation == 1 && pkm.TradebackStatus == TradebackType.Gen1_NotTradeback) + { + // purge vc2 from possible chain + evos = (DexLevel[][])evos.Clone(); + evos[2] = new DexLevel[0]; + } + return Legal.GetValidMoves(pkm, evos, Tutor: tutor, Machine: tm, MoveReminder: reminder).Skip(1).ToArray(); // skip move 0 } public EncounterStatic GetSuggestedMetInfo() => EncounterSuggestion.GetSuggestedMetInfo(pkm); }