From e3fa760f529a9e18cf583149d1d60c17eef6be84 Mon Sep 17 00:00:00 2001 From: Kurt Date: Mon, 5 Jan 2026 00:42:20 -0600 Subject: [PATCH] Gift2: fix template->pk2 japanese enc as observed in discussion #4684 now matches Gift1 implementation details I really wish we had separate classes for PK1/PK2 for each language since the string buffers are different length, oh well this footgun exists. --- .../Legality/Encounters/Templates/Gen2/EncounterGift2.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PKHeX.Core/Legality/Encounters/Templates/Gen2/EncounterGift2.cs b/PKHeX.Core/Legality/Encounters/Templates/Gen2/EncounterGift2.cs index 18ac02786..7fb8f9bd9 100644 --- a/PKHeX.Core/Legality/Encounters/Templates/Gen2/EncounterGift2.cs +++ b/PKHeX.Core/Legality/Encounters/Templates/Gen2/EncounterGift2.cs @@ -94,8 +94,9 @@ public EncounterGift2(ReadOnlySpan data) public PK2 ConvertToPKM(ITrainerInfo tr, EncounterCriteria criteria) { var lang = GetLanguage((LanguageID)tr.Language); + var isJapanese = lang == Japanese; var pi = PersonalTable.C[Species]; - var pk = new PK2 + var pk = new PK2(isJapanese) { Species = Species, CurrentLevel = CurrentLevel == 0 ? LevelMin : CurrentLevel,