From afffaaa43cec042fce943de4cbecc6eb00a08ca3 Mon Sep 17 00:00:00 2001 From: Kurt Date: Mon, 29 Oct 2018 19:44:30 -0700 Subject: [PATCH] Enable full shadow lock checks If you find any edge cases (the code does not account for shiny locks yet) pls lmk, would be nice to have confirmed tests :) :) --- .../Legality/Encounters/Generator/EncounterGenerator.cs | 3 +-- PKHeX.Core/Legality/Verifiers/ParseSettings.cs | 5 ----- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/PKHeX.Core/Legality/Encounters/Generator/EncounterGenerator.cs b/PKHeX.Core/Legality/Encounters/Generator/EncounterGenerator.cs index 017707849..506ef1c0d 100644 --- a/PKHeX.Core/Legality/Encounters/Generator/EncounterGenerator.cs +++ b/PKHeX.Core/Legality/Encounters/Generator/EncounterGenerator.cs @@ -68,8 +68,7 @@ private static IEnumerable GetEncounters3(PKM pkm, LegalInfo inf var seeds = MethodFinder.GetPokeSpotSeeds(pkm, w.SlotNumber).FirstOrDefault(); info.PIDIV = seeds ?? info.PIDIV; } - else if (ParseSettings.FlagCXDShadowFirstLockMismatch - && z is EncounterStaticShadow s && !LockFinder.IsAllShadowLockValid(s, info.PIDIV)) + else if (z is EncounterStaticShadow s && !LockFinder.IsAllShadowLockValid(s, info.PIDIV)) { deferred.Add(s); continue; diff --git a/PKHeX.Core/Legality/Verifiers/ParseSettings.cs b/PKHeX.Core/Legality/Verifiers/ParseSettings.cs index 5d5a1512d..1eaef079b 100644 --- a/PKHeX.Core/Legality/Verifiers/ParseSettings.cs +++ b/PKHeX.Core/Legality/Verifiers/ParseSettings.cs @@ -23,11 +23,6 @@ public static class ParseSettings public static Severity NicknamedMysteryGift { get; set; } = Severity.Fishy; public static Severity RNGFrameNotFound { get; set; } = Severity.Fishy; - /// - /// Setting to specify if an analysis should flag a shadow encounter that does not match the first lock. - /// - public static bool FlagCXDShadowFirstLockMismatch { get; set; } - /// /// Checks to see if Crystal is available to visit/originate from. ///