From a25c6a4e00f0e94fc88adb6f6e7249e0151fedb4 Mon Sep 17 00:00:00 2001 From: wwwwwwzx Date: Thu, 24 May 2018 06:00:29 -0700 Subject: [PATCH] Fix Colo Starter PID Method Check (#1961) If SIDf >> 16 != SID then temp won't be assigned. --- PKHeX.Core/Legality/RNG/Locks/LockFinder.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PKHeX.Core/Legality/RNG/Locks/LockFinder.cs b/PKHeX.Core/Legality/RNG/Locks/LockFinder.cs index e751fe497..57ef431b1 100644 --- a/PKHeX.Core/Legality/RNG/Locks/LockFinder.cs +++ b/PKHeX.Core/Legality/RNG/Locks/LockFinder.cs @@ -144,7 +144,7 @@ public static bool IsColoStarterValid(int species, ref uint seed, int TID, int S var SIDf = rng.Reverse(seed, rev); int ctr = 0; uint temp = 0; - while (SIDf >> 16 != SID || (temp = rng.Prev(SIDf)) >> 16 != TID) + while ((temp = rng.Prev(SIDf)) >> 16 != TID || SIDf >> 16 != SID) { SIDf = temp; if (ctr > 32) // arbitrary