From 802b93bb16d0df41beeaef838547c9df9b8c5a06 Mon Sep 17 00:00:00 2001 From: Kurt Date: Tue, 10 Dec 2019 22:05:47 -0800 Subject: [PATCH] Fix xor order oops, upper half gets the star/square xor no real difference since PID is random --- PKHeX.Core/MysteryGifts/WC8.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PKHeX.Core/MysteryGifts/WC8.cs b/PKHeX.Core/MysteryGifts/WC8.cs index ae8240dcd..86986993b 100644 --- a/PKHeX.Core/MysteryGifts/WC8.cs +++ b/PKHeX.Core/MysteryGifts/WC8.cs @@ -454,11 +454,11 @@ private void SetPID(PKM pk, ITrainerInfo SAV) break; case Shiny.AlwaysStar: // Random Shiny pk.PID = Util.Rand32(); - pk.PID = (uint)(((pk.TID ^ pk.SID ^ (pk.PID & 0xFFFF)) << 16) | (pk.PID & 0xFFFF)) ^ 1; + pk.PID = (uint)(((pk.TID ^ pk.SID ^ (pk.PID & 0xFFFF) ^ 1) << 16) | (pk.PID & 0xFFFF)); break; case Shiny.AlwaysSquare: // Random Shiny pk.PID = Util.Rand32(); - pk.PID = (uint)(((pk.TID ^ pk.SID ^ (pk.PID & 0xFFFF)) << 16) | (pk.PID & 0xFFFF)) ^ 0; + pk.PID = (uint)(((pk.TID ^ pk.SID ^ (pk.PID & 0xFFFF) ^ 0) << 16) | (pk.PID & 0xFFFF)); break; case Shiny.Never: // Random Nonshiny pk.PID = Util.Rand32();