From 750044ea319f1c8d2767e7ecb5b2201a084c7817 Mon Sep 17 00:00:00 2001
From: Kurt <kaphotics@gmail.com>
Date: Mon, 26 Dec 2016 16:41:12 -0800
Subject: [PATCH] Improve slot lock detection

Uses sm lock indication (same placement), now only appears for teams
that are locked
slots that are not locked but assigned to a team are now indicated as
such, no prevention / moving to adjust team values is done.
#661
---
 PKHeX/MainWindow/Main.cs                     |  10 ++++-
 PKHeX/PKHeX.csproj                           |   3 ++
 PKHeX/Properties/Resources.Designer.cs       |  38 ++++++++++++-------
 PKHeX/Properties/Resources.resx              |   3 ++
 PKHeX/Resources/img/misc/locked.png          | Bin 1304 -> 393 bytes
 PKHeX/Resources/img/misc/team.png            | Bin 0 -> 555 bytes
 PKHeX/Saves/SAV7.cs                          |  36 +++++++++++++++---
 PKHeX/Saves/SaveFile.cs                      |   2 +
 PKHeX/Subforms/Save Editors/SAV_BoxViewer.cs |  10 ++++-
 9 files changed, 78 insertions(+), 24 deletions(-)
 create mode 100644 PKHeX/Resources/img/misc/team.png

diff --git a/PKHeX/MainWindow/Main.cs b/PKHeX/MainWindow/Main.cs
index eea6a0dc6..a0b108548 100644
--- a/PKHeX/MainWindow/Main.cs
+++ b/PKHeX/MainWindow/Main.cs
@@ -3768,8 +3768,11 @@ private void getQuickFiller(PictureBox pb, PKM pk = null)
             var sprite = pk.Species != 0 ? pk.Sprite : null;
             int slot = getSlot(pb);
             bool locked = slot < 30 && SAV.getIsSlotLocked(CB_BoxSelect.SelectedIndex, slot);
+            bool team = slot < 30 && SAV.getIsTeamSet(CB_BoxSelect.SelectedIndex, slot);
             if (locked)
-                sprite = Util.LayerImage(sprite, Properties.Resources.locked, 5, 0, 1);
+                sprite = Util.LayerImage(sprite, Properties.Resources.locked, 26, 0, 1);
+            else if (team)
+                sprite = Util.LayerImage(sprite, Properties.Resources.team, 21, 0, 1);
             pb.Image = sprite;
             if (pb.BackColor == Color.Red)
                 pb.BackColor = Color.Transparent;
@@ -3798,8 +3801,11 @@ private void getSlotFiller(int offset, PictureBox pb)
             var sprite = p.Species != 0 ? p.Sprite : null;
             int slot = getSlot(pb);
             bool locked = slot < 30 && SAV.getIsSlotLocked(CB_BoxSelect.SelectedIndex, slot);
+            bool team = slot < 30 && SAV.getIsTeamSet(CB_BoxSelect.SelectedIndex, slot);
             if (locked)
-                sprite = Util.LayerImage(sprite, Properties.Resources.locked, 5, 0, 1);
+                sprite = Util.LayerImage(sprite, Properties.Resources.locked, 26, 0, 1);
+            else if (team)
+                sprite = Util.LayerImage(sprite, Properties.Resources.team, 21, 0, 1);
             pb.Image = sprite;
             pb.BackColor = Color.Transparent;
             pb.Visible = true;
diff --git a/PKHeX/PKHeX.csproj b/PKHeX/PKHeX.csproj
index e56de69b5..22693b5ee 100644
--- a/PKHeX/PKHeX.csproj
+++ b/PKHeX/PKHeX.csproj
@@ -3779,6 +3779,9 @@
   <ItemGroup>
     <None Include="Resources\img\ribbons\ribbonbattletreemaster.png" />
   </ItemGroup>
+  <ItemGroup>
+    <None Include="Resources\img\misc\team.png" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.
diff --git a/PKHeX/Properties/Resources.Designer.cs b/PKHeX/Properties/Resources.Designer.cs
index c70f53010..59c47d1a4 100644
--- a/PKHeX/Properties/Resources.Designer.cs
+++ b/PKHeX/Properties/Resources.Designer.cs
@@ -12302,16 +12302,15 @@ internal class Resources {
         
         /// <summary>
         ///   Looks up a localized string similar to PKHeX - By Kaphotics
-        ///http://projectpokemon.org/
-        ///http://projectpokemon.org/forums/showthread.php?36986
+        ///http://projectpokemon.org/pkhex
         ///
-        ///11/18/16 - New Update:
-        /// - Added: Sun/Moon Support
-        /// - - Initial legality checking. Postgame encounters (Scan/Poke Pelago/etc) unsupported at this time.
-        /// - - QR Exporting for use with custom firmware patched code.
-        /// - - Trainer Editor and limited Pokedex editor
-        /// - Added: KChart, a personal info (base stats) viewer. Hold Shift when opening the PKM Database from the Tools drop-down.
-        /// - Added: Legal mo [rest of string was truncated]&quot;;.
+        ///16/12/21 - New Update:
+        /// - Legality: Fine tuned problematic cases (Island Scan, SOS slots, Ash Greninja, result descriptions).
+        /// - Added: Battle Box slot indication and edit prevention for Generation 7 save files.
+        /// - Added: Party Drag&amp;Drop
+        /// - Added: Zygarde Core stored count; also improved subform &quot;Collect All&quot; button method.
+        /// - Added: Pokédex forme editing (Gen7).
+        /// - Added: Advanced randomization for Batch Editor. Syntax: $x,y to have a random va [rest of string was truncated]&quot;;.
         /// </summary>
         internal static string changelog {
             get {
@@ -12611,7 +12610,8 @@ internal class Resources {
         ///   Looks up a localized string similar to 3100	Is Alolan Champion + Magearna Event Active
         ///3487	Received Magearna Gift
         ///1216	Received Gift Cosmog
-        ///0499	Received Gift Type:Null.
+        ///0499	Received Gift Type:Null
+        ///0160	Moone[0] / Sunne Portal [1].
         /// </summary>
         internal static string flags_sm {
             get {
@@ -17952,7 +17952,7 @@ internal class Resources {
         }
         
         /// <summary>
-        ///   Looks up a localized string similar to 20161118.
+        ///   Looks up a localized string similar to 20161221.
         /// </summary>
         internal static string ProgramVersion {
             get {
@@ -20873,6 +20873,16 @@ internal class Resources {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized resource of type System.Drawing.Bitmap.
+        /// </summary>
+        internal static System.Drawing.Bitmap team {
+            get {
+                object obj = ResourceManager.GetObject("team", resourceCulture);
+                return ((System.Drawing.Bitmap)(obj));
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to -
         ///Duftnote
@@ -33492,10 +33502,10 @@ internal class Resources {
         ///ライチュウ
         ///サンド
         ///サンドパン
-        ///ニドラン
+        ///ニドラン♀
         ///ニドリーナ
         ///ニドクイン
-        ///ニドラン
+        ///ニドラン♂
         ///ニドリーノ
         ///ニドキング
         ///ピッピ
@@ -33542,7 +33552,7 @@ internal class Resources {
         ///ゴローニャ
         ///ポニータ
         ///ギャロップ
-        ///ヤドン [rest of string was truncated]&quot;;.
+        ///ヤ [rest of string was truncated]&quot;;.
         /// </summary>
         internal static string text_species_ja {
             get {
diff --git a/PKHeX/Properties/Resources.resx b/PKHeX/Properties/Resources.resx
index 6dfc10105..0320404bc 100644
--- a/PKHeX/Properties/Resources.resx
+++ b/PKHeX/Properties/Resources.resx
@@ -7369,4 +7369,7 @@
   <data name="ribbonbattletreemaster" type="System.Resources.ResXFileRef, System.Windows.Forms">
     <value>..\Resources\img\ribbons\ribbonbattletreemaster.png;System.Drawing.Bitmap, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
   </data>
+  <data name="team" type="System.Resources.ResXFileRef, System.Windows.Forms">
+    <value>..\Resources\img\misc\team.png;System.Drawing.Bitmap, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
+  </data>
 </root>
\ No newline at end of file
diff --git a/PKHeX/Resources/img/misc/locked.png b/PKHeX/Resources/img/misc/locked.png
index 763a05a29bf03941ae41ec25231f9c032de4e225..6053f1967ca72a6a382e00b4b0511fe11c3123c9 100644
GIT binary patch
delta 329
zcmV-P0k-~_3W)<DiBL{Q4GJ0x0000DNk~Le0000E0000I2nGNE0Bc<DF_9rle*p(c
zL_t(IPmPmN6@xGgMUjAnN<ab<kbs0rKtd%Tp%N;g5|B^{%Wabmwz2Kw9g>%Kn|y4;
zI!~`!M7yY{sPQhjbHmWWcj^zkL1CLqPD?3A6E&XAHCw^a%oGXFAH~daFn}w~9yFBa
zvdad)OjXo)%*ZIX0w$Uxw{0(He^uczBcomdtWDh}T4jrQUE=k*dRI_Rx&`%I^E$Y1
zoa97&Ti-mBtNj~TU(D`@KAn03!#0-54OP^?!6ZWwfKySMe*=m%5d7Fd>L=K;S1>(6
zWZ>B&a|ScT5#`h<!zdd>9n_u~83i+-rwLwu8Bw<0h#46LJz(GZr^sIZACGMQ_5d?7
blAVSJ6Xf_1H%7G;00000NkvXXu0mjf=R$>0

delta 1247
zcmV<51R(o~1DFaSiBL{Q4GJ0x0000DNk~Le0000U0000U2nGNE06Q?QqLCp>e*~6E
zL_t(YOU0IbOw@H8$K`iV-0vU`h(#8fz$teJ0rC(a9HMBXqf$d$KIBYG;k2OKWe`wO
zh%vfGo3n_nC8SV58L}uH%GT7Ki)yoi*<5SR*~1@gYG(E6{rMhV635+fYxLV*gWvc2
z`F>u%`##SgqW^{QFOxj?riN%ie<kPvPH+X#82tVTr~&bS<GtdS7=fi=6x<MbgFonb
zFhO=RKE()PsYq%o(bAAzMc=k7>9-+?$O%T0Xyn8OI`i>PYO0*={(z;aAr3ST!v7Pb
zj8`!NxZ6aRc0a48-;YT2$EOngc|xMUPW~gN3zbAawi2DQkh4`o#TmB<fBBN+ko8C-
zfe9brOWX>malMwV^+-Z|_AMnfYz`*t12S131gj#ccB@(ZVisRNuA+lanOwg*C1en3
z)L??#m-rh_FxsLN;@(=dyDL4hzb00QFSc2zG&e$&WzUndkV*yo6QeSX8*W<?N>|zy
zbhTTeH5Q#nw!kQN#zw2lf0(#v^|q{eS_hZkmljHw4y);>xAW=cjdMk8zFB8OIvr2|
zx7?f9$_-yx8z#hG?^B9Ii|^KrqIxMP1bN^dkg+gPca-ao*)>AkyDMG9FG|w&qCOI6
zfM4QfZrHI^FT?}8UEORk%f}M#&{Sj?w0qEvbvX%gb$Yz^VU*jsf8OzoR)|mT%@gs3
z$+}^rn+aqfq0FcFb#B;gb%}ecypQh<T6Va^XImDDcg*bXk!}tM0}7N)E=EN^H)4)d
zgwt2eDym<nrN@h8DleAl=@Oaj+k@%VC&13z$%gT?t~OHHiYTgBCDW<Kbo$a>;Qko=
z>QhJ?0aSSREJk4we+NHO7(rc6&ZObG2>QjLa4#oc>zHTtg*Wra*<_)<7gK4=vM3?X
zGs#;Zc8{|saXkliRL`Z$Z3g=FwMfy`QxS7l|NPE!y4qhvA2gVS7?X^5GM?RHO?whI
zaNxlj@8Xd|61~4$L7%@j$E)~oW1<ijB<VUJ)B~}m0}_AHf2N>yxk@(!ZHs-1^AmNQ
z5Jm$nKvxAI-nV_cxNcL7Pcg>02g2DP6et1`_q{Y;{6<Z(PjRkE{t!X~;O<riB)&c<
z(Sa(Lys1o2*Us<oEjG#@L1+YGSp_8K$<<ls5;t4J{hD0Z-}@jm0p30X6JG|86}q~4
zgGEV~hBr@-f4G0o_%VKWZ|3xfo%<DZ)UKd2*wMZlFwhUDH%^auDm&Ly#8n*Vu*Lr;
z;;t8rLY$o-cli?MbKuIHFsd(&66f&{&SJg@_#-}dNKMD<=Tmz{3N=0&M-S!dg*b7R
zrWV2k;CVUmgR5x=2Tw-%{kY`ablJ0(+(pG%;T~fde{3F~A#Fa01D-dKu}6Vhg%OLs
z++vasV4ppW)8)LUr2hto!9}zg%`|8S%`qCsZF*%T@+|{t;7;Iq%N%?7=n4khEqr^J
z4;BJWuwqt}$_94D+^VVu&oLTR&?eNa1#7@+uo5f>1%RcofXA2fVvIbCgMbq7J&EP~
zrSZTFHBta4$^_XU2P_!-%kNyC4mghEd4G-pEaiNh7sn#a_#27XVv$xc4haAN002ov
JPDHLkV1fs-P@Vt)

diff --git a/PKHeX/Resources/img/misc/team.png b/PKHeX/Resources/img/misc/team.png
new file mode 100644
index 0000000000000000000000000000000000000000..42b081c1090d06ec60f76045e0c3c5dd1125d380
GIT binary patch
literal 555
zcmV+`0@VG9P)<h;3K|Lk000e1NJLTq000vJ000vR1^@s6a!@wR00004XF*Lt006O%
z3;baP00009a7bBm000ic000ic0Tn1pfB*mh7<5HgbW?9;ba!ELWdLwtX>N2bZe?^J
zG%heMIczh2P5=M_sYygZR5(wSlnZskFbqWtVGs(T5DFm>0-+EB!4M1~5DdW(3_%d~
zuKbCYbf=ro-f=8T*OFZCW@fJSE1dO|HmOL~X4cp*{xIHw7Kz|b!f(XAg9XXfd$9OO
zmX>095^L=2yI=J`V13ax>~)VVFx&o27G1l~tg*9?AO0=Q86D)M;lSw?0-!3#Vx~VI
zn$wouZvuMB9p<U0#XN%<R8phB>)#p`XmiO9<8~}ihDw-W`<gtkWF4|-U+ZoIjz4h?
z_5{XtYeUV|Mi2x=1^MYg2MFY)YV0o^rZxNCN5wVR2F!m)7&#>nIF;jrEC34#sN~|R
z)eKmv{Q|bu&Ae9-rIA%%1B}WFI|IAJ6xSI?X2ASZK=s=*5r7%{F1Uk~Is53GnfEMG
zCJyQa0>S_^?3(G-w(L?{pL#ZKGw60os|pw*pqCc32GWH;aSi6TS^LHlT8~l~S>@6z
z|5j-~L1cOTouTmpI<RNRpwt<J@cZorp!zl+6&Tih0U+!r(D62P@C8Wf8$INPPr^Qx
tHb8LBFytlwL0($dfV}~tfBvVn+c(KqK)&cD_h<kB002ovPDHLkV1kms>Y)Gt

literal 0
HcmV?d00001

diff --git a/PKHeX/Saves/SAV7.cs b/PKHeX/Saves/SAV7.cs
index ea6e2b2c2..4cdc674f4 100644
--- a/PKHeX/Saves/SAV7.cs
+++ b/PKHeX/Saves/SAV7.cs
@@ -30,17 +30,29 @@ public SAV7(byte[] data = null)
             {
                 PokeDex = -1; // Disabled
                 LockedSlots = new int[0];
+                TeamSlots = new int[0];
             }
             else // Valid slot locking info present
             {
-                int lockedCount = 0;
-                for (int i = 0; i < LockedSlots.Length; i++)
+                int lockedCount = 0, teamCount = 0;
+                for (int i = 0; i < TeamCount; i++)
                 {
-                    short val = BitConverter.ToInt16(Data, BattleBoxFlags + i*2);
-                    if (val >= 0)
-                        LockedSlots[lockedCount++] = (BoxSlotCount*(val >> 8) + (val & 0xFF)) & 0xFFFF;
+                    bool locked = Data[PCBackgrounds - TeamCount - i] == 1;
+                    for (int j = 0; j < 6; j++)
+                    {
+                        short val = BitConverter.ToInt16(Data, BattleBoxFlags + (i*6 + j) * 2);
+                        if (val < 0)
+                            continue;
+
+                        var slotVal = (BoxSlotCount*(val >> 8) + (val & 0xFF)) & 0xFFFF;
+
+                        if (locked)
+                            LockedSlots[lockedCount++] = slotVal;
+                        else TeamSlots[teamCount++] = slotVal;
+                    }
                 }
                 Array.Resize(ref LockedSlots, lockedCount);
+                Array.Resize(ref TeamSlots, teamCount);
             }
         }
 
@@ -237,7 +249,10 @@ private void getSAVOffsets()
                 PCFlags =               PCLayout + 0x5E0;
 
                 FashionLength = 0x1A08;
-                LockedSlots = new int[36];
+
+                TeamCount = 6;
+                LockedSlots = new int[6*TeamCount];
+                TeamSlots = new int[6*TeamCount];
             }
             else // Empty input
             {
@@ -260,6 +275,7 @@ private void getSAVOffsets()
         private int PokeFinderSave { get; set; } = int.MinValue;
         private int BattleTree { get; set; } = int.MinValue;
         private int BattleBoxFlags { get; set; } = int.MinValue;
+        private int TeamCount { get; set; } = int.MinValue;
 
         // Accessible as SAV7
         public int TrainerCard { get; private set; } = 0x14000;
@@ -915,6 +931,14 @@ public override bool getIsSlotLocked(int box, int slot)
             int slotIndex = slot + BoxSlotCount*box;
             return LockedSlots.Any(s => s == slotIndex);
         }
+        public override bool getIsTeamSet(int box, int slot)
+        {
+            if (slot >= 30 || box >= BoxCount)
+                return false;
+
+            int slotIndex = slot + BoxSlotCount * box;
+            return TeamSlots.Any(s => s == slotIndex);
+        }
 
         public override int DaycareSeedSize => 32; // 128 bits
         public override int getDaycareSlotOffset(int loc, int slot)
diff --git a/PKHeX/Saves/SaveFile.cs b/PKHeX/Saves/SaveFile.cs
index 6d25818f2..b59e09dbd 100644
--- a/PKHeX/Saves/SaveFile.cs
+++ b/PKHeX/Saves/SaveFile.cs
@@ -355,6 +355,7 @@ public virtual MysteryGiftAlbum GiftAlbum
         public virtual byte[] BoxFlags { get { return null; } set { } }
         public virtual int CurrentBox { get { return 0; } set { } }
         protected int[] LockedSlots = new int[0];
+        protected int[] TeamSlots = new int[0];
 
         protected virtual int getBoxWallpaperOffset(int box) { return -1; }
         public int getBoxWallpaper(int box)
@@ -459,6 +460,7 @@ public bool getBoxHasLockedSlot(int BoxStart, int BoxEnd)
         {
             return LockedSlots.Any(slot => BoxStart*BoxSlotCount <= slot && slot < (BoxEnd + 1)*BoxSlotCount);
         }
+        public virtual bool getIsTeamSet(int box, int slot) { return false; }
 
         public void sortBoxes(int BoxStart = 0, int BoxEnd = -1)
         {
diff --git a/PKHeX/Subforms/Save Editors/SAV_BoxViewer.cs b/PKHeX/Subforms/Save Editors/SAV_BoxViewer.cs
index 3b557e35c..43b0d292c 100644
--- a/PKHeX/Subforms/Save Editors/SAV_BoxViewer.cs	
+++ b/PKHeX/Subforms/Save Editors/SAV_BoxViewer.cs	
@@ -115,8 +115,11 @@ private void getSlotFiller(int offset, PictureBox pb)
             var sprite = p.Species != 0 ? p.Sprite : null;
             int slot = getSlot(pb);
             bool locked = slot < 30 && SAV.getIsSlotLocked(CB_BoxSelect.SelectedIndex, slot);
+            bool team = slot < 30 && SAV.getIsTeamSet(CB_BoxSelect.SelectedIndex, slot);
             if (locked)
-                sprite = Util.LayerImage(sprite, Properties.Resources.locked, 5, 0, 1);
+                sprite = Util.LayerImage(sprite, Properties.Resources.locked, 26, 0, 1);
+            else if (team)
+                sprite = Util.LayerImage(sprite, Properties.Resources.team, 21, 0, 1);
             pb.Image = sprite;
             pb.BackColor = Color.Transparent;
         }
@@ -125,8 +128,11 @@ private void getQuickFiller(PictureBox pb, PKM pk)
             var sprite = pk.Species != 0 ? pk.Sprite : null;
             int slot = getSlot(pb);
             bool locked = slot < 30 && SAV.getIsSlotLocked(CB_BoxSelect.SelectedIndex, slot);
+            bool team = slot < 30 && SAV.getIsTeamSet(CB_BoxSelect.SelectedIndex, slot);
             if (locked)
-                sprite = Util.LayerImage(sprite, Properties.Resources.locked, 5, 0, 1);
+                sprite = Util.LayerImage(sprite, Properties.Resources.locked, 26, 0, 1);
+            else if (team)
+                sprite = Util.LayerImage(sprite, Properties.Resources.team, 21, 0, 1);
             pb.Image = sprite;
             if (pb.BackColor == Color.Red)
                 pb.BackColor = Color.Transparent;