From 6fc8779aaa63ac4d144d4fb1d7bd1021cd307fe8 Mon Sep 17 00:00:00 2001 From: Kurt Date: Mon, 4 Jan 2021 17:31:56 -0800 Subject: [PATCH] Revert "Add vc shiny female gender ratio check" This reverts commit d5a1283585c9e3ae7a3b1e229255f7c2781ebe42. --- .../Legality/Verifiers/TransferVerifier.cs | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/PKHeX.Core/Legality/Verifiers/TransferVerifier.cs b/PKHeX.Core/Legality/Verifiers/TransferVerifier.cs index a1ebc23f5..732733b6a 100644 --- a/PKHeX.Core/Legality/Verifiers/TransferVerifier.cs +++ b/PKHeX.Core/Legality/Verifiers/TransferVerifier.cs @@ -67,22 +67,9 @@ private static void VerifyVCShinyXorIfShiny(LegalityAnalysis data) { // Star, not square. Requires transferring a shiny and having the initially random PID to already be a Star shiny. // (15:65536, ~1:4096) odds on a given shiny transfer! - var pkm = data.pkm; - var xor = pkm.ShinyXor; - if (xor <= 15) // Shiny! - { - if (xor != 0) - data.AddLine(Get(LEncStaticPIDShiny, ParseSettings.Gen7TransferStarPID, CheckIdentifier.PID)); - - // 12.5% Female Species cannot be shiny as Female due to IV-Shiny & IV-Gender calculation limits. - if (pkm.Gender == 1) // female - { - var species = data.Info.EncounterMatch.Species; - var pi = PersonalTable.GS[species]; - if (pi.Gender == 0x1F) // 12.5 Female - data.AddLine(GetInvalid(LEncStaticPIDShiny, CheckIdentifier.PID)); - } - } + var xor = data.pkm.ShinyXor; + if (xor is <= 15 and not 0) + data.AddLine(Get(LEncStaticPIDShiny, ParseSettings.Gen7TransferStarPID, CheckIdentifier.PID)); } private static void VerifyVCGeolocation(LegalityAnalysis data)