From 6d3ee54d44ddc6313efd25848805dc41d3cfbc6f Mon Sep 17 00:00:00 2001 From: Kurt Date: Sun, 19 Nov 2017 13:15:32 -0800 Subject: [PATCH] Reorder case fallthrough closes #1631 based on https://github.com/kwsch/PKHeX/commit/5859daf1d8db598a0bce04e9736b0eb6ff547a9e any case -> reverse game order --- PKHeX.Core/Legality/Core.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/PKHeX.Core/Legality/Core.cs b/PKHeX.Core/Legality/Core.cs index 5cab713c2..77e00be51 100644 --- a/PKHeX.Core/Legality/Core.cs +++ b/PKHeX.Core/Legality/Core.cs @@ -367,7 +367,6 @@ private static IEnumerable GetLvlMoves(int species, int form, int Generatio case 7: switch (ver) { - case GameVersion.Any: case GameVersion.SN: case GameVersion.MN: case GameVersion.SM: @@ -376,10 +375,9 @@ private static IEnumerable GetLvlMoves(int species, int form, int Generatio break; int index = PersonalTable.SM.GetFormeIndex(species, form); r.AddRange(LevelUpSM[index].GetMoves(lvl)); - if (ver == GameVersion.Any) // Fall Through - goto case GameVersion.USUM; break; } + case GameVersion.Any: case GameVersion.US: case GameVersion.UM: case GameVersion.USUM: @@ -388,6 +386,8 @@ private static IEnumerable GetLvlMoves(int species, int form, int Generatio if (index == 0) return r; r.AddRange(LevelUpUSUM[index].GetMoves(lvl)); + if (ver == GameVersion.Any) // Fall Through + goto case GameVersion.SM; break; } } @@ -1937,7 +1937,6 @@ private static IEnumerable GetMoves(PKM pkm, int species, int minlvlG1, int case 7: switch (ver) { - case GameVersion.Any: case GameVersion.SN: case GameVersion.MN: case GameVersion.SM: { if (species > MaxSpeciesID_7) @@ -1955,10 +1954,9 @@ private static IEnumerable GetMoves(PKM pkm, int species, int minlvlG1, int PersonalInfo pi = PersonalTable.SM.GetFormeEntry(species, form); r.AddRange(TMHM_SM.Where((t, m) => pi.TMHM[m])); } - if (ver == GameVersion.Any) // Fall Through - goto case GameVersion.USUM; break; } + case GameVersion.Any: case GameVersion.US: case GameVersion.UM: case GameVersion.USUM: { int index = PersonalTable.USUM.GetFormeIndex(species, form); @@ -1974,6 +1972,8 @@ private static IEnumerable GetMoves(PKM pkm, int species, int minlvlG1, int PersonalInfo pi = PersonalTable.USUM.GetFormeEntry(species, form); r.AddRange(TMHM_SM.Where((t, m) => pi.TMHM[m])); } + if (ver == GameVersion.Any) // Fall Through + goto case GameVersion.SM; break; } }