From 2fbe2feb5246ddc953e3484a065229bf9aa3a17c Mon Sep 17 00:00:00 2001 From: Kurt Date: Sat, 8 Mar 2025 11:13:35 -0600 Subject: [PATCH] Fix gen4 pcd sentinel set Closes #4407 Bug: 0th PCD slot not being provided would set PGT slot0 to "inactive", rather than setting pcd slot0. The modeled GUI is still very clunky (editing DP just ignores the flag, and assumes if data exists it is active). fix a typo while we're on the topic of Gen4 :) -- ty 0blivion0athkeeper on discord --- PKHeX.Core/Resources/text/script/gen4/flags_pt_en.txt | 2 +- PKHeX.Core/Resources/text/script/gen4/flags_pt_es.txt | 2 +- PKHeX.Core/Resources/text/script/gen4/flags_pt_ko.txt | 2 +- PKHeX.Core/Resources/text/script/gen4/flags_pt_zh-Hant.txt | 2 +- PKHeX.Core/Saves/SAV4.cs | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/PKHeX.Core/Resources/text/script/gen4/flags_pt_en.txt b/PKHeX.Core/Resources/text/script/gen4/flags_pt_en.txt index 29f893f46..d7fe2a480 100644 --- a/PKHeX.Core/Resources/text/script/gen4/flags_pt_en.txt +++ b/PKHeX.Core/Resources/text/script/gen4/flags_pt_en.txt @@ -58,7 +58,7 @@ 0134 g Traded in Eterna City 0244 g Traded in Snowpoint City 0245 g Traded on Route 226 -0325 r Dialga/Pakia rifts spawnable +0325 r Dialga/Palkia rifts spawnable 1051 s Found Adamant Orb on Mt. Coronet 1053 s Found Lustrous Orb on Mt. Coronet 2507 s Entered Pal Park Catching Show diff --git a/PKHeX.Core/Resources/text/script/gen4/flags_pt_es.txt b/PKHeX.Core/Resources/text/script/gen4/flags_pt_es.txt index b0db11501..d1f59a4db 100644 --- a/PKHeX.Core/Resources/text/script/gen4/flags_pt_es.txt +++ b/PKHeX.Core/Resources/text/script/gen4/flags_pt_es.txt @@ -58,7 +58,7 @@ 0134 g Intercambio en Ciudad Vetusta 0244 g Intercambio en Ciudad Puntaneva 0245 g Intercambio en Ruta 226 -0325 r Grieta de Dialga/Pakia visible +0325 r Grieta de Dialga/Palkia visible 1051 s Diamansfera encontrada en Monte Corona 1053 s Lustresfera encontrada en Monte Corona 2507 s Participado en las capturas del Parque Compi diff --git a/PKHeX.Core/Resources/text/script/gen4/flags_pt_ko.txt b/PKHeX.Core/Resources/text/script/gen4/flags_pt_ko.txt index 19b644e0c..ebcd848a7 100644 --- a/PKHeX.Core/Resources/text/script/gen4/flags_pt_ko.txt +++ b/PKHeX.Core/Resources/text/script/gen4/flags_pt_ko.txt @@ -55,7 +55,7 @@ 0134 e Traded in Eterna City 0244 e Traded in Snowpoint City 0245 g Traded on Route 226 -0325 g Dialga/Pakia rifts spawnable +0325 g Dialga/Palkia rifts spawnable 1051 g Found Adamant Orb on Mt. Coronet 1053 g Found Lustrous Orb on Mt. Coronet 2507 r Entered Pal Park Catching Show diff --git a/PKHeX.Core/Resources/text/script/gen4/flags_pt_zh-Hant.txt b/PKHeX.Core/Resources/text/script/gen4/flags_pt_zh-Hant.txt index 70c488b66..b2b7a4b4b 100644 --- a/PKHeX.Core/Resources/text/script/gen4/flags_pt_zh-Hant.txt +++ b/PKHeX.Core/Resources/text/script/gen4/flags_pt_zh-Hant.txt @@ -58,7 +58,7 @@ 0134 g Traded in Eterna City 0244 g Traded in Snowpoint City 0245 g Traded on Route 226 -0325 r Dialga/Pakia rifts spawnable +0325 r Dialga/Palkia rifts spawnable 1051 s Found Adamant Orb on Mt. Coronet 1053 s Found Lustrous Orb on Mt. Coronet 2507 s Entered Pal Park Catching Show diff --git a/PKHeX.Core/Saves/SAV4.cs b/PKHeX.Core/Saves/SAV4.cs index 1c231241e..47ce8a448 100644 --- a/PKHeX.Core/Saves/SAV4.cs +++ b/PKHeX.Core/Saves/SAV4.cs @@ -677,7 +677,7 @@ public override void SetMysteryGift(int index, PGT pgt) public override void SetMysteryGift(int index, PCD pcd) { base.SetMysteryGift(index, pcd); - SetMysteryGiftReceivedSentinel(index, pcd.Empty ? 0 : MysteryGiftDPSlotActive); + SetMysteryGiftReceivedSentinel(MaxCountPGT + index, pcd.Empty ? 0 : MysteryGiftDPSlotActive); } }