From db4ac6f517c6148338464e1fc459a4d148cb5480 Mon Sep 17 00:00:00 2001 From: tooomm Date: Sun, 22 Mar 2026 15:37:46 +0100 Subject: [PATCH] feedback --- scripts/update_image_links.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/scripts/update_image_links.py b/scripts/update_image_links.py index 276bc75..87919d0 100644 --- a/scripts/update_image_links.py +++ b/scripts/update_image_links.py @@ -17,6 +17,11 @@ import pathlib import shutil SCRYFALL_MAX_LIST_SIZE = 75 +SCRYFALL_API_HEADERS = { + 'Content-Type': 'application/json', + 'User-Agent': 'Magic-Token', + 'Accept': 'application/json', +} def cards_collection(identifiers): """ @@ -38,11 +43,7 @@ def cards_collection(identifiers): n += SCRYFALL_MAX_LIST_SIZE payload = json.dumps({'identifiers': chunk}).encode('utf-8') - req = Request('https://api.scryfall.com/cards/collection', payload, - headers={ - 'Content-Type': 'application/json', - 'User-Agent': 'Magic-Token', - 'Accept': 'application/json'}) + req = Request('https://api.scryfall.com/cards/collection', payload, headers=SCRYFALL_API_HEADERS) # Rate limiting cur_time = time.time() delta_time = cur_time - start_time @@ -54,8 +55,8 @@ def cards_collection(identifiers): with urlopen(req) as f: list_obj = json.load(f) except HTTPError as e: - print(e.read().decode()) - raise + error_body = e.read().decode() + raise RuntimeError(f"Scryfall API request failed: {error_body}") from e assert not list_obj.get('has_more', False) assert 'warnings' not in list_obj