From c2cf998d10c86998a4aa6f73a8bfd0dfbce535f4 Mon Sep 17 00:00:00 2001 From: Martin Riedel <1713643+rado0x54@users.noreply.github.com> Date: Sat, 27 Jul 2024 11:28:34 -0400 Subject: [PATCH] fix: use safeTitle instead of title for directory name on remote filesystem. This is a breaking change. Prior names with unsafe titlenames need to be moved manually. --- Makefile | 2 +- REMOTE_INSTRUCTIONS.MD | 7 +++++++ inc/data.h | 2 +- src/ui/fld.cpp | 6 +++--- 4 files changed, 12 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index f579866..557932a 100644 --- a/Makefile +++ b/Makefile @@ -38,7 +38,7 @@ INCLUDES := inc inc/ui inc/fs inc/gfx EXEFS_SRC := exefs_src APP_TITLE := JKSV APP_AUTHOR := JK -APP_VERSION := 07.25.2024 +APP_VERSION := 07.27.2024 ROMFS := romfs ICON := icon.jpg diff --git a/REMOTE_INSTRUCTIONS.MD b/REMOTE_INSTRUCTIONS.MD index fc3e61e..fcc1f04 100644 --- a/REMOTE_INSTRUCTIONS.MD +++ b/REMOTE_INSTRUCTIONS.MD @@ -1,4 +1,7 @@ # Remote Storage + +⚠️ **WARNING** ⚠️: Breaking change with Version 07.27.2024. See [here](#remote-changelog) + ##
How to use Google Drive with JKSV
**USING GOOGLE DRIVE WITH JKSV CURRENTLY REQUIRES BUILDING IT YOURSELF. I AM VERY BUSY LATELY AND THINGS WILL ONLY GET FINISHED WHEN I HAVE TIME. Thanks, sorry for yelling.** @@ -49,3 +52,7 @@ 2. Copy file to following folder on your card `SD:/config/JKSV/` 3. The next time you start JKSV on your Switch, you should get a popup about the Webdav status 4. If problems arise, check the log at `SD:/JKSV/log.txt` + +## Remote Changelog +- **07.27.2024**: **Breaking Change**. "Unsafe" characters were removed from titlename on the remote directory. That means, + that if you had existing safes under a title with unsafe characters, you will need to move them manually. diff --git a/inc/data.h b/inc/data.h index e93366d..fa73862 100644 --- a/inc/data.h +++ b/inc/data.h @@ -8,7 +8,7 @@ #include "gfx.h" #define BLD_MON 07 -#define BLD_DAY 25 +#define BLD_DAY 27 #define BLD_YEAR 2024 namespace data diff --git a/src/ui/fld.cpp b/src/ui/fld.cpp index 9aa3406..efc111e 100644 --- a/src/ui/fld.cpp +++ b/src/ui/fld.cpp @@ -317,10 +317,10 @@ void ui::fldPopulateMenu() unsigned fldInd = 1; if(fs::rfs) { - if(!fs::rfs->dirExists(t->title, fs::rfsRootID)) - fs::rfs->createDir(t->title, fs::rfsRootID); + if(!fs::rfs->dirExists(t->safeTitle, fs::rfsRootID)) + fs::rfs->createDir(t->safeTitle, fs::rfsRootID); - driveParent = fs::rfs->getDirID(t->title, fs::rfsRootID); + driveParent = fs::rfs->getDirID(t->safeTitle, fs::rfsRootID); driveFldList = fs::rfs->getListWithParent(driveParent); for(unsigned i = 0; i < driveFldList.size(); i++, fldInd++)