Leahnaya/FModel
1
0
Fork 0
mirror of https://github.com/4sval/FModel.git synced 2026-06-22 16:00:17 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Address code review feedback: extract constants, improve self-connection check, fix comment

Browse Source 
Co-authored-by: LoogLong <86428208+LoogLong@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-03-02 02:03:04 +00:00
parent 788cc6d410
commit d80132b876
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
FModel/ViewModels/AnimGraphViewModel.cs
View File

@ -40,6 +40,11 @@ public class AnimGraphConnection
public class AnimGraphViewModel
{
private const int GridColumns = 4;
private const int NodeHorizontalSpacing = 300;
private const int NodeVerticalSpacing = 200;
private const int MaxPropertyValueDisplayLength = 100;
public string PackageName { get; set; } = string.Empty;
public List<AnimGraphNode> Nodes { get; } = [];
public List<AnimGraphConnection> Connections { get; } = [];
@ -87,8 +92,8 @@ public class AnimGraphViewModel
{
Name = propName,
ExportType = structType,
NodePosX = nodeIndex % 4 * 300,
NodePosY = nodeIndex / 4 * 200
NodePosX = nodeIndex % GridColumns * NodeHorizontalSpacing,
NodePosY = nodeIndex / GridColumns * NodeVerticalSpacing
};
// Try to extract property values from the CDO
@ -146,7 +151,7 @@ public class AnimGraphViewModel
break;
default:
// Store additional properties for display in tooltip
if (value.Length <= 100)
if (value.Length <= MaxPropertyValueDisplayLength)
node.AdditionalProperties[name] = value;
break;
}
@ -229,11 +234,12 @@ public class AnimGraphViewModel
return;
var targetPropName = animNodeProps[linkId].name;
if (!nodeByName.TryGetValue(targetPropName, out var targetNode))
return;
// Avoid self-connections
if (sourceNode == targetNode) return;
if (targetPropName == sourceNode.Name) return;
if (!nodeByName.TryGetValue(targetPropName, out var targetNode))
return;
vm.Connections.Add(new AnimGraphConnection
{

2
FModel/Views/AnimGraphViewer.xaml.cs
View File

@ -64,7 +64,7 @@ public partial class AnimGraphViewer
DrawNode(node);
}
// Draw connection lines with actual pin positions
// Draw connection lines between pin positions
foreach (var conn in _viewModel.Connections)
{
DrawConnectionLine(conn);