Cockatrice/oracle
BruebachL a8a3fca8c9
Clean up inter-library dependencies with interfaces (#6280)
* Have CardDatabase::getPreferredPrintingInfo respect card provider ID overrides (pinned printings)

Took 13 minutes

Took 37 seconds

Took 10 seconds

Took 10 seconds

# Commit time for manual adjustment:
# Took 30 seconds

Took 15 seconds


Took 8 minutes

Took 21 seconds

* Move settings cache and settings card preference provider out of libcockatrice_settings and into cockatrice

Took 52 minutes

Took 9 minutes

Took 1 minute

* Temp cache.

Took 16 minutes

* Dependency Injection for SettingsCache

* Turn SettingsCache into a QSharedPointer.
* Implement interfaces for settings that need it

Took 2 hours 38 minutes

* Adjust oracle.

Took 5 minutes

* Move abstract/noop interfaces to libcockatrice_interfaces so they can be linked against independently.

Took 52 minutes

* Clean up some links.

Took 3 minutes

* Cleanup two includes.

Took 3 minutes

* More fixes.

Took 7 minutes

* More includes that slipped past.

Took 3 minutes

* Stop mocking and start injecting for tests.

Took 15 minutes

* I don't know why remote_client was including main.

Took 4 minutes

* Include.

Took 3 minutes

* Lint.

Took 2 minutes

* Don't use Qt pointers.

Took 1 hour 7 minutes

* Make parser use CardSettingsInterface

Took 13 minutes

* Also adjust constructor lol.

Took 8 minutes

* Lint.

Took 32 minutes

* Revert "Lint."

This reverts commit ecb596c39e.


Took 3 minutes

* Test.

Took 3 minutes

---------

Co-authored-by: Lukas Brübach <Bruebach.Lukas@bdosecurity.de>
2025-11-08 22:19:40 +01:00
..
resources Update macOS Monterey app icon (#4805) 2023-08-06 17:46:03 -04:00
src Clean up inter-library dependencies with interfaces (#6280) 2025-11-08 22:19:40 +01:00
translations Updates for project Cockatrice and language en@pirate (#6256) 2025-10-26 13:46:46 +01:00
CMakeLists.txt Clean up inter-library dependencies with interfaces (#6280) 2025-11-08 22:19:40 +01:00
oracle_en@source.ts Update translation source strings (#6203) 2025-10-09 23:05:12 +02:00
oracle.desktop Add icon to oracle 2014-08-07 17:27:15 +02:00
oracle.qrc Add icon to oracle 2014-08-07 17:27:15 +02:00
oracle.rc Add icon to oracle 2014-08-07 17:27:15 +02:00