From 6cace2a8e6bdab132faef1bcc7aa2b570921627a Mon Sep 17 00:00:00 2001 From: SlightlyCircuitous <71394296+SlightlyCircuitous@users.noreply.github.com> Date: Fri, 8 May 2026 18:05:10 -0400 Subject: [PATCH] Bump minimum required cmake to 3.10 in gtest (#6851) * Bump minimum_required to 3.5 and GoogleTest to 1.12 GoogleTest 1.12 is the oldest version that sets cmake_minimum_required() to 3.5 in the CMakeLists files it provides * code style changes * Use 1.17.0 * Set minimum to 3.10 to make top-level CMakeLists * New hash Co-authored-by: tooomm * Update cmake/gtest-CMakeLists.txt.in Co-authored-by: tooomm --------- Co-authored-by: tooomm Co-authored-by: ebbit1q --- cmake/gtest-CMakeLists.txt.in | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/cmake/gtest-CMakeLists.txt.in b/cmake/gtest-CMakeLists.txt.in index 2d71a55e5..2062d7f8c 100644 --- a/cmake/gtest-CMakeLists.txt.in +++ b/cmake/gtest-CMakeLists.txt.in @@ -1,15 +1,16 @@ -cmake_minimum_required(VERSION 3.2) +cmake_minimum_required(VERSION 3.10) project(gtest-download LANGUAGES NONE) include(ExternalProject) -ExternalProject_Add(googletest - URL https://github.com/google/googletest/archive/release-1.11.0.zip - URL_HASH SHA1=9ffb7b5923f4a8fcdabf2f42c6540cce299f44c0 +externalproject_add( + googletest + URL https://github.com/google/googletest/archive/refs/tags/v1.17.0.zip + URL_HASH SHA1=f638fa0e724760e2ba07ff8cfba32cd644e1ce28 SOURCE_DIR "${CMAKE_BINARY_DIR}/gtest-src" BINARY_DIR "${CMAKE_BINARY_DIR}/gtest-build" CONFIGURE_COMMAND "" - BUILD_COMMAND "" - INSTALL_COMMAND "" - TEST_COMMAND "" + BUILD_COMMAND "" + INSTALL_COMMAND "" + TEST_COMMAND "" )